Bluetooth: hci0: Error when powering off device on rfkill (-4)
Bluetooth: hci1: Opcode 0x0c1a failed: -4
Bluetooth: hci1: Error when powering off device on rfkill (-4)
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc3-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.246/6961 is trying to acquire lock:
ffff88805817f840 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: touch_work_lockdep_map kernel/workqueue.c:3924 [inline]
ffff88805817f840 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: start_flush_work kernel/workqueue.c:4178 [inline]
ffff88805817f840 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}, at: __flush_work+0x4d0/0xcc0 kernel/workqueue.c:4210

but task is already holding lock:
ffff88805817fb38 (&conn->lock#2){+.+.}-{4:4}, at: l2cap_conn_del+0x80/0x730 net/bluetooth/l2cap_core.c:1762

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&conn->lock#2){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:602 [inline]
       __mutex_lock+0x199/0xb90 kernel/locking/mutex.c:747
       l2cap_info_timeout+0x79/0xa0 net/bluetooth/l2cap_core.c:1668
       process_one_work+0x9cc/0x1b70 kernel/workqueue.c:3238
       process_scheduled_works kernel/workqueue.c:3321 [inline]
       worker_thread+0x6c8/0xf10 kernel/workqueue.c:3402
       kthread+0x3c2/0x780 kernel/kthread.c:464
       ret_from_fork+0x5d4/0x6f0 arch/x86/kernel/process.c:148
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #0 ((work_completion)(&(&conn->info_timer)->work)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain kernel/locking/lockdep.c:3911 [inline]
       __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240
       lock_acquire kernel/locking/lockdep.c:5871 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828
       touch_work_lockdep_map kernel/workqueue.c:3924 [inline]
       start_flush_work kernel/workqueue.c:4178 [inline]
       __flush_work+0x4e4/0xcc0 kernel/workqueue.c:4210
       __cancel_work_sync+0x10c/0x130 kernel/workqueue.c:4366
       l2cap_conn_del+0x5af/0x730 net/bluetooth/l2cap_core.c:1796
       l2cap_disconn_cfm net/bluetooth/l2cap_core.c:7302 [inline]
       l2cap_disconn_cfm+0x96/0xd0 net/bluetooth/l2cap_core.c:7295
       hci_disconn_cfm include/net/bluetooth/hci_core.h:2069 [inline]
       hci_conn_hash_flush+0x10e/0x260 net/bluetooth/hci_conn.c:2560
       hci_dev_close_sync+0x602/0x11d0 net/bluetooth/hci_sync.c:5250
       hci_dev_do_close+0x2e/0x90 net/bluetooth/hci_core.c:483
       hci_rfkill_set_block+0x225/0x360 net/bluetooth/hci_core.c:911
       rfkill_set_block+0x1fe/0x550 net/rfkill/core.c:346
       rfkill_fop_write+0x2c0/0x580 net/rfkill/core.c:1301
       vfs_write+0x29d/0x1150 fs/read_write.c:684
       ksys_write+0x1f8/0x250 fs/read_write.c:738
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&conn->lock#2);
                               lock((work_completion)(&(&conn->info_timer)->work));
                               lock(&conn->lock#2);
  lock((work_completion)(&(&conn->info_timer)->work));

 *** DEADLOCK ***

6 locks held by syz.5.246/6961:
 #0: ffffffff907ee148 (rfkill_global_mutex){+.+.}-{4:4}, at: rfkill_fop_write+0x166/0x580 net/rfkill/core.c:1293
 #1: ffff888055584d80 (&hdev->req_lock){+.+.}-{4:4}, at: hci_dev_do_close+0x26/0x90 net/bluetooth/hci_core.c:481
 #2: ffff888055584078 (&hdev->lock){+.+.}-{4:4}, at: hci_dev_close_sync+0x3ae/0x11d0 net/bluetooth/hci_sync.c:5238
 #3: ffffffff905be208 (hci_cb_list_lock){+.+.}-{4:4}, at: hci_disconn_cfm include/net/bluetooth/hci_core.h:2066 [inline]
 #3: ffffffff905be208 (hci_cb_list_lock){+.+.}-{4:4}, at: hci_conn_hash_flush+0xbb/0x260 net/bluetooth/hci_conn.c:2560
 #4: ffff88805817fb38 (&conn->lock#2){+.+.}-{4:4}, at: l2cap_conn_del+0x80/0x730 net/bluetooth/l2cap_core.c:1762
 #5: ffffffff8e5c4940 (rcu_read_lock){....}-{1:3}, at: rcu_lock_acquire include/linux/rcupdate.h:331 [inline]
 #5: ffffffff8e5c4940 (rcu_read_lock){....}-{1:3}, at: rcu_read_lock include/linux/rcupdate.h:841 [inline]
 #5: ffffffff8e5c4940 (rcu_read_lock){....}-{1:3}, at: start_flush_work kernel/workqueue.c:4152 [inline]
 #5: ffffffff8e5c4940 (rcu_read_lock){....}-{1:3}, at: __flush_work+0xfb/0xcc0 kernel/workqueue.c:4210

stack backtrace:
CPU: 2 UID: 0 PID: 6961 Comm: syz.5.246 Not tainted 6.16.0-rc3-syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2046
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain kernel/locking/lockdep.c:3911 [inline]
 __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240
 lock_acquire kernel/locking/lockdep.c:5871 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828
 touch_work_lockdep_map kernel/workqueue.c:3924 [inline]
 start_flush_work kernel/workqueue.c:4178 [inline]
 __flush_work+0x4e4/0xcc0 kernel/workqueue.c:4210
 __cancel_work_sync+0x10c/0x130 kernel/workqueue.c:4366
 l2cap_conn_del+0x5af/0x730 net/bluetooth/l2cap_core.c:1796
 l2cap_disconn_cfm net/bluetooth/l2cap_core.c:7302 [inline]
 l2cap_disconn_cfm+0x96/0xd0 net/bluetooth/l2cap_core.c:7295
 hci_disconn_cfm include/net/bluetooth/hci_core.h:2069 [inline]
 hci_conn_hash_flush+0x10e/0x260 net/bluetooth/hci_conn.c:2560
 hci_dev_close_sync+0x602/0x11d0 net/bluetooth/hci_sync.c:5250
 hci_dev_do_close+0x2e/0x90 net/bluetooth/hci_core.c:483
 hci_rfkill_set_block+0x225/0x360 net/bluetooth/hci_core.c:911
 rfkill_set_block+0x1fe/0x550 net/rfkill/core.c:346
 rfkill_fop_write+0x2c0/0x580 net/rfkill/core.c:1301
 vfs_write+0x29d/0x1150 fs/read_write.c:684
 ksys_write+0x1f8/0x250 fs/read_write.c:738
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f0f5f58e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0f603bb038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f0f5f7b5fa0 RCX: 00007f0f5f58e929
RDX: 0000000000000008 RSI: 0000200000000080 RDI: 0000000000000003
RBP: 00007f0f5f610b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f0f5f7b5fa0 R15: 00007ffeebe06d98
 </TASK>