====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc6-syzkaller-00005-gb947cc5bf6d7 #0 Not tainted ------------------------------------------------------ syz-executor.1/9952 is trying to acquire lock: ffff88805d6c58f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff88805ee1cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x204/0x9e0 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_get_block+0x277/0x9e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x38f/0xa70 fs/buffer.c:2384 filemap_read_folio+0xe5/0x2c0 mm/filemap.c:2331 do_read_cache_folio+0x203/0x540 mm/filemap.c:3747 do_read_cache_page mm/filemap.c:3813 [inline] read_cache_page+0x5b/0x160 mm/filemap.c:3822 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0x148/0x990 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_get_block+0x1ae/0x9e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:649 [inline] do_direct_IO fs/direct-io.c:937 [inline] __blockdev_direct_IO+0x2456/0x3d50 fs/direct-io.c:1250 blockdev_direct_IO include/linux/fs.h:3190 [inline] hfsplus_direct_IO+0x10c/0x2d0 fs/hfsplus/inode.c:130 generic_file_direct_write+0x139/0x3a0 mm/filemap.c:3899 __generic_file_write_iter+0x121/0x240 mm/filemap.c:4055 generic_file_write_iter+0xe7/0x350 mm/filemap.c:4095 call_write_iter include/linux/fs.h:2110 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x6db/0x1100 fs/read_write.c:590 ksys_write+0x12f/0x260 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a6/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x836/0x9e0 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18f/0x220 fs/hfsplus/inode.c:450 hfsplus_unlink+0x583/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x2fb/0x910 fs/namei.c:4335 do_unlinkat+0x5c0/0x750 fs/namei.c:4399 __do_sys_unlinkat fs/namei.c:4442 [inline] __se_sys_unlinkat fs/namei.c:4435 [inline] __x64_sys_unlinkat+0xc1/0x130 fs/namei.c:4435 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz-executor.1/9952: #0: ffff88802d5f0420 (sb_writers #19){.+.+}-{0:0}, at: do_unlinkat+0x1d3/0x750 fs/namei.c:4382 #1: ffff88805ee1e180 (&type->i_mutex_dir_key#13/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:830 [inline] #1: ffff88805ee1e180 (&type->i_mutex_dir_key#13/1){+.+.}-{3:3}, at: do_unlinkat+0x288/0x750 fs/namei.c:4386 #2: ffff88805ee1cd40 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:795 [inline] #2: ffff88805ee1cd40 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: vfs_unlink+0xd3/0x910 fs/namei.c:4324 #3: ffff88805d6c5998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x184/0x7f0 fs/hfsplus/dir.c:370 #4: ffff88805ee1cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x204/0x9e0 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 9952 Comm: syz-executor.1 Not tainted 6.9.0-rc6-syzkaller-00005-gb947cc5bf6d7 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_block_free+0xd2/0x530 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a6/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x836/0x9e0 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18f/0x220 fs/hfsplus/inode.c:450 hfsplus_unlink+0x583/0x7f0 fs/hfsplus/dir.c:405 vfs_unlink+0x2fb/0x910 fs/namei.c:4335 do_unlinkat+0x5c0/0x750 fs/namei.c:4399 __do_sys_unlinkat fs/namei.c:4442 [inline] __se_sys_unlinkat fs/namei.c:4435 [inline] __x64_sys_unlinkat+0xc1/0x130 fs/namei.c:4435 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f4f14c7dea9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4f15aa50c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000107 RAX: ffffffffffffffda RBX: 00007f4f14dabf80 RCX: 00007f4f14c7dea9 RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000004 RBP: 00007f4f14cca4a4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f4f14dabf80 R15: 00007ffe05c64478 hfsplus: unable to mark blocks free: error -4 hfsplus: can't free extent