======================================================
WARNING: possible circular locking dependency detected
6.1.131-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor/4547 is trying to acquire lock:
ffff0000ce537138 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: __flush_workqueue+0x120/0x11c4 kernel/workqueue.c:2812

but task is already holding lock:
ffff0000c38ae0e0 (&type->s_umount_key#88){++++}-{3:3}, at: deactivate_super+0xe8/0x110 fs/super.c:362

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->s_umount_key#88){++++}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ocfs2_finish_quota_recovery+0x194/0x2090 fs/ocfs2/quota_local.c:600
       ocfs2_complete_recovery+0x1534/0x259c fs/ocfs2/journal.c:1324
       process_one_work+0x804/0x1484 kernel/workqueue.c:2292
       worker_thread+0x8e4/0xfec kernel/workqueue.c:2439
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864

-> #1 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}:
       process_one_work+0x724/0x1484 kernel/workqueue.c:2268
       worker_thread+0x8e4/0xfec kernel/workqueue.c:2439
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864

-> #0 ((wq_completion)ocfs2_wq){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       __flush_workqueue+0x14c/0x11c4 kernel/workqueue.c:2812
       ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:379
       ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
       ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
       generic_shutdown_super+0x130/0x328 fs/super.c:501
       kill_block_super+0x70/0xdc fs/super.c:1470
       deactivate_locked_super+0xac/0x124 fs/super.c:332
       deactivate_super+0xf0/0x110 fs/super.c:363
       cleanup_mnt+0x394/0x41c fs/namespace.c:1186
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1193
       task_work_run+0x240/0x2f0 kernel/task_work.c:203
       resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
       do_notify_resume+0x2080/0x2cb8 arch/arm64/kernel/signal.c:1132
       prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
       el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) --> &type->s_umount_key#88

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->s_umount_key#88);
                               lock((work_completion)(&journal->j_recovery_work));
                               lock(&type->s_umount_key#88);
  lock((wq_completion)ocfs2_wq);

 *** DEADLOCK ***

1 lock held by syz-executor/4547:
 #0: ffff0000c38ae0e0 (&type->s_umount_key#88){++++}-{3:3}, at: deactivate_super+0xe8/0x110 fs/super.c:362

stack backtrace:
CPU: 1 PID: 4547 Comm: syz-executor Not tainted 6.1.131-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 __flush_workqueue+0x14c/0x11c4 kernel/workqueue.c:2812
 ocfs2_shutdown_local_alloc+0x104/0x8d8 fs/ocfs2/localalloc.c:379
 ocfs2_dismount_volume+0x1fc/0x99c fs/ocfs2/super.c:1879
 ocfs2_put_super+0x110/0x3e8 fs/ocfs2/super.c:1609
 generic_shutdown_super+0x130/0x328 fs/super.c:501
 kill_block_super+0x70/0xdc fs/super.c:1470
 deactivate_locked_super+0xac/0x124 fs/super.c:332
 deactivate_super+0xf0/0x110 fs/super.c:363
 cleanup_mnt+0x394/0x41c fs/namespace.c:1186
 __cleanup_mnt+0x20/0x30 fs/namespace.c:1193
 task_work_run+0x240/0x2f0 kernel/task_work.c:203
 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
 do_notify_resume+0x2080/0x2cb8 arch/arm64/kernel/signal.c:1132
 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
 exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
 el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
ocfs2: Unmounting device (7,5) on (node local)