====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc4-syzkaller-00013-g66701750d556 #0 Not tainted ------------------------------------------------------ syz.0.293/7789 is trying to acquire lock: ffff888074716a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 but task is already holding lock: ffff888074716d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] ffff888074716d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:869 [inline] ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7b1/0xf10 fs/quota/dquot.c:977 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2820 quota_setquota+0x4b4/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x72a/0xf10 fs/quota/dquot.c:972 dquot_transfer+0x2f8/0x6d0 fs/quota/dquot.c:2140 ext4_setattr+0x865/0x1bc0 fs/ext4/inode.c:5817 notify_change+0xb36/0xe40 fs/attr.c:552 chown_common+0x40c/0x5c0 fs/open.c:790 vfs_fchown fs/open.c:858 [inline] ksys_fchown+0xea/0x160 fs/open.c:870 __do_sys_fchown fs/open.c:875 [inline] __se_sys_fchown fs/open.c:873 [inline] __x64_sys_fchown+0x7a/0x90 fs/open.c:873 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&ei->xattr_sem){++++}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline] ext4_xattr_set_handle+0x165/0x1590 fs/ext4/xattr.c:2362 ext4_initxattrs+0x9f/0x110 fs/ext4/xattr_security.c:44 security_inode_init_security+0x2a0/0x3f0 security/security.c:1852 __ext4_new_inode+0x3257/0x3c50 fs/ext4/ialloc.c:1325 ext4_create+0x22d/0x460 fs/ext4/namei.c:2822 lookup_open fs/namei.c:3717 [inline] open_last_lookups fs/namei.c:3816 [inline] path_openat+0x14f4/0x3830 fs/namei.c:4052 do_filp_open+0x1fa/0x410 fs/namei.c:4082 do_sys_openat2+0x121/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_openat fs/open.c:1468 [inline] __se_sys_openat fs/open.c:1463 [inline] __x64_sys_openat+0x138/0x170 fs/open.c:1463 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444 jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501 jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540 ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:374 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1254 [inline] ocfs2_reserve_local_alloc_bits+0xb04/0x24e0 fs/ocfs2/localalloc.c:669 ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2854 [inline] ocfs2_extend_dir+0x701/0x4870 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2fe8/0x5450 fs/ocfs2/dir.c:4304 ocfs2_mknod+0x819/0x2050 fs/ocfs2/namei.c:294 ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656 vfs_mkdir+0x306/0x510 fs/namei.c:4375 do_mkdirat+0x247/0x590 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:372 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1254 [inline] ocfs2_reserve_local_alloc_bits+0xb04/0x24e0 fs/ocfs2/localalloc.c:669 ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2854 [inline] ocfs2_extend_dir+0x701/0x4870 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2fe8/0x5450 fs/ocfs2/dir.c:4304 ocfs2_mknod+0x819/0x2050 fs/ocfs2/namei.c:294 ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656 vfs_mkdir+0x306/0x510 fs/namei.c:4375 do_mkdirat+0x247/0x590 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_internal#6){.+.+}-{0:0}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370 ocfs2_write_begin_inline fs/ocfs2/aops.c:1458 [inline] ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1562 [inline] ocfs2_write_begin_nolock+0x1ca6/0x4340 fs/ocfs2/aops.c:1648 ocfs2_write_begin+0x1bb/0x310 fs/ocfs2/aops.c:1882 generic_perform_write+0x2c7/0x910 mm/filemap.c:4112 ocfs2_file_write_iter+0x157a/0x1d10 fs/ocfs2/file.c:2469 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x548/0xa90 fs/read_write.c:686 ksys_write+0x145/0x250 fs/read_write.c:738 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7b1/0xf10 fs/quota/dquot.c:977 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2820 quota_setquota+0x4b4/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); *** DEADLOCK *** 3 locks held by syz.0.293/7789: #0: ffff88807f9080e0 (&type->s_umount_key#105){++++}-{4:4}, at: __super_lock fs/super.c:59 [inline] #0: ffff88807f9080e0 (&type->s_umount_key#105){++++}-{4:4}, at: super_lock+0x2a9/0x3b0 fs/super.c:121 #1: ffff8880747ea0a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb30 fs/ocfs2/quota_global.c:823 #2: ffff888074716d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #2: ffff888074716d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270 fs/ocfs2/quota_global.c:313 stack backtrace: CPU: 0 UID: 0 PID: 7789 Comm: syz.0.293 Not tainted 6.16.0-rc4-syzkaller-00013-g66701750d556 #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1e8/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb30 fs/ocfs2/quota_global.c:828 dqget+0x7b1/0xf10 fs/quota/dquot.c:977 dquot_set_dqblk+0x2b/0xfa0 fs/quota/dquot.c:2820 quota_setquota+0x4b4/0x540 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x279/0x950 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fd9cad8e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd9cbb98038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007fd9cafb5fa0 RCX: 00007fd9cad8e929 RDX: 0000000000000000 RSI: 0000200000000240 RDI: ffffffff80000801 RBP: 00007fd9cae10b39 R08: 0000000000000000 R09: 0000000000000000 R10: 0000200000000f00 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fd9cafb5fa0 R15: 00007ffd85f5e688