====================================================== WARNING: possible circular locking dependency detected 6.1.129-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor405/4348 is trying to acquire lock: ffff0000dc4f0070 (&newdev->mutex){+.+.}-{3:3}, at: uinput_request_send drivers/input/misc/uinput.c:150 [inline] ffff0000dc4f0070 (&newdev->mutex){+.+.}-{3:3}, at: uinput_request_submit+0x188/0x654 drivers/input/misc/uinput.c:181 but task is already holding lock: ffff0000dc4f08b0 (&ff->mutex){+.+.}-{3:3}, at: input_ff_upload+0x31c/0x834 drivers/input/ff-core.c:122 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ff->mutex){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 input_ff_flush+0x64/0x150 drivers/input/ff-core.c:242 uinput_dev_flush+0x30/0x4c drivers/input/misc/uinput.c:282 input_flush_device+0xa4/0xd4 drivers/input/input.c:682 evdev_release+0xec/0x2ec drivers/input/evdev.c:444 __fput+0x1c8/0x7c8 fs/file_table.c:320 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x240/0x2f0 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x2080/0x2cb8 arch/arm64/kernel/signal.c:1132 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (&dev->mutex#2){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_interruptible_nested+0x38/0x44 kernel/locking/mutex.c:821 input_register_handle+0x74/0x2d0 drivers/input/input.c:2629 kbd_connect+0xc4/0x13c drivers/tty/vt/keyboard.c:1589 input_attach_handler drivers/input/input.c:1060 [inline] input_register_device+0xaf8/0xf8c drivers/input/input.c:2470 acpi_button_add+0x578/0x8e4 drivers/acpi/button.c:570 acpi_device_probe+0xa8/0x2c0 drivers/acpi/bus.c:1023 really_probe+0x394/0xacc drivers/base/dd.c:639 __driver_probe_device+0x194/0x3b4 drivers/base/dd.c:785 driver_probe_device+0x78/0x330 drivers/base/dd.c:815 __driver_attach+0x3dc/0x648 drivers/base/dd.c:1201 bus_for_each_dev+0x14c/0x1cc drivers/base/bus.c:303 driver_attach+0x4c/0x5c drivers/base/dd.c:1218 bus_add_driver+0x2ec/0x570 drivers/base/bus.c:620 driver_register+0x200/0x378 drivers/base/driver.c:246 acpi_bus_register_driver+0xf8/0x11c drivers/acpi/bus.c:974 acpi_button_register_driver drivers/acpi/button.c:660 [inline] acpi_button_driver_init+0xd4/0x10c drivers/acpi/button.c:669 do_one_initcall+0x260/0xacc init/main.c:1298 do_initcall_level+0x154/0x214 init/main.c:1371 do_initcalls+0x58/0xac init/main.c:1387 do_basic_setup+0x8c/0xa0 init/main.c:1406 kernel_init_freeable+0x3a4/0x528 init/main.c:1626 kernel_init+0x24/0x29c init/main.c:1514 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864 -> #1 (input_mutex){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_interruptible_nested+0x38/0x44 kernel/locking/mutex.c:821 input_register_device+0x914/0xf8c drivers/input/input.c:2463 uinput_create_device+0x360/0x528 drivers/input/misc/uinput.c:364 uinput_ioctl_handler+0x8b0/0x16c0 drivers/input/misc/uinput.c:884 uinput_ioctl+0x38/0x4c drivers/input/misc/uinput.c:1055 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&newdev->mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_interruptible_nested+0x38/0x44 kernel/locking/mutex.c:821 uinput_request_send drivers/input/misc/uinput.c:150 [inline] uinput_request_submit+0x188/0x654 drivers/input/misc/uinput.c:181 uinput_dev_upload_effect+0x170/0x218 drivers/input/misc/uinput.c:256 input_ff_upload+0x49c/0x834 drivers/input/ff-core.c:152 evdev_do_ioctl drivers/input/evdev.c:1183 [inline] evdev_ioctl_handler+0x1fd8/0x2d60 drivers/input/evdev.c:1272 evdev_ioctl+0x38/0x4c drivers/input/evdev.c:1281 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &newdev->mutex --> &dev->mutex#2 --> &ff->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ff->mutex); lock(&dev->mutex#2); lock(&ff->mutex); lock(&newdev->mutex); *** DEADLOCK *** 2 locks held by syz-executor405/4348: #0: ffff0000dc4fd110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_ioctl_handler+0x11c/0x2d60 drivers/input/evdev.c:1263 #1: ffff0000dc4f08b0 (&ff->mutex){+.+.}-{3:3}, at: input_ff_upload+0x31c/0x834 drivers/input/ff-core.c:122 stack backtrace: CPU: 0 PID: 4348 Comm: syz-executor405 Not tainted 6.1.129-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_interruptible_nested+0x38/0x44 kernel/locking/mutex.c:821 uinput_request_send drivers/input/misc/uinput.c:150 [inline] uinput_request_submit+0x188/0x654 drivers/input/misc/uinput.c:181 uinput_dev_upload_effect+0x170/0x218 drivers/input/misc/uinput.c:256 input_ff_upload+0x49c/0x834 drivers/input/ff-core.c:152 evdev_do_ioctl drivers/input/evdev.c:1183 [inline] evdev_ioctl_handler+0x1fd8/0x2d60 drivers/input/evdev.c:1272 evdev_ioctl+0x38/0x4c drivers/input/evdev.c:1281 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585