ntfs3: Cannot use different iocharset when remounting! ====================================================== WARNING: possible circular locking dependency detected 6.11.0-syzkaller-08068-g1ec6d097897a #0 Not tainted ------------------------------------------------------ syz.1.421/8886 is trying to acquire lock: ffff88805c5a67d0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] ffff88805c5a67d0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_read_folio+0xc0/0x210 fs/ntfs3/inode.c:718 but task is already holding lock: ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:870 [inline] ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_create_folio mm/filemap.c:2485 [inline] ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_get_pages+0xd3e/0x2540 mm/filemap.c:2552 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#9){.+.+}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:870 [inline] filemap_fault+0x6e8/0x1950 mm/filemap.c:3327 __do_fault+0x135/0x460 mm/memory.c:4876 do_read_fault mm/memory.c:5282 [inline] do_fault mm/memory.c:5416 [inline] do_pte_missing mm/memory.c:3965 [inline] handle_pte_fault+0x2d1c/0x6800 mm/memory.c:5751 __handle_mm_fault mm/memory.c:5894 [inline] handle_mm_fault+0x1053/0x1ad0 mm/memory.c:6062 do_user_addr_fault arch/x86/mm/fault.c:1389 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x2b9/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 rep_movs_alternative+0x30/0x70 arch/x86/lib/copy_user_64.S:50 copy_user_generic arch/x86/include/asm/uaccess_64.h:110 [inline] raw_copy_from_user arch/x86/include/asm/uaccess_64.h:125 [inline] _inline_copy_from_user include/linux/uaccess.h:163 [inline] _copy_from_user+0x8c/0xe0 lib/usercopy.c:18 copy_from_user include/linux/uaccess.h:196 [inline] copy_struct_from_user include/linux/uaccess.h:385 [inline] __do_sys_mount_setattr fs/namespace.c:4829 [inline] __se_sys_mount_setattr+0x2a7/0x1b90 fs/namespace.c:4804 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __might_fault+0xc6/0x120 mm/memory.c:6700 _inline_copy_to_user include/linux/uaccess.h:176 [inline] _copy_to_user+0x2a/0xb0 lib/usercopy.c:26 copy_to_user include/linux/uaccess.h:209 [inline] ni_fiemap+0x5b4/0x1910 fs/ntfs3/frecord.c:2140 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1278 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x1bf8/0x2e40 fs/ioctl.c:841 __do_sys_ioctl fs/ioctl.c:905 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] ntfs_read_folio+0xc0/0x210 fs/ntfs3/inode.c:718 filemap_read_folio+0x14b/0x630 mm/filemap.c:2363 filemap_create_folio mm/filemap.c:2494 [inline] filemap_get_pages+0x100a/0x2540 mm/filemap.c:2552 filemap_read+0x454/0xf90 mm/filemap.c:2641 __kernel_read+0x513/0x9d0 fs/read_write.c:527 integrity_kernel_read+0xb0/0x100 security/integrity/iint.c:28 ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline] ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline] ima_calc_file_hash+0xae6/0x1b30 security/integrity/ima/ima_crypto.c:568 ima_collect_measurement+0x520/0xb10 security/integrity/ima/ima_api.c:293 process_measurement+0x1351/0x1fb0 security/integrity/ima/ima_main.c:372 ima_file_check+0xf2/0x170 security/integrity/ima/ima_main.c:572 security_file_post_open+0xb9/0x280 security/security.c:3127 do_open fs/namei.c:3776 [inline] path_openat+0x2ccd/0x3590 fs/namei.c:3933 do_filp_open+0x235/0x490 fs/namei.c:3960 do_sys_openat2+0x13e/0x1d0 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#9 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(mapping.invalidate_lock#9); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#9); lock(&ni->ni_lock/4); *** DEADLOCK *** 2 locks held by syz.1.421/8886: #0: ffff888068a8e8e8 (&ima_iint_mutex_key[depth]){+.+.}-{3:3}, at: process_measurement+0x7a6/0x1fb0 security/integrity/ima/ima_main.c:269 #1: ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_invalidate_lock_shared include/linux/fs.h:870 [inline] #1: ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_create_folio mm/filemap.c:2485 [inline] #1: ffff88805c5a6c08 (mapping.invalidate_lock#9){.+.+}-{3:3}, at: filemap_get_pages+0xd3e/0x2540 mm/filemap.c:2552 stack backtrace: CPU: 1 UID: 0 PID: 8886 Comm: syz.1.421 Not tainted 6.11.0-syzkaller-08068-g1ec6d097897a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:93 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2203 check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1109 [inline] ntfs_read_folio+0xc0/0x210 fs/ntfs3/inode.c:718 filemap_read_folio+0x14b/0x630 mm/filemap.c:2363 filemap_create_folio mm/filemap.c:2494 [inline] filemap_get_pages+0x100a/0x2540 mm/filemap.c:2552 filemap_read+0x454/0xf90 mm/filemap.c:2641 __kernel_read+0x513/0x9d0 fs/read_write.c:527 integrity_kernel_read+0xb0/0x100 security/integrity/iint.c:28 ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline] ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline] ima_calc_file_hash+0xae6/0x1b30 security/integrity/ima/ima_crypto.c:568 ima_collect_measurement+0x520/0xb10 security/integrity/ima/ima_api.c:293 process_measurement+0x1351/0x1fb0 security/integrity/ima/ima_main.c:372 ima_file_check+0xf2/0x170 security/integrity/ima/ima_main.c:572 security_file_post_open+0xb9/0x280 security/security.c:3127 do_open fs/namei.c:3776 [inline] path_openat+0x2ccd/0x3590 fs/namei.c:3933 do_filp_open+0x235/0x490 fs/namei.c:3960 do_sys_openat2+0x13e/0x1d0 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fdffef7def9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fdfffcb5038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 00007fdfff135f80 RCX: 00007fdffef7def9 RDX: 0000000000000042 RSI: 00000000200002c0 RDI: ffffffffffffff9c RBP: 00007fdffeff0b76 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fdfff135f80 R15: 00007fffe91e6d78