audit: type=1804 audit(1677538083.100:17): pid=10325 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir2738225780/syzkaller.Yv5rUO/33/bus" dev="sda1" ino=14044 res=1
EXT4-fs (loop3): no journal found
EXT4-fs (loop1): no journal found
======================================================
audit: type=1800 audit(1677538083.100:18): pid=10325 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="sda1" ino=14044 res=0
WARNING: possible circular locking dependency detected
4.14.307-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/10313 is trying to acquire lock:
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818b2877>] iterate_dir+0x387/0x5e0 fs/readdir.c:43

but task is already holding lock:
 (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] sb_start_write include/linux/fs.h:1551 [inline]
 (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (sb_writers#6){.+.+}:
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214
       ovl_posix_acl_xattr_set+0x2b7/0x830 fs/overlayfs/super.c:762
       __vfs_setxattr+0xdc/0x130 fs/xattr.c:150
       __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
       __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
       vfs_setxattr+0xcf/0x230 fs/xattr.c:256
       setxattr+0x1a9/0x300 fs/xattr.c:523
       path_setxattr+0x118/0x130 fs/xattr.c:542
       SYSC_lsetxattr fs/xattr.c:564 [inline]
       SyS_lsetxattr+0x33/0x40 fs/xattr.c:560
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (&ovl_i_mutex_dir_key[depth]){++++}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68
       iterate_dir+0x387/0x5e0 fs/readdir.c:43
       ovl_dir_read fs/overlayfs/readdir.c:306 [inline]
       ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365
       ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870
       ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306
       ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_writers#6);
                               lock(&ovl_i_mutex_dir_key[depth]);
                               lock(sb_writers#6);
  lock(&ovl_i_mutex_dir_key[depth]);

 *** DEADLOCK ***

6 locks held by syz-executor.0/10313:
 #0:  (sb_writers#14){.+.+}, at: [<ffffffff818e203a>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#14){.+.+}, at: [<ffffffff818e203a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&type->s_vfs_rename_key#3){+.+.}, at: [<ffffffff81893544>] lock_rename+0x54/0x280 fs/namei.c:2889
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893622>] inode_lock_nested include/linux/fs.h:754 [inline]
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893622>] lock_rename+0x132/0x280 fs/namei.c:2900
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893656>] inode_lock_nested include/linux/fs.h:754 [inline]
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893656>] lock_rename+0x166/0x280 fs/namei.c:2901
 #4:  (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818a71a8>] inode_lock include/linux/fs.h:719 [inline]
 #4:  (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff818a71a8>] vfs_rename+0xbd8/0x1820 fs/namei.c:4472
 #5:  (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] sb_start_write include/linux/fs.h:1551 [inline]
 #5:  (sb_writers#6){.+.+}, at: [<ffffffff818e203a>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

stack backtrace:
CPU: 1 PID: 10313 Comm: syz-executor.0 Not tainted 4.14.307-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68
 iterate_dir+0x387/0x5e0 fs/readdir.c:43
 ovl_dir_read fs/overlayfs/readdir.c:306 [inline]
 ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365
 ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870
 ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306
 ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959
 vfs_rename+0x560/0x1820 fs/namei.c:4498
 SYSC_renameat2 fs/namei.c:4646 [inline]
 SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7fb8f8ac90f9
RSP: 002b:00007fb8f703b168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007fb8f8be8f80 RCX: 00007fb8f8ac90f9
RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000100
RBP: 00007fb8f8b24ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff217358ff R14: 00007fb8f703b300 R15: 0000000000022000
print_req_error: I/O error, dev loop3, sector 0
Buffer I/O error on dev loop3, logical block 0, async page read
print_req_error: I/O error, dev loop3, sector 6
Buffer I/O error on dev loop3, logical block 3, async page read
EXT4-fs error (device loop2): ext4_get_journal_inode:4634: comm syz-executor.2: inode #16777216: comm syz-executor.2: iget: illegal inode #
EXT4-fs error (device loop1): ext4_get_journal_inode:4634: comm syz-executor.1: inode #16777216: comm syz-executor.1: iget: illegal inode #
EXT4-fs (loop1): no journal found
EXT4-fs (loop2): no journal found
audit: type=1804 audit(1677538084.080:19): pid=10359 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir3952881030/syzkaller.2h2pMa/28/bus" dev="sda1" ino=14049 res=1
audit: type=1800 audit(1677538084.080:20): pid=10359 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="sda1" ino=14049 res=0
EXT4-fs error (device loop2): ext4_get_journal_inode:4634: comm syz-executor.2: inode #16777216: comm syz-executor.2: iget: illegal inode #
EXT4-fs error (device loop1): ext4_get_journal_inode:4634: comm syz-executor.1: inode #16777216: comm syz-executor.1: iget: illegal inode #
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
EXT4-fs error (device loop3): ext4_get_journal_inode:4634: comm syz-executor.3: inode #16777216: comm syz-executor.3: iget: illegal inode #
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
EXT4-fs (loop2): no journal found
EXT4-fs (loop3): no journal found
EXT4-fs (loop1): no journal found
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
EXT4-fs error (device loop5): ext4_get_journal_inode:4634: comm syz-executor.5: inode #16777216: comm syz-executor.5: iget: illegal inode #
unregister_netdevice: waiting for ip6gre0 to become free. Usage count = -1
EXT4-fs (loop5): no journal found
EXT4-fs error (device loop0): ext4_get_journal_inode:4634: comm syz-executor.0: inode #16777216: comm syz-executor.0: iget: illegal inode #
EXT4-fs error (device loop3): ext4_get_journal_inode:4634: comm syz-executor.3: inode #16777216: comm syz-executor.3: iget: illegal inode #
EXT4-fs (loop0): no journal found
EXT4-fs (loop3): no journal found
EXT4-fs error (device loop2): ext4_get_journal_inode:4634: comm syz-executor.2: inode #16777216: comm syz-executor.2: iget: illegal inode #
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
EXT4-fs (loop2): no journal found
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
EXT4-fs error (device loop5): ext4_get_journal_inode:4634: comm syz-executor.5: inode #16777216: comm syz-executor.5: iget: illegal inode #
EXT4-fs (loop5): no journal found
EXT4-fs error (device loop0): ext4_get_journal_inode:4634: comm syz-executor.0: inode #16777216: comm syz-executor.0: iget: illegal inode #
EXT4-fs (loop0): no journal found
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
EXT4-fs error (device loop5): ext4_get_journal_inode:4634: comm syz-executor.5: inode #16777216: comm syz-executor.5: iget: illegal inode #
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
EXT4-fs error (device loop0): ext4_get_journal_inode:4634: comm syz-executor.0: inode #16777216: comm syz-executor.0: iget: illegal inode #
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
EXT4-fs (loop5): no journal found
EXT4-fs (loop0): no journal found
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
nla_parse: 4 callbacks suppressed
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'.
EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'.
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'.
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.5'.
REISERFS (device loop4): checking transaction log (loop4)
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
REISERFS (device loop3): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop3): using ordered data mode
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
reiserfs: using flush barriers
REISERFS (device loop3): journal params: device loop3, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop3): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop3): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop3): journal params: device loop3, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop3): using ordered data mode
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
reiserfs: using flush barriers
REISERFS (device loop3): journal params: device loop3, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop2): using ordered data mode
REISERFS (device loop0): Using r5 hash to sort names
reiserfs: using flush barriers
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop2): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop2): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop0): checking transaction log (loop0)
EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue
REISERFS (device loop4): using ordered data mode
REISERFS (device loop0): checking transaction log (loop0)
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop2): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop2): using ordered data mode
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): checking transaction log (loop4)
reiserfs: using flush barriers
REISERFS (device loop2): journal params: device loop2, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.