ip_tables: iptables: counters copy to user failed while replacing table
======================================================
WARNING: possible circular locking dependency detected
4.14.227-syzkaller #0 Not tainted
------------------------------------------------------
kworker/0:0/3 is trying to acquire lock:
 (&sb->s_type->i_mutex_key#10){++++}, at: [<ffffffff818f314e>] inode_lock include/linux/fs.h:719 [inline]
 (&sb->s_type->i_mutex_key#10){++++}, at: [<ffffffff818f314e>] __generic_file_fsync+0x9e/0x190 fs/libfs.c:989

but task is already holding lock:
 ((&dio->complete_work)){+.+.}, at: [<ffffffff81363846>] process_one_work+0x6e6/0x14a0 kernel/workqueue.c:2091

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 ((&dio->complete_work)){+.+.}:
       process_one_work+0x736/0x14a0 kernel/workqueue.c:2092
       worker_thread+0x5cc/0xff0 kernel/workqueue.c:2250
       kthread+0x30d/0x420 kernel/kthread.c:232
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404

-> #1 ("dio/%s"sb->s_id){+.+.}:
       flush_workqueue+0xfa/0x1310 kernel/workqueue.c:2624
       drain_workqueue+0x177/0x3e0 kernel/workqueue.c:2789
IPVS: ftp: loaded support on port[0] = 21
       destroy_workqueue+0x71/0x710 kernel/workqueue.c:4109
       __alloc_workqueue_key+0xd50/0x1080 kernel/workqueue.c:4086
       sb_init_dio_done_wq+0x34/0x80 fs/direct-io.c:624
       do_blockdev_direct_IO fs/direct-io.c:1286 [inline]
       __blockdev_direct_IO+0x3dea/0xdc60 fs/direct-io.c:1422
       ext4_direct_IO_write fs/ext4/inode.c:3724 [inline]
       ext4_direct_IO+0x888/0x1b80 fs/ext4/inode.c:3865
       generic_file_direct_write+0x1df/0x420 mm/filemap.c:2958
       __generic_file_write_iter+0x2a2/0x590 mm/filemap.c:3137
       ext4_file_write_iter+0x7c5/0xd20 fs/ext4/file.c:270
       call_write_iter include/linux/fs.h:1778 [inline]
       aio_write+0x2ed/0x560 fs/aio.c:1553
       io_submit_one fs/aio.c:1641 [inline]
       do_io_submit+0x847/0x1570 fs/aio.c:1709
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&sb->s_type->i_mutex_key#10){++++}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       down_write+0x34/0x90 kernel/locking/rwsem.c:54
       inode_lock include/linux/fs.h:719 [inline]
       __generic_file_fsync+0x9e/0x190 fs/libfs.c:989
       ext4_sync_file+0x8ed/0x12c0 fs/ext4/fsync.c:118
       vfs_fsync_range+0x103/0x260 fs/sync.c:196
       generic_write_sync include/linux/fs.h:2682 [inline]
       dio_complete+0x561/0x8d0 fs/direct-io.c:330
       process_one_work+0x793/0x14a0 kernel/workqueue.c:2116
       worker_thread+0x5cc/0xff0 kernel/workqueue.c:2250
       kthread+0x30d/0x420 kernel/kthread.c:232
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404

other info that might help us debug this:

Chain exists of:
  &sb->s_type->i_mutex_key#10 --> "dio/%s"sb->s_id --> (&dio->complete_work)

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock((&dio->complete_work));
                               lock("dio/%s"sb->s_id);
                               lock((&dio->complete_work));
  lock(&sb->s_type->i_mutex_key#10);

 *** DEADLOCK ***

2 locks held by kworker/0:0/3:
 #0:  ("dio/%s"sb->s_id){+.+.}, at: [<ffffffff81363810>] process_one_work+0x6b0/0x14a0 kernel/workqueue.c:2087
 #1:  ((&dio->complete_work)){+.+.}, at: [<ffffffff81363846>] process_one_work+0x6e6/0x14a0 kernel/workqueue.c:2091

stack backtrace:
CPU: 0 PID: 3 Comm: kworker/0:0 Not tainted 4.14.227-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: dio/sda1 dio_aio_complete_work
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 down_write+0x34/0x90 kernel/locking/rwsem.c:54
 inode_lock include/linux/fs.h:719 [inline]
 __generic_file_fsync+0x9e/0x190 fs/libfs.c:989
 ext4_sync_file+0x8ed/0x12c0 fs/ext4/fsync.c:118
 vfs_fsync_range+0x103/0x260 fs/sync.c:196
 generic_write_sync include/linux/fs.h:2682 [inline]
 dio_complete+0x561/0x8d0 fs/direct-io.c:330
 process_one_work+0x793/0x14a0 kernel/workqueue.c:2116
 worker_thread+0x5cc/0xff0 kernel/workqueue.c:2250
 kthread+0x30d/0x420 kernel/kthread.c:232
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404
IPVS: ftp: loaded support on port[0] = 21
ip_tables: iptables: counters copy to user failed while replacing table
9pnet: Could not find request transport: tcZ�
9pnet: Could not find request transport: tcZ�
F2FS-fs (loop0): Invalid Fs Meta Ino: node(0) meta(0) root(0)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop0): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock
F2FS-fs (loop0): Invalid Fs Meta Ino: node(0) meta(0) root(0)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop0): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock
overlayfs: unrecognized mount option "low��dir=.:file0�Z>t����Ì?-Q\" or missing value
overlayfs: missing 'lowerdir'
kauditd_printk_skb: 63 callbacks suppressed
audit: type=1800 audit(1616935756.129:9062): pid=27848 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=0 res=0
audit: type=1800 audit(1616935756.159:9063): pid=27842 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=32769 res=0
audit: type=1800 audit(1616935756.169:9064): pid=27842 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=65536 res=0
overlayfs: unrecognized mount option "low��dir=.:file0�Z>t����Ì?-Q\" or missing value
audit: type=1800 audit(1616935756.169:9065): pid=27848 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=98306 res=0
overlayfs: missing 'lowerdir'
audit: type=1800 audit(1616935756.499:9066): pid=27864 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=131072 res=0
audit: type=1800 audit(1616935756.499:9067): pid=27864 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=163843 res=0
overlayfs: unrecognized mount option "low��dir=.:file0�Z>t����Ì?-Q\" or missing value
overlayfs: missing 'lowerdir'
audit: type=1800 audit(1616935756.709:9068): pid=27888 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=196608 res=0
audit: type=1800 audit(1616935756.709:9069): pid=27888 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=229380 res=0
overlayfs: unrecognized mount option "low��dir=.:file0�Z>t����Ì?-Q\" or missing value
IPVS: ftp: loaded support on port[0] = 21
overlayfs: missing 'lowerdir'
audit: type=1800 audit(1616935758.149:9070): pid=27908 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=262144 res=0
audit: type=1800 audit(1616935758.189:9071): pid=27908 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed" comm="syz-executor.0" name="SYSV00000000" dev="hugetlbfs" ino=294917 res=0
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
print_req_error: I/O error, dev loop0, sector 0
SQUASHFS error: squashfs_read_data failed to read block 0x0
squashfs: SQUASHFS error: unable to read squashfs_super_block
SQUASHFS error: squashfs_read_data failed to read block 0x0
IPVS: ftp: loaded support on port[0] = 21
squashfs: SQUASHFS error: unable to read squashfs_super_block
SQUASHFS error: squashfs_read_data failed to read block 0x0
squashfs: SQUASHFS error: unable to read squashfs_super_block
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
IPVS: ftp: loaded support on port[0] = 21
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
IPVS: ftp: loaded support on port[0] = 21
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0
IPVS: ftp: loaded support on port[0] = 21
squashfs: SQUASHFS error: Can't find a SQUASHFS superblock on loop0