hfsplus: bad catalog entry type ====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/5824 is trying to acquire lock: ffff88802c1950f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff8880599407c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2a0/0xc10 fs/hfsplus/extents.c:573 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:776 hfsplus_get_block+0x398/0x1600 fs/hfsplus/extents.c:260 block_read_full_folio+0x29f/0x830 fs/buffer.c:2420 filemap_read_folio+0x117/0x380 mm/filemap.c:2496 do_read_cache_folio+0x358/0x590 mm/filemap.c:4096 do_read_cache_page mm/filemap.c:4162 [inline] read_cache_page+0x5d/0x170 mm/filemap.c:4171 read_mapping_page include/linux/pagemap.h:1011 [inline] hfsplus_block_allocate+0xf3/0xd10 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa9a/0x1c30 fs/hfsplus/extents.c:464 hfsplus_get_block+0x40a/0x1600 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145 block_write_begin fs/buffer.c:2256 [inline] cont_write_begin+0x78c/0xb50 fs/buffer.c:2594 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 generic_perform_write+0x2c5/0x900 mm/filemap.c:4314 generic_file_write_iter+0x117/0x550 mm/filemap.c:4457 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x5c9/0xb30 fs/read_write.c:686 ksys_write+0x145/0x250 fs/read_write.c:738 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a6/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0x117/0x340 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:776 hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:360 hfsplus_file_truncate+0x751/0xc10 fs/hfsplus/extents.c:588 hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1 hfsplus_unlink+0x4e3/0x730 fs/hfsplus/dir.c:405 vfs_unlink+0x380/0x640 fs/namei.c:5369 do_unlinkat+0x2cf/0x560 fs/namei.c:5439 __do_sys_unlink fs/namei.c:5474 [inline] __se_sys_unlink fs/namei.c:5472 [inline] __x64_sys_unlink+0x47/0x50 fs/namei.c:5472 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz-executor/5824: #0: ffff88807f23c420 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499 #1: ffff88807b801df8 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline] #1: ffff88807b801df8 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2864 [inline] #1: ffff88807b801df8 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2875 [inline] #1: ffff88807b801df8 (&type->i_mutex_dir_key#9/1){+.+.}-{4:4}, at: do_unlinkat+0x1b2/0x560 fs/namei.c:5420 #2: ffff8880599409b8 (&sb->s_type->i_mutex_key#27){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline] #2: ffff8880599409b8 (&sb->s_type->i_mutex_key#27){+.+.}-{4:4}, at: vfs_unlink+0xef/0x640 fs/namei.c:5355 #3: ffff88802c195198 (&sbi->vh_mutex){+.+.}-{4:4}, at: hfsplus_unlink+0x160/0x730 fs/hfsplus/dir.c:370 #4: ffff8880599407c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x2a0/0xc10 fs/hfsplus/extents.c:573 stack backtrace: CPU: 1 UID: 0 PID: 5824 Comm: syz-executor Not tainted syzkaller #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2043 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a6/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0x117/0x340 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:614 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:776 hfsplus_block_free+0xc7/0x630 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x121/0xa50 fs/hfsplus/extents.c:360 hfsplus_file_truncate+0x751/0xc10 fs/hfsplus/extents.c:588 hfsplus_delete_inode+0x180/0x230 fs/hfsplus/inode.c:-1 hfsplus_unlink+0x4e3/0x730 fs/hfsplus/dir.c:405 vfs_unlink+0x380/0x640 fs/namei.c:5369 do_unlinkat+0x2cf/0x560 fs/namei.c:5439 __do_sys_unlink fs/namei.c:5474 [inline] __se_sys_unlink fs/namei.c:5472 [inline] __x64_sys_unlink+0x47/0x50 fs/namei.c:5472 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f03d6b8ecf7 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffe73855958 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f03d6b8ecf7 RDX: 00007ffe73855980 RSI: 00007ffe73855a10 RDI: 00007ffe73855a10 RBP: 00007ffe73855a10 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffe73856b00 R13: 00007f03d6c13d7d R14: 0000000000019509 R15: 00007ffe73857bd0 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent: start 144, count 1 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent: start 131, count 2 hfsplus: found bad thread record in catalog hfsplus: found bad thread record in catalog