======================================================
WARNING: possible circular locking dependency detected
4.14.306-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/10645 is trying to acquire lock:
 (sb_writers#3){.+.+}, at: [<ffffffff818e1fea>] sb_start_write include/linux/fs.h:1551 [inline]
 (sb_writers#3){.+.+}, at: [<ffffffff818e1fea>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386

but task is already holding lock:
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] inode_lock include/linux/fs.h:719 [inline]
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] do_last fs/namei.c:3331 [inline]
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] path_openat+0xde2/0x2970 fs/namei.c:3571

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ovl_i_mutex_dir_key[depth]){++++}:
       down_write_killable+0x37/0xb0 kernel/locking/rwsem.c:68
       iterate_dir+0x387/0x5e0 fs/readdir.c:43
       ovl_dir_read fs/overlayfs/readdir.c:306 [inline]
       ovl_dir_read_merged+0x2c5/0x430 fs/overlayfs/readdir.c:365
       ovl_check_empty_dir+0x6e/0x200 fs/overlayfs/readdir.c:870
       ovl_check_empty_and_clear+0x72/0xe0 fs/overlayfs/dir.c:306
       ovl_rename+0x57d/0xe50 fs/overlayfs/dir.c:959
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (sb_writers#3){.+.+}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538
       lookup_open+0x77a/0x1750 fs/namei.c:3241
       do_last fs/namei.c:3334 [inline]
       path_openat+0xe08/0x2970 fs/namei.c:3571
       do_filp_open+0x179/0x3c0 fs/namei.c:3605
       do_sys_open+0x296/0x410 fs/open.c:1081
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ovl_i_mutex_dir_key[depth]);
                               lock(sb_writers#3);
                               lock(&ovl_i_mutex_dir_key[depth]);
  lock(sb_writers#3);

 *** DEADLOCK ***

2 locks held by syz-executor.1/10645:
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e1fea>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e1fea>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] inode_lock include/linux/fs.h:719 [inline]
 #1:  (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] do_last fs/namei.c:3331 [inline]
 #1:  (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff818a49f2>] path_openat+0xde2/0x2970 fs/namei.c:3571

stack backtrace:
CPU: 0 PID: 10645 Comm: syz-executor.1 Not tainted 4.14.306-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/16/2023
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
 percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
 __sb_start_write+0x64/0x260 fs/super.c:1342
 sb_start_write include/linux/fs.h:1551 [inline]
 mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538
 lookup_open+0x77a/0x1750 fs/namei.c:3241
 do_last fs/namei.c:3334 [inline]
 path_openat+0xe08/0x2970 fs/namei.c:3571
 do_filp_open+0x179/0x3c0 fs/namei.c:3605
 do_sys_open+0x296/0x410 fs/open.c:1081
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7feb0e7340f9
RSP: 002b:00007feb0cca6168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007feb0e853f80 RCX: 00007feb0e7340f9
RDX: 0000000000000000 RSI: 0000000000181042 RDI: 0000000020000000
RBP: 00007feb0e78fae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffca0006e7f R14: 00007feb0cca6300 R15: 0000000000022000
F2FS-fs (loop2): Mismatch start address, segment0(512) cp_blkaddr(605)
F2FS-fs (loop2): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop2): invalid crc value
F2FS-fs (loop2): Found nat_bits in checkpoint
F2FS-fs (loop2): Mounted with checkpoint version = 753bd00b
audit: type=1800 audit(1677235542.490:2): pid=10648 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="loop2" ino=4 res=0
audit: type=1800 audit(1677235542.500:3): pid=10648 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="bus" dev="loop2" ino=4 res=0
F2FS-fs (loop2): Mismatch start address, segment0(512) cp_blkaddr(605)
F2FS-fs (loop2): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop2): invalid crc value
F2FS-fs (loop2): Found nat_bits in checkpoint
F2FS-fs (loop2): Mounted with checkpoint version = 753bd00b
audit: type=1800 audit(1677235543.960:4): pid=10738 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="loop2" ino=4 res=0
audit: type=1800 audit(1677235543.970:5): pid=10738 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="bus" dev="loop2" ino=4 res=0
audit: type=1800 audit(1677235545.471:6): pid=10803 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="file0" dev="loop4" ino=4 res=0
audit: type=1800 audit(1677235545.491:7): pid=10803 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="loop4" ino=4 res=0
audit: type=1800 audit(1677235545.731:8): pid=10818 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="loop0" ino=4 res=0
audit: type=1800 audit(1677235545.741:9): pid=10818 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="bus" dev="loop0" ino=4 res=0
audit: type=1800 audit(1677235545.971:10): pid=10820 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="file0" dev="loop1" ino=4 res=0
audit: type=1800 audit(1677235545.991:11): pid=10820 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="loop1" ino=4 res=0
f2fs_msg: 25 callbacks suppressed
F2FS-fs (loop0): Mismatch start address, segment0(512) cp_blkaddr(605)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop0): invalid crc value
F2FS-fs (loop4): Mismatch start address, segment0(512) cp_blkaddr(605)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop4): invalid crc value
F2FS-fs (loop0): Found nat_bits in checkpoint
F2FS-fs (loop4): Found nat_bits in checkpoint
F2FS-fs (loop0): Mounted with checkpoint version = 753bd00b
kauditd_printk_skb: 4 callbacks suppressed
audit: type=1800 audit(1677235547.651:16): pid=10890 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="file0" dev="loop0" ino=4 res=0
audit: type=1800 audit(1677235547.661:17): pid=10890 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="bus" dev="loop0" ino=4 res=0
F2FS-fs (loop4): Mounted with checkpoint version = 753bd00b
audit: type=1800 audit(1677235547.911:18): pid=10884 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="file0" dev="loop4" ino=4 res=0
audit: type=1800 audit(1677235547.941:19): pid=10884 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="loop4" ino=4 res=0
audit: type=1800 audit(1677235548.121:20): pid=10906 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="file0" dev="loop5" ino=4 res=0
audit: type=1800 audit(1677235548.161:21): pid=10906 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=4 res=0
audit: type=1800 audit(1677235548.281:22): pid=10898 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="file0" dev="loop1" ino=4 res=0
audit: type=1800 audit(1677235548.301:23): pid=10898 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="loop1" ino=4 res=0
audit: type=1800 audit(1677235548.711:24): pid=10919 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="file0" dev="loop2" ino=4 res=0
audit: type=1800 audit(1677235548.731:25): pid=10919 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="bus" dev="loop2" ino=4 res=0