====================================================== WARNING: possible circular locking dependency detected 6.1.139-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.6639/27169 is trying to acquire lock: ffff888066e72650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848 but task is already holding lock: ffff8880558acda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833 quota_setquota+0x4ac/0x530 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}: down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833 quota_setquota+0x4ac/0x530 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747 dquot_commit+0x5a/0x410 fs/quota/dquot.c:507 ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6778 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0x5fc/0xe60 fs/quota/dquot.c:1752 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0xf74/0x4720 fs/ext4/mballoc.c:5727 ext4_new_meta_blocks+0x151/0x3a0 fs/ext4/balloc.c:739 ext4_xattr_block_set+0x1d46/0x32a0 fs/ext4/xattr.c:2076 ext4_xattr_move_to_block fs/ext4/xattr.c:2625 [inline] ext4_xattr_make_inode_space fs/ext4/xattr.c:2700 [inline] ext4_expand_extra_isize_ea+0x109b/0x19b0 fs/ext4/xattr.c:2792 __ext4_expand_extra_isize+0x301/0x3e0 fs/ext4/inode.c:5965 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6008 [inline] __ext4_mark_inode_dirty+0x47f/0x770 fs/ext4/inode.c:6086 ext4_setattr+0x1457/0x19f0 fs/ext4/inode.c:5596 notify_change+0xc74/0xf40 fs/attr.c:499 do_truncate+0x197/0x220 fs/open.c:65 handle_truncate fs/namei.c:3285 [inline] do_open fs/namei.c:3630 [inline] path_openat+0x27f2/0x2e70 fs/namei.c:3783 do_filp_open+0x1c1/0x3c0 fs/namei.c:3810 do_sys_openat2+0x142/0x490 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x135/0x160 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (&ei->i_data_sem){++++}-{3:3}: down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_truncate+0x987/0x1230 fs/ext4/inode.c:4284 ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5630 notify_change+0xc74/0xf40 fs/attr.c:499 do_truncate+0x197/0x220 fs/open.c:65 do_sys_ftruncate+0x312/0x3c0 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376 ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fc/0x930 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x340 fs/super.c:501 kill_block_super+0x7c/0xe0 fs/super.c:1470 deactivate_locked_super+0x93/0xf0 fs/super.c:332 cleanup_mnt+0x463/0x4f0 fs/namespace.c:1186 task_work_run+0x1ca/0x250 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:303 do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374 ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fc/0x930 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x340 fs/super.c:501 kill_block_super+0x7c/0xe0 fs/super.c:1470 deactivate_locked_super+0x93/0xf0 fs/super.c:332 cleanup_mnt+0x463/0x4f0 fs/namespace.c:1186 task_work_run+0x1ca/0x250 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xe6/0x110 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:303 do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (sb_internal#2){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372 ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833 quota_setquota+0x4ac/0x530 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#2); *** DEADLOCK *** 4 locks held by syz.1.6639/27169: #0: ffff888066e720e0 (&type->s_umount_key#123){++++}-{3:3}, at: user_get_super+0x118/0x240 fs/super.c:889 #1: ffff88807aed80a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x293/0xb10 fs/ocfs2/quota_global.c:811 #2: ffff8880558ad108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff8880558ad108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313 #3: ffff8880558acda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 PID: 27169 Comm: syz.1.6639 Not tainted 6.1.139-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372 ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848 dqget+0x778/0xeb0 fs/quota/dquot.c:988 dquot_set_dqblk+0x27/0xf90 fs/quota/dquot.c:2833 quota_setquota+0x4ac/0x530 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x295/0x6b0 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fb77e98e969 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb77f727038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007fb77ebb5fa0 RCX: 00007fb77e98e969 RDX: 0000000000000000 RSI: 0000200000000040 RDI: ffffffff80000800 RBP: 00007fb77ea10ab1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000200000000100 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fb77ebb5fa0 R15: 00007ffebae699c8