KCSAN: data-race in inotify_handle_event / inotify_remove_from_idr

Status: closed as invalid on 2020/06/18 14:24
Subsystems: fs
[Documentation on labels]
First crash: 2432d, last: 2250d
▶ ▼ Similar bugs (1)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KCSAN: data-race in inotify_handle_event / inotify_remove_from_idr (2) fs 6 8 2213d 2238d 0/29 auto-closed as invalid on 2020/08/19 22:14

Sample crash report:
==================================================================
BUG: KCSAN: data-race in inotify_handle_event / inotify_remove_from_idr

write to 0xffff88812b7f3098 of 4 bytes by task 15314 on cpu 0:
 inotify_remove_from_idr+0xf8/0x310 fs/notify/inotify/inotify_user.c:473
 inotify_ignored_and_remove_idr+0x98/0xe0 fs/notify/inotify/inotify_user.c:498
 inotify_freeing_mark+0x23/0x30 fs/notify/inotify/inotify_fsnotify.c:141
 fsnotify_free_mark+0x9f/0xe0 fs/notify/mark.c:423
 fsnotify_destroy_mark+0x3c/0x50 fs/notify/mark.c:432
 __do_sys_inotify_rm_watch fs/notify/inotify/inotify_user.c:787 [inline]
 __se_sys_inotify_rm_watch fs/notify/inotify/inotify_user.c:762 [inline]
 __x64_sys_inotify_rm_watch+0xc4/0x120 fs/notify/inotify/inotify_user.c:762
 do_syscall_64+0xc7/0x3b0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

read to 0xffff88812b7f3098 of 4 bytes by task 11768 on cpu 1:
 inotify_handle_event+0x239/0x3f4 fs/notify/inotify/inotify_fsnotify.c:121
 send_to_group fs/notify/fsnotify.c:227 [inline]
 fsnotify+0x575/0x830 fs/notify/fsnotify.c:366
 fsnotify_file include/linux/fsnotify.h:78 [inline]
 fsnotify_close include/linux/fsnotify.h:281 [inline]
 __fput+0x356/0x500 fs/file_table.c:266
 ____fput+0x1b/0x30 fs/file_table.c:313
 task_work_run+0xba/0x120 kernel/task_work.c:123
 tracehook_notify_resume include/linux/tracehook.h:188 [inline]
 exit_to_usermode_loop+0x2ae/0x2c0 arch/x86/entry/common.c:165
 prepare_exit_to_usermode arch/x86/entry/common.c:196 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:279 [inline]
 do_syscall_64+0x38b/0x3b0 arch/x86/entry/common.c:305
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 11768 Comm: syz-executor.1 Not tainted 5.7.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
==================================================================

Crashes (18):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/06/09 07:49 https://github.com/google/ktsan.git kcsan 7c3cd68e5d38 0d60b78a .config console log report ci2-upstream-kcsan-gce
2020/06/07 04:44 https://github.com/google/ktsan.git kcsan 7c3cd68e5d38 e6b89e4e .config console log report ci2-upstream-kcsan-gce
2020/06/01 07:27 https://github.com/google/ktsan.git kcsan 7c3cd68e5d38 a0331e89 .config console log report ci2-upstream-kcsan-gce
2020/05/09 07:30 https://github.com/google/ktsan.git kcsan 7c3cd68e5d38 e97b06d3 .config console log report ci2-upstream-kcsan-gce
2020/04/17 16:57 https://github.com/google/ktsan.git kcsan 7c3cd68e5d38 18397578 .config console log report ci2-upstream-kcsan-gce
2020/03/25 22:24 https://github.com/google/ktsan.git kcsan 40959e34d670 e8e6c7d2 .config console log report ci2-upstream-kcsan-gce
2020/03/13 11:34 https://github.com/google/ktsan.git kcsan 941e0d917bbf fd69032d .config console log report ci2-upstream-kcsan-gce
2020/03/08 02:43 https://github.com/google/ktsan.git kcsan 941e0d917bbf 2e9971bb .config console log report ci2-upstream-kcsan-gce
2020/02/19 16:44 https://github.com/google/ktsan.git kcsan b12d66a6c34f 47fae6e9 .config console log report ci2-upstream-kcsan-gce
2020/02/07 15:28 https://github.com/google/ktsan.git kcsan 6cccb8ba35bd 06150bf1 .config console log report ci2-upstream-kcsan-gce
2020/01/31 17:55 https://github.com/google/ktsan.git kcsan 245a43005292 5ed23f9a .config console log report ci2-upstream-kcsan-gce
2020/01/28 02:33 https://github.com/google/ktsan.git kcsan 245a43005292 56cd6c9b .config console log report ci2-upstream-kcsan-gce
2020/01/26 11:41 https://github.com/google/ktsan.git kcsan 245a43005292 f4e7270e .config console log report ci2-upstream-kcsan-gce
2020/01/22 04:12 https://github.com/google/ktsan.git kcsan 245a43005292 8eda0b95 .config console log report ci2-upstream-kcsan-gce
2020/01/18 14:17 https://github.com/google/ktsan.git kcsan 245a43005292 3de7aabb .config console log report ci2-upstream-kcsan-gce
2020/01/13 01:07 https://github.com/google/ktsan.git kcsan 245a43005292 53faa9fe .config console log report ci2-upstream-kcsan-gce
2019/12/26 20:54 https://github.com/google/ktsan.git kcsan 245a43005292 be5c2c81 .config console log report ci2-upstream-kcsan-gce
2019/12/10 02:36 https://github.com/google/ktsan.git kcsan ef798c30ba4e b31eda3d .config console log report ci2-upstream-kcsan-gce
* Struck through repros no longer work on HEAD.