syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.168-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.1652/9585 is trying to acquire lock:
ffff888064dcc120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_mark_rec_free+0x33/0x250 fs/ntfs3/fsntfs.c:711

but task is already holding lock:
ffff88806fefd220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline]
ffff88806fefd220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3198

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ni->ni_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:925
       ni_find_attr+0x6cf/0x8b0 fs/ntfs3/frecord.c:238
       attr_load_runs_vcn+0xd1/0x360 fs/ntfs3/attrib.c:1157
       mi_read+0x342/0x5a0 fs/ntfs3/record.c:151
       ntfs_read_mft fs/ntfs3/inode.c:69 [inline]
       ntfs_iget5+0x472/0x38e0 fs/ntfs3/inode.c:525
       ntfs_export_get_inode+0xd8/0x190 fs/ntfs3/super.c:618
       generic_fh_to_dentry+0x94/0xe0 fs/libfs.c:1044
       exportfs_decode_fh_raw+0x140/0x590 fs/exportfs/expfs.c:436
       exportfs_decode_fh+0x38/0x70 fs/exportfs/expfs.c:576
       do_handle_to_path fs/fhandle.c:152 [inline]
       handle_to_path fs/fhandle.c:207 [inline]
       do_handle_open+0x44c/0x960 fs/fhandle.c:223
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ni->file.run_lock#2){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       mi_read+0x17d/0x5a0 fs/ntfs3/record.c:129
       mi_format_new+0x1a7/0x5c0 fs/ntfs3/record.c:374
       ni_add_subrecord+0xde/0x430 fs/ntfs3/frecord.c:370
       ntfs_look_free_mft+0x7f1/0xff0 fs/ntfs3/fsntfs.c:686
       ni_create_attr_list+0x9b6/0x1470 fs/ntfs3/frecord.c:848
       ni_ins_attr_ext+0x364/0xb30 fs/ntfs3/frecord.c:949
       ni_insert_attr fs/ntfs3/frecord.c:1103 [inline]
       ni_insert_resident fs/ntfs3/frecord.c:1477 [inline]
       ni_add_name+0x689/0x9d0 fs/ntfs3/frecord.c:2983
       ni_rename+0xbe/0x1e0 fs/ntfs3/frecord.c:3023
       ntfs_rename+0x74a/0xd40 fs/ntfs3/namei.c:318
       vfs_rename+0xd32/0x10f0 fs/namei.c:4832
       do_renameat2+0xe0f/0x1700 fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&wnd->rw_lock/1){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
       ntfs_mark_rec_free+0x33/0x250 fs/ntfs3/fsntfs.c:711
       ni_write_inode+0x504/0x1070 fs/ntfs3/frecord.c:3293
       write_inode fs/fs-writeback.c:1495 [inline]
       __writeback_single_inode+0x644/0xe30 fs/fs-writeback.c:1705
       writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1760
       sync_inode_metadata+0xba/0x110 fs/fs-writeback.c:2820
       __generic_file_fsync+0x13b/0x190 fs/libfs.c:1115
       generic_file_fsync+0x6f/0xe0 fs/libfs.c:1145
       generic_write_sync include/linux/fs.h:2991 [inline]
       ntfs_file_write_iter+0x453/0x540 fs/ntfs3/file.c:1149
       do_iter_readv_writev+0x594/0x7a0
       do_iter_write+0x1e6/0x760 fs/read_write.c:855
       vfs_writev fs/read_write.c:928 [inline]
       do_pwritev+0x219/0x360 fs/read_write.c:1025
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ni->ni_lock);
                               lock(&ni->file.run_lock#2);
                               lock(&ni->ni_lock);
  lock(&wnd->rw_lock/1);

 *** DEADLOCK ***

3 locks held by syz.0.1652/9585:
 #0: ffff888064dca460 (sb_writers#22){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:927 [inline]
 #0: ffff888064dca460 (sb_writers#22){.+.+}-{0:0}, at: do_pwritev+0x1fd/0x360 fs/read_write.c:1025
 #1: ffff88806fefd4c0 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff88806fefd4c0 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: __generic_file_fsync+0x96/0x190 fs/libfs.c:1108
 #2: ffff88806fefd220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline]
 #2: ffff88806fefd220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3198

stack backtrace:
CPU: 0 PID: 9585 Comm: syz.0.1652 Not tainted 5.15.168-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
 ntfs_mark_rec_free+0x33/0x250 fs/ntfs3/fsntfs.c:711
 ni_write_inode+0x504/0x1070 fs/ntfs3/frecord.c:3293
 write_inode fs/fs-writeback.c:1495 [inline]
 __writeback_single_inode+0x644/0xe30 fs/fs-writeback.c:1705
 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1760
 sync_inode_metadata+0xba/0x110 fs/fs-writeback.c:2820
 __generic_file_fsync+0x13b/0x190 fs/libfs.c:1115
 generic_file_fsync+0x6f/0xe0 fs/libfs.c:1145
 generic_write_sync include/linux/fs.h:2991 [inline]
 ntfs_file_write_iter+0x453/0x540 fs/ntfs3/file.c:1149
 do_iter_readv_writev+0x594/0x7a0
 do_iter_write+0x1e6/0x760 fs/read_write.c:855
 vfs_writev fs/read_write.c:928 [inline]
 do_pwritev+0x219/0x360 fs/read_write.c:1025
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7ff2feb90ff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff2fd009038 EFLAGS: 00000246 ORIG_RAX: 0000000000000128
RAX: ffffffffffffffda RBX: 00007ff2fed48f80 RCX: 00007ff2feb90ff9
RDX: 0000000000000001 RSI: 0000000020000100 RDI: 0000000000000004
RBP: 00007ff2fec03296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000009 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007ff2fed48f80 R15: 00007ffe651c7028
 </TASK>