syzbot

loop8: detected capacity change from 0 to 512
EXT4-fs (loop8): encrypted files will use data=ordered instead of data journaling mode
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc7-syzkaller-00019-gc45323b7560e #0 Not tainted
------------------------------------------------------
syz.8.6167/24686 is trying to acquire lock:
ffff88803417e598 (&ei->i_data_sem/2){++++}-{4:4}, at: ext4_inline_data_truncate+0x4ce/0xc70 fs/ext4/inline.c:1950

but task is already holding lock:
ffff88803417e3d8 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline]
ffff88803417e3d8 (&ei->xattr_sem){++++}-{4:4}, at: ext4_inline_data_truncate+0x1af/0xc70 fs/ext4/inline.c:1936

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #9 (&ei->xattr_sem){++++}-{4:4}:
       down_write+0x93/0x200 kernel/locking/rwsem.c:1577
       ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline]
       ext4_inline_data_truncate+0x1af/0xc70 fs/ext4/inline.c:1936
       ext4_truncate+0x9ab/0x1270 fs/ext4/inode.c:4173
       ext4_setattr+0x1c64/0x2a70 fs/ext4/inode.c:5541
       notify_change+0x6a9/0x1230 fs/attr.c:552
       do_truncate+0x15c/0x220 fs/open.c:65
       handle_truncate fs/namei.c:3449 [inline]
       do_open fs/namei.c:3832 [inline]
       path_openat+0x2745/0x2d60 fs/namei.c:3987
       do_filp_open+0x20c/0x470 fs/namei.c:4014
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1402
       do_sys_open fs/open.c:1417 [inline]
       __do_sys_creat fs/open.c:1495 [inline]
       __se_sys_creat fs/open.c:1489 [inline]
       __x64_sys_creat+0xcd/0x120 fs/open.c:1489
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #8 (mapping.invalidate_lock){++++}-{4:4}:
       down_read+0x9a/0x330 kernel/locking/rwsem.c:1524
       filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
       filemap_fault+0x2e0/0x2820 mm/filemap.c:3323
       __do_fault+0x10d/0x490 mm/memory.c:4907
       do_cow_fault mm/memory.c:5352 [inline]
       do_fault mm/memory.c:5458 [inline]
       do_pte_missing+0x99f/0x3e00 mm/memory.c:3979
       handle_pte_fault mm/memory.c:5801 [inline]
       __handle_mm_fault+0x103c/0x2a40 mm/memory.c:5944
       handle_mm_fault+0x3fa/0xaa0 mm/memory.c:6112
       do_user_addr_fault+0x60d/0x13f0 arch/x86/mm/fault.c:1338
       handle_page_fault arch/x86/mm/fault.c:1481 [inline]
       exc_page_fault+0x5c/0xc0 arch/x86/mm/fault.c:1539
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #7 (&vma->vm_lock->lock){++++}-{4:4}:
       down_write+0x93/0x200 kernel/locking/rwsem.c:1577
       vma_start_write include/linux/mm.h:770 [inline]
       vma_link+0x26d/0x4a0 mm/vma.c:1691
       insert_vm_struct+0x197/0x3f0 mm/mmap.c:1744
       __bprm_mm_init fs/exec.c:289 [inline]
       bprm_mm_init fs/exec.c:393 [inline]
       alloc_bprm+0x6e0/0xc90 fs/exec.c:1544
       kernel_execve+0xb0/0x3b0 fs/exec.c:1974
       try_to_run_init_process init/main.c:1394 [inline]
       kernel_init+0x14a/0x2b0 init/main.c:1522
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #6 (&mm->mmap_lock){++++}-{4:4}:
       __might_fault mm/memory.c:6751 [inline]
       __might_fault+0x11b/0x190 mm/memory.c:6744
       _inline_copy_from_user include/linux/uaccess.h:162 [inline]
       _copy_from_user+0x29/0xd0 lib/usercopy.c:18
       copy_from_user include/linux/uaccess.h:212 [inline]
       __blk_trace_setup+0xa8/0x180 kernel/trace/blktrace.c:626
       blk_trace_ioctl+0x163/0x290 kernel/trace/blktrace.c:740
       blkdev_ioctl+0x109/0x6d0 block/ioctl.c:682
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&q->debugfs_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       blk_mq_init_sched+0x42b/0x640 block/blk-mq-sched.c:473
       elevator_init_mq+0x2cd/0x420 block/elevator.c:610
       add_disk_fwnode+0x113/0x1300 block/genhd.c:413
       sd_probe+0xa86/0x1000 drivers/scsi/sd.c:4024
       call_driver_probe drivers/base/dd.c:579 [inline]
       really_probe+0x241/0xa90 drivers/base/dd.c:658
       __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
       driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
       __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
       bus_for_each_drv+0x15a/0x1e0 drivers/base/bus.c:459
       __device_attach_async_helper+0x1d3/0x290 drivers/base/dd.c:987
       async_run_entry_fn+0x9f/0x530 kernel/async.c:129
       process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3236
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #4 (&q->q_usage_counter(queue)#50){++++}-{0:0}:
       blk_queue_enter+0x50f/0x640 block/blk-core.c:328
       blk_mq_alloc_request+0x59b/0x950 block/blk-mq.c:652
       scsi_alloc_request drivers/scsi/scsi_lib.c:1222 [inline]
       scsi_execute_cmd+0x1eb/0xf40 drivers/scsi/scsi_lib.c:304
       read_capacity_16+0x213/0xe10 drivers/scsi/sd.c:2655
       sd_read_capacity drivers/scsi/sd.c:2824 [inline]
       sd_revalidate_disk.isra.0+0x1a06/0xa8d0 drivers/scsi/sd.c:3734
       sd_probe+0x904/0x1000 drivers/scsi/sd.c:4010
       call_driver_probe drivers/base/dd.c:579 [inline]
       really_probe+0x241/0xa90 drivers/base/dd.c:658
       __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
       driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
       __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
       bus_for_each_drv+0x15a/0x1e0 drivers/base/bus.c:459
       __device_attach_async_helper+0x1d3/0x290 drivers/base/dd.c:987
       async_run_entry_fn+0x9f/0x530 kernel/async.c:129
       process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3236
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #3 (&q->limits_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       queue_limits_start_update include/linux/blkdev.h:947 [inline]
       loop_reconfigure_limits+0x407/0x8c0 drivers/block/loop.c:998
       loop_set_block_size drivers/block/loop.c:1473 [inline]
       lo_simple_ioctl drivers/block/loop.c:1496 [inline]
       lo_ioctl+0x901/0x18b0 drivers/block/loop.c:1559
       blkdev_ioctl+0x279/0x6d0 block/ioctl.c:693
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&q->q_usage_counter(io)#23){++++}-{0:0}:
       bio_queue_enter block/blk.h:75 [inline]
       blk_mq_submit_bio+0x1fb6/0x24c0 block/blk-mq.c:3090
       __submit_bio+0x384/0x540 block/blk-core.c:629
       __submit_bio_noacct_mq block/blk-core.c:710 [inline]
       submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739
       submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868
       __ext4_read_bh fs/ext4/super.c:181 [inline]
       ext4_read_bh_nowait+0x199/0x250 fs/ext4/super.c:193
       ext4_read_block_bitmap_nowait+0xeac/0x1810 fs/ext4/balloc.c:551
       ext4_mb_prefetch+0x292/0x370 fs/ext4/mballoc.c:2749
       ext4_mb_regular_allocator+0x18d8/0x3f90 fs/ext4/mballoc.c:2898
       ext4_mb_new_blocks+0x287f/0x4e30 fs/ext4/mballoc.c:6217
       ext4_ext_map_blocks+0x1b80/0x5aa0 fs/ext4/extents.c:4379
       ext4_map_create_blocks fs/ext4/inode.c:516 [inline]
       ext4_map_blocks+0x457/0x1370 fs/ext4/inode.c:702
       ext4_xattr_inode_write fs/ext4/xattr.c:1400 [inline]
       ext4_xattr_inode_lookup_create fs/ext4/xattr.c:1602 [inline]
       ext4_xattr_inode_lookup_create+0xe6b/0x1aa0 fs/ext4/xattr.c:1574
       ext4_xattr_ibody_set+0x1d9/0x5b0 fs/ext4/xattr.c:2269
       ext4_xattr_set_handle+0x939/0x1420 fs/ext4/xattr.c:2446
       ext4_xattr_set+0x14b/0x360 fs/ext4/xattr.c:2560
       __vfs_setxattr+0x176/0x1e0 fs/xattr.c:200
       __vfs_setxattr_noperm+0x127/0x660 fs/xattr.c:234
       __vfs_setxattr_locked+0x182/0x260 fs/xattr.c:295
       vfs_setxattr+0x146/0x360 fs/xattr.c:321
       do_setxattr+0x142/0x170 fs/xattr.c:636
       filename_setxattr+0x16d/0x1d0 fs/xattr.c:665
       path_setxattrat+0x1e0/0x290 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&lg->lg_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       ext4_mb_group_or_file fs/ext4/mballoc.c:5786 [inline]
       ext4_mb_initialize_context+0x814/0xdf0 fs/ext4/mballoc.c:5830
       ext4_mb_new_blocks+0x963/0x4e30 fs/ext4/mballoc.c:6204
       ext4_ext_map_blocks+0x1b80/0x5aa0 fs/ext4/extents.c:4379
       ext4_map_create_blocks fs/ext4/inode.c:516 [inline]
       ext4_map_blocks+0x457/0x1370 fs/ext4/inode.c:702
       ext4_getblk+0x17f/0x890 fs/ext4/inode.c:849
       ext4_bread+0x2c/0x190 fs/ext4/inode.c:912
       ext4_quota_write+0x219/0x610 fs/ext4/super.c:7285
       write_blk+0x131/0x220 fs/quota/quota_tree.c:70
       do_insert_tree+0xddd/0x1a10 fs/quota/quota_tree.c:407
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       dq_insert_tree fs/quota/quota_tree.c:432 [inline]
       qtree_write_dquot+0x248/0x660 fs/quota/quota_tree.c:451
       v2_write_dquot+0x1b1/0x2a0 fs/quota/quota_v2.c:372
       dquot_acquire+0x3a4/0x6f0 fs/quota/dquot.c:470
       ext4_acquire_dquot+0x27f/0x4e0 fs/ext4/super.c:6934
       dqget+0x694/0x1160 fs/quota/dquot.c:977
       __dquot_initialize+0x588/0xd50 fs/quota/dquot.c:1505
       ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x742/0x1210 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5610 [inline]
       ext4_fill_super+0x9631/0xaab0 fs/ext4/super.c:5733
       get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636
       vfs_get_tree+0x92/0x380 fs/super.c:1814
       do_new_mount fs/namespace.c:3511 [inline]
       path_mount+0x14e6/0x1f10 fs/namespace.c:3838
       do_mount fs/namespace.c:3851 [inline]
       __do_sys_mount fs/namespace.c:4061 [inline]
       __se_sys_mount fs/namespace.c:4038 [inline]
       __x64_sys_mount+0x294/0x320 fs/namespace.c:4038
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ei->i_data_sem/2){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
       down_write+0x93/0x200 kernel/locking/rwsem.c:1577
       ext4_inline_data_truncate+0x4ce/0xc70 fs/ext4/inline.c:1950
       ext4_truncate+0x9ab/0x1270 fs/ext4/inode.c:4173
       ext4_evict_inode+0x7af/0x18c0 fs/ext4/inode.c:263
       evict+0x40c/0x960 fs/inode.c:796
       iput_final fs/inode.c:1946 [inline]
       iput fs/inode.c:1972 [inline]
       iput+0x52a/0x890 fs/inode.c:1958
       ext4_orphan_cleanup+0x742/0x1210 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5610 [inline]
       ext4_fill_super+0x9631/0xaab0 fs/ext4/super.c:5733
       get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636
       vfs_get_tree+0x92/0x380 fs/super.c:1814
       do_new_mount fs/namespace.c:3511 [inline]
       path_mount+0x14e6/0x1f10 fs/namespace.c:3838
       do_mount fs/namespace.c:3851 [inline]
       __do_sys_mount fs/namespace.c:4061 [inline]
       __se_sys_mount fs/namespace.c:4038 [inline]
       __x64_sys_mount+0x294/0x320 fs/namespace.c:4038
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/2 --> mapping.invalidate_lock --> &ei->xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->xattr_sem);
                               lock(mapping.invalidate_lock);
                               lock(&ei->xattr_sem);
  lock(&ei->i_data_sem/2);

 *** DEADLOCK ***

3 locks held by syz.8.6167/24686:
 #0: ffff888033a320e0 (&type->s_umount_key#27/1){+.+.}-{4:4}, at: alloc_super+0x23d/0xbd0 fs/super.c:344
 #1: ffff888033a32610 (sb_internal){.+.+}-{0:0}, at: evict+0x40c/0x960 fs/inode.c:796
 #2: ffff88803417e3d8 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline]
 #2: ffff88803417e3d8 (&ei->xattr_sem){++++}-{4:4}, at: ext4_inline_data_truncate+0x1af/0xc70 fs/ext4/inline.c:1936

stack backtrace:
CPU: 0 UID: 0 PID: 24686 Comm: syz.8.6167 Not tainted 6.13.0-rc7-syzkaller-00019-gc45323b7560e #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
 down_write+0x93/0x200 kernel/locking/rwsem.c:1577
 ext4_inline_data_truncate+0x4ce/0xc70 fs/ext4/inline.c:1950
 ext4_truncate+0x9ab/0x1270 fs/ext4/inode.c:4173
 ext4_evict_inode+0x7af/0x18c0 fs/ext4/inode.c:263
 evict+0x40c/0x960 fs/inode.c:796
 iput_final fs/inode.c:1946 [inline]
 iput fs/inode.c:1972 [inline]
 iput+0x52a/0x890 fs/inode.c:1958
 ext4_orphan_cleanup+0x742/0x1210 fs/ext4/orphan.c:474
 __ext4_fill_super fs/ext4/super.c:5610 [inline]
 ext4_fill_super+0x9631/0xaab0 fs/ext4/super.c:5733
 get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636
 vfs_get_tree+0x92/0x380 fs/super.c:1814
 do_new_mount fs/namespace.c:3511 [inline]
 path_mount+0x14e6/0x1f10 fs/namespace.c:3838
 do_mount fs/namespace.c:3851 [inline]
 __do_sys_mount fs/namespace.c:4061 [inline]
 __se_sys_mount fs/namespace.c:4038 [inline]
 __x64_sys_mount+0x294/0x320 fs/namespace.c:4038
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa2a31874ca
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa2a403de68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fa2a403def0 RCX: 00007fa2a31874ca
RDX: 0000000020000040 RSI: 0000000020000000 RDI: 00007fa2a403deb0
RBP: 0000000020000040 R08: 00007fa2a403def0 R09: 000000000000010e
R10: 000000000000010e R11: 0000000000000246 R12: 0000000020000000
R13: 00007fa2a403deb0 R14: 000000000000044d R15: 000000000000002c
 </TASK>
EXT4-fs (loop8): 1 orphan inode deleted
EXT4-fs (loop8): 1 truncate cleaned up
EXT4-fs (loop8): mounted filesystem 00000000-0000-0000-0000-000000000000 r/w without journal. Quota mode: writeback.
EXT4-fs error (device loop8): ext4_lookup:1813: inode #15: comm syz.8.6167: iget: bad extra_isize 46 (inode size 256)
EXT4-fs (loop8): Remounting filesystem read-only