syzbot

EXT4-fs (loop0): mounted filesystem 76b65be2-f6da-4727-8c75-0525a5b65a09 r/w without journal. Quota mode: writeback.
ext4 filesystem being mounted at /13/file1 supports timestamps until 2038-01-19 (0x7fffffff)
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.30/5996 is trying to acquire lock:
ffff88804018df38 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline]
ffff88804018df38 (&ei->xattr_sem){++++}-{4:4}, at: ext4_xattr_set_handle+0x194/0x1540 fs/ext4/xattr.c:2374

but task is already holding lock:
ffff88803aa50cd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages_down_write fs/ext4/ext4.h:1823 [inline]
ffff88803aa50cd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x317/0x10e0 fs/ext4/migrate.c:438

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       percpu_down_read_internal+0x48/0x1d0 include/linux/percpu-rwsem.h:53
       percpu_down_read include/linux/percpu-rwsem.h:77 [inline]
       ext4_writepages_down_read fs/ext4/ext4.h:1811 [inline]
       ext4_writepages+0x205/0x3b0 fs/ext4/inode.c:3041
       do_writepages+0x338/0x560 mm/page-writeback.c:2571
       __writeback_single_inode+0x12e/0xf90 fs/fs-writeback.c:1764
       writeback_single_inode+0x483/0xd80 fs/fs-writeback.c:1883
       write_inode_now+0x1c2/0x290 fs/fs-writeback.c:2974
       iput_final fs/inode.c:1950 [inline]
       iput+0x864/0xe00 fs/inode.c:2009
       ext4_xattr_block_set+0x22e4/0x2a80 fs/ext4/xattr.c:2153
       ext4_xattr_move_to_block fs/ext4/xattr.c:2671 [inline]
       ext4_xattr_make_inode_space fs/ext4/xattr.c:2746 [inline]
       ext4_expand_extra_isize_ea+0x1342/0x1e70 fs/ext4/xattr.c:2834
       __ext4_expand_extra_isize+0x30d/0x400 fs/ext4/inode.c:6434
       ext4_try_to_expand_extra_isize fs/ext4/inode.c:6477 [inline]
       __ext4_mark_inode_dirty+0x455/0x700 fs/ext4/inode.c:6555
       ext4_evict_inode+0x976/0x10c0 fs/ext4/inode.c:267
       evict+0x624/0xb50 fs/inode.c:841
       ext4_orphan_cleanup+0xc7a/0x14c0 fs/ext4/orphan.c:472
       __ext4_fill_super fs/ext4/super.c:5701 [inline]
       ext4_fill_super+0x5cc3/0x65d0 fs/ext4/super.c:5824
       get_tree_bdev_flags+0x430/0x4f0 fs/super.c:1694
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3761 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3837
       do_mount fs/namespace.c:4170 [inline]
       __do_sys_mount fs/namespace.c:4386 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4363
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ei->xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1520/0x2cc0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
       ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline]
       ext4_xattr_set_handle+0x194/0x1540 fs/ext4/xattr.c:2374
       ext4_initxattrs+0xa4/0x120 fs/ext4/xattr_security.c:44
       security_inode_init_security+0x29b/0x3e0 security/security.c:1370
       __ext4_new_inode+0x3435/0x3e40 fs/ext4/ialloc.c:1330
       ext4_ext_migrate+0x718/0x10e0 fs/ext4/migrate.c:462
       __ext4_ioctl fs/ext4/ioctl.c:1693 [inline]
       ext4_ioctl+0x2353/0x4b20 fs/ext4/ioctl.c:1922
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->s_writepages_rwsem);
                               lock(&ei->xattr_sem);
                               lock(&sbi->s_writepages_rwsem);
  lock(&ei->xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.0.30/5996:
 #0: ffff88802be1c480 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x63/0x210 fs/namespace.c:537
 #1: ffff88804018ee70 (&sb->s_type->i_mutex_key#10){++++}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #1: ffff88804018ee70 (&sb->s_type->i_mutex_key#10){++++}-{4:4}, at: __ext4_ioctl fs/ext4/ioctl.c:1692 [inline]
 #1: ffff88804018ee70 (&sb->s_type->i_mutex_key#10){++++}-{4:4}, at: ext4_ioctl+0x234b/0x4b20 fs/ext4/ioctl.c:1922
 #2: ffff88803aa50cd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages_down_write fs/ext4/ext4.h:1823 [inline]
 #2: ffff88803aa50cd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x317/0x10e0 fs/ext4/migrate.c:438

stack backtrace:
CPU: 0 UID: 0 PID: 5996 Comm: syz.0.30 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1520/0x2cc0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
 ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline]
 ext4_xattr_set_handle+0x194/0x1540 fs/ext4/xattr.c:2374
 ext4_initxattrs+0xa4/0x120 fs/ext4/xattr_security.c:44
 security_inode_init_security+0x29b/0x3e0 security/security.c:1370
 __ext4_new_inode+0x3435/0x3e40 fs/ext4/ialloc.c:1330
 ext4_ext_migrate+0x718/0x10e0 fs/ext4/migrate.c:462
 __ext4_ioctl fs/ext4/ioctl.c:1693 [inline]
 ext4_ioctl+0x2353/0x4b20 fs/ext4/ioctl.c:1922
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:597 [inline]
 __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fda8ca4ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffede327c98 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fda8ccc5fa0 RCX: 00007fda8ca4ce59
RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000005
RBP: 00007fda8cae2d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fda8ccc5fac R14: 00007fda8ccc5fa0 R15: 00007fda8ccc5fa0
 </TASK>