syzbot

======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc5-syzkaller-00043-gd76bb1ebb558 #0 Not tainted
------------------------------------------------------
syz.3.984/10904 is trying to acquire lock:
ffff888036529800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff888036529800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:669

but task is already holding lock:
ffff88803652a640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff88803652a640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2d5/0x1210 fs/ocfs2/inode.c:790

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2727
       ocfs2_dio_end_io_write+0x2cb/0xf30 fs/ocfs2/aops.c:2303
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2401
       dio_complete+0x224/0x970 fs/direct-io.c:281
       __blockdev_direct_IO+0x33eb/0x4080 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2438
       generic_file_direct_write+0x19a/0x410 mm/filemap.c:4037
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4206
       ocfs2_file_write_iter+0xbc4/0x21b0 fs/ocfs2/file.c:2469
       do_iter_readv_writev+0x657/0x950 fs/read_write.c:825
       vfs_writev+0x353/0xdc0 fs/read_write.c:1055
       do_pwritev+0x1af/0x270 fs/read_write.c:1151
       __do_sys_pwritev2 fs/read_write.c:1209 [inline]
       __se_sys_pwritev2 fs/read_write.c:1200 [inline]
       __x64_sys_pwritev2+0xef/0x160 fs/read_write.c:1200
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       ocfs2_page_mkwrite+0x309/0xd70 fs/ocfs2/mmap.c:142
       do_page_mkwrite+0x174/0x380 mm/memory.c:3287
       do_shared_fault mm/memory.c:5594 [inline]
       do_fault mm/memory.c:5656 [inline]
       do_pte_missing+0x29c/0x3fb0 mm/memory.c:4160
       handle_pte_fault mm/memory.c:5997 [inline]
       __handle_mm_fault+0x103d/0x2a40 mm/memory.c:6140
       handle_mm_fault+0x3fe/0xad0 mm/memory.c:6309
       do_user_addr_fault+0x7a6/0x1370 arch/x86/mm/fault.c:1388
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x5c/0xc0 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #4 (sb_pagefaults#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1783 [inline]
       sb_start_pagefault include/linux/fs.h:1948 [inline]
       ocfs2_page_mkwrite+0x1cf/0xd70 fs/ocfs2/mmap.c:122
       do_page_mkwrite+0x174/0x380 mm/memory.c:3287
       do_shared_fault mm/memory.c:5594 [inline]
       do_fault mm/memory.c:5656 [inline]
       do_pte_missing+0x29c/0x3fb0 mm/memory.c:4160
       handle_pte_fault mm/memory.c:5997 [inline]
       __handle_mm_fault+0x103d/0x2a40 mm/memory.c:6140
       handle_mm_fault+0x3fe/0xad0 mm/memory.c:6309
       do_user_addr_fault+0x7a6/0x1370 arch/x86/mm/fault.c:1388
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x5c/0xc0 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #3 (&mm->mmap_lock){++++}-{4:4}:
       __might_fault mm/memory.c:7151 [inline]
       __might_fault+0x113/0x190 mm/memory.c:7145
       _inline_copy_to_user include/linux/uaccess.h:192 [inline]
       _copy_to_user+0x2d/0xd0 lib/usercopy.c:26
       copy_to_user include/linux/uaccess.h:225 [inline]
       fiemap_fill_next_extent+0x239/0x390 fs/ioctl.c:145
       ocfs2_fiemap_inline fs/ocfs2/extent_map.c:735 [inline]
       ocfs2_fiemap+0x91e/0xd00 fs/ocfs2/extent_map.c:772
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x404/0x1990 fs/ioctl.c:840
       __do_sys_ioctl fs/ioctl.c:904 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x11d/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       ocfs2_create_local_dquot+0x157/0xb30 fs/ocfs2/quota_local.c:1232
       ocfs2_acquire_dquot+0x626/0xb00 fs/ocfs2/quota_global.c:883
       dqget+0x693/0x1180 fs/quota/dquot.c:977
       ocfs2_setattr+0x1d82/0x2560 fs/ocfs2/file.c:1233
       notify_change+0x6a9/0x1230 fs/attr.c:552
       chown_common+0x536/0x670 fs/open.c:782
       vfs_fchown fs/open.c:850 [inline]
       vfs_fchown fs/open.c:842 [inline]
       ksys_fchown+0x11f/0x170 fs/open.c:862
       __do_sys_fchown fs/open.c:867 [inline]
       __se_sys_fchown fs/open.c:865 [inline]
       __x64_sys_fchown+0x72/0xb0 fs/open.c:865
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&dquot->dq_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x199/0xb90 kernel/locking/mutex.c:746
       wait_on_dquot fs/quota/dquot.c:354 [inline]
       dqget+0x5f1/0x1180 fs/quota/dquot.c:972
       __dquot_initialize+0x586/0xd50 fs/quota/dquot.c:1505
       ocfs2_get_init_inode+0xe7/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x974/0x2540 fs/ocfs2/namei.c:310
       ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:673
       lookup_open.isra.0+0x11d3/0x1580 fs/namei.c:3701
       open_last_lookups fs/namei.c:3800 [inline]
       path_openat+0x905/0x2d40 fs/namei.c:4036
       do_filp_open+0x20b/0x470 fs/namei.c:4066
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_openat fs/open.c:1460 [inline]
       __se_sys_openat fs/open.c:1455 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1455
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain kernel/locking/lockdep.c:3909 [inline]
       __lock_acquire+0x1173/0x1ba0 kernel/locking/lockdep.c:5235
       lock_acquire kernel/locking/lockdep.c:5866 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5823
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:669
       ocfs2_wipe_inode+0x446/0x1210 fs/ocfs2/inode.c:832
       ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
       ocfs2_evict_inode+0x6e0/0x1680 fs/ocfs2/inode.c:1230
       evict+0x3e6/0x920 fs/inode.c:810
       iput_final fs/inode.c:1898 [inline]
       iput fs/inode.c:1924 [inline]
       iput+0x521/0x880 fs/inode.c:1910
       ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
       dentry_unlink_inode+0x282/0x480 fs/dcache.c:455
       __dentry_kill+0x1d0/0x600 fs/dcache.c:660
       dput.part.0+0x4b1/0x9b0 fs/dcache.c:902
       dput+0x1f/0x30 fs/dcache.c:892
       __fput+0x51c/0xb70 fs/file_table.c:473
       task_work_run+0x150/0x240 kernel/task_work.c:227
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       exit_to_user_mode_loop kernel/entry/common.c:114 [inline]
       exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline]
       __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline]
       syscall_exit_to_user_mode+0x27b/0x2a0 kernel/entry/common.c:218
       do_syscall_64+0xda/0x260 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_file_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

2 locks held by syz.3.984/10904:
 #0: ffff888022f70bd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0xe4/0x2e0 fs/ocfs2/dlmglue.c:2875
 #1: ffff88803652a640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #1: ffff88803652a640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode+0x2d5/0x1210 fs/ocfs2/inode.c:790

stack backtrace:
CPU: 0 UID: 0 PID: 10904 Comm: syz.3.984 Not tainted 6.15.0-rc5-syzkaller-00043-gd76bb1ebb558 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/29/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2079
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain kernel/locking/lockdep.c:3909 [inline]
 __lock_acquire+0x1173/0x1ba0 kernel/locking/lockdep.c:5235
 lock_acquire kernel/locking/lockdep.c:5866 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5823
 down_write+0x92/0x200 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:867 [inline]
 ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:669
 ocfs2_wipe_inode+0x446/0x1210 fs/ocfs2/inode.c:832
 ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
 ocfs2_evict_inode+0x6e0/0x1680 fs/ocfs2/inode.c:1230
 evict+0x3e6/0x920 fs/inode.c:810
 iput_final fs/inode.c:1898 [inline]
 iput fs/inode.c:1924 [inline]
 iput+0x521/0x880 fs/inode.c:1910
 ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
 dentry_unlink_inode+0x282/0x480 fs/dcache.c:455
 __dentry_kill+0x1d0/0x600 fs/dcache.c:660
 dput.part.0+0x4b1/0x9b0 fs/dcache.c:902
 dput+0x1f/0x30 fs/dcache.c:892
 __fput+0x51c/0xb70 fs/file_table.c:473
 task_work_run+0x150/0x240 kernel/task_work.c:227
 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
 exit_to_user_mode_loop kernel/entry/common.c:114 [inline]
 exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline]
 __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline]
 syscall_exit_to_user_mode+0x27b/0x2a0 kernel/entry/common.c:218
 do_syscall_64+0xda/0x260 arch/x86/entry/syscall_64.c:100
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb32a38e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc5e72f478 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4
RAX: 0000000000000000 RBX: 00000000000b618d RCX: 00007fb32a38e969
RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003
RBP: 00007fb32a5b7ba0 R08: 0000000000000001 R09: 000000065e72f76f
R10: 00007fb32a200000 R11: 0000000000000246 R12: 00007fb32a5b5fac
R13: 00007fb32a5b5fa0 R14: ffffffffffffffff R15: 00007ffc5e72f590
 </TASK>