KASAN: use-after-free Read in v4l2_ioctl

Status: closed as dup on 2019/08/13 14:06
Subsystems: usb media
[Documentation on labels]
Reported-by: syzbot+d587871cd33a9bc7c086@syzkaller.appspotmail.com
Fix commit: c666355e60dd media: radio-raremono: change devm_k*alloc to k*alloc
First crash: 2672d, last: 2590d
▶ ▼ Duplicate of
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported
KASAN: use-after-free Read in v4l2_release usb media 19 syz, C 275 2566d 2669d
▶ ▼ Duplicate bugs (4)
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
KASAN: use-after-free Read in v4l2_fh_del media 19 1 2654d 2652d 0/29 closed as dup on 2019/08/13 12:59
KASAN: use-after-free Write in v4l2_prio_close media 22 1 2622d 2621d 0/29 closed as dup on 2019/08/13 12:58
KASAN: use-after-free Write in v4l2_device_release media 22 3 2646d 2656d 0/29 closed as dup on 2019/08/13 12:58
KASAN: use-after-free Read in __video_do_ioctl media usb input 19 syz 63 2570d 2670d 0/29 closed as dup on 2019/08/13 12:28
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
KASAN: use-after-free Read in v4l2_ioctl 2 (3) 2019/08/13 14:06
Reminder: 28 open syzbot bugs in media subsystem 1 (1) 2019/06/27 03:53
▶ ▼ Similar bugs (1)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Read in v4l2_ioctl (2) media usb 19 syz, C error 1 1872d 1868d 0/29 auto-obsoleted due to no activity on 2023/04/14 09:33
▶ ▼ Last patch testing requests (2)
Created Duration User Patch Repo Result
2019/06/29 23:49 39m lnowakow@eng.ucsd.edu patch https://github.com/google/kasan.git usb-fuzzer OK
2019/06/29 23:36 5m lnowakow@eng.ucsd.edu patch https://github.com/google/kasan.git usb-fuzzer error

Sample crash report:
usb 6-1: USB disconnect, device number 66
radio-raremono 6-1:0.210: Thanko's Raremono disconnected
radio-raremono 1-1:0.210: V4L2 device registered as radio33
==================================================================
usb 1-1: USB disconnect, device number 67
BUG: KASAN: use-after-free in v4l2_ioctl+0x187/0x1a0 drivers/media/v4l2-core/v4l2-dev.c:362
Read of size 8 at addr ffff8880966123e0 by task v4l_id/6796

CPU: 1 PID: 6796 Comm: v4l_id Not tainted 5.1.0-rc4-319354-g9a33b36 #3
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
radio-raremono 1-1:0.210: Thanko's Raremono disconnected
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xe8/0x16e lib/dump_stack.c:113
 print_address_description+0x6c/0x236 mm/kasan/report.c:187
radio-raremono 5-1:0.210: raremono_cmd_main failed (-71)
radio-raremono 5-1:0.210: V4L2 device registered as radio33
 kasan_report.cold+0x1a/0x3c mm/kasan/report.c:317
 v4l2_ioctl+0x187/0x1a0 drivers/media/v4l2-core/v4l2-dev.c:362
usb 5-1: USB disconnect, device number 67
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:509 [inline]
 do_vfs_ioctl+0xced/0x12f0 fs/ioctl.c:696
radio-raremono 5-1:0.210: Thanko's Raremono disconnected
 ksys_ioctl+0xa0/0xc0 fs/ioctl.c:713
 __do_sys_ioctl fs/ioctl.c:720 [inline]
 __se_sys_ioctl fs/ioctl.c:718 [inline]
 __x64_sys_ioctl+0x74/0xb0 fs/ioctl.c:718
 do_syscall_64+0xcf/0x4f0 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fa09191e347
usb 3-1: Using ep0 maxpacket: 8
Code: 90 90 90 48 8b 05 f1 fa 2a 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 90 90 90 90 90 90 90 90 90 90 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d c1 fa 2a 00 31 d2 48 29 c2 64
RSP: 002b:00007ffef9276ed8 EFLAGS: 00000206 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fa09191e347
RDX: 00007ffef9276ee0 RSI: 0000000080685600 RDI: 0000000000000003
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000206 R12: 0000000000400884
R13: 00007ffef9277030 R14: 0000000000000000 R15: 0000000000000000
usb 4-1: Using ep0 maxpacket: 8

Allocated by task 21:
 set_track mm/kasan/common.c:87 [inline]
 __kasan_kmalloc mm/kasan/common.c:497 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:470
 slab_post_alloc_hook mm/slab.h:437 [inline]
 slab_alloc_node mm/slub.c:2756 [inline]
 __kmalloc_node_track_caller+0xf3/0x320 mm/slub.c:4372
 alloc_dr drivers/base/devres.c:103 [inline]
 devm_kmalloc+0x8c/0x190 drivers/base/devres.c:793
 devm_kzalloc include/linux/device.h:679 [inline]
 usb_raremono_probe+0x34/0x235 drivers/media/radio/radio-raremono.c:298
 usb_probe_interface+0x31d/0x820 drivers/usb/core/driver.c:361
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_set_configuration+0xdf7/0x1740 drivers/usb/core/message.c:2021
 generic_probe+0xa2/0xda drivers/usb/core/generic.c:210
 usb_probe_device+0xc0/0x150 drivers/usb/core/driver.c:266
usb 3-1: config 0 has an invalid interface number: 210 but max is 0
 really_probe+0x2da/0xb10 drivers/base/dd.c:509
 driver_probe_device+0x21d/0x350 drivers/base/dd.c:671
 __device_attach_driver+0x1d8/0x290 drivers/base/dd.c:778
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:454
 __device_attach+0x223/0x3a0 drivers/base/dd.c:844
usb 3-1: config 0 has no interface number 0
 bus_probe_device+0x1f1/0x2a0 drivers/base/bus.c:514
usb 3-1: New USB device found, idVendor=10c4, idProduct=818a, bcdDevice=37.10
 device_add+0xad2/0x16e0 drivers/base/core.c:2106
 usb_new_device.cold+0x537/0xccf drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x138e/0x3b00 drivers/usb/core/hub.c:5432
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 process_scheduled_works kernel/workqueue.c:2331 [inline]
 worker_thread+0x7b0/0xe20 kernel/workqueue.c:2417
usb 3-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
 kthread+0x313/0x420 kernel/kthread.c:253
usb 4-1: config 0 has an invalid interface number: 210 but max is 0
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352

Freed by task 21:
 set_track mm/kasan/common.c:87 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:459
 slab_free_hook mm/slub.c:1429 [inline]
 slab_free_freelist_hook+0x5e/0x140 mm/slub.c:1456
 slab_free mm/slub.c:3003 [inline]
 kfree+0xce/0x290 mm/slub.c:3958
usb 4-1: config 0 has no interface number 0
 release_nodes+0x4ac/0x920 drivers/base/devres.c:508
usb 4-1: New USB device found, idVendor=10c4, idProduct=818a, bcdDevice=37.10
 devres_release_all+0x79/0xc8 drivers/base/devres.c:529
 __device_release_driver drivers/base/dd.c:1086 [inline]
 device_release_driver_internal+0x23a/0x4f0 drivers/base/dd.c:1113
 bus_remove_device+0x302/0x5c0 drivers/base/bus.c:556
 device_del+0x467/0xb90 drivers/base/core.c:2269
usb 4-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
 usb_disable_device+0x242/0x790 drivers/usb/core/message.c:1235
 usb_disconnect+0x298/0x870 drivers/usb/core/hub.c:2197
 hub_port_connect drivers/usb/core/hub.c:4940 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0xcd2/0x3b00 drivers/usb/core/hub.c:5432
 process_one_work+0x90f/0x1580 kernel/workqueue.c:2269
 process_scheduled_works kernel/workqueue.c:2331 [inline]
 worker_thread+0x7b0/0xe20 kernel/workqueue.c:2417
 kthread+0x313/0x420 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff888096612200
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 480 bytes inside of
 4096-byte region [ffff888096612200, ffff888096613200)
The buggy address belongs to the page:
page:ffffea0002598400 count:1 mapcount:0 mapping:ffff88812c3f4600 index:0x0 compound_mapcount: 0
usb 3-1: config 0 descriptor??
flags: 0xfff00000010200(slab|head)
raw: 00fff00000010200 dead000000000100 dead000000000200 ffff88812c3f4600
raw: 0000000000000000 0000000000070007 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff888096612280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888096612300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff888096612380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                       ^
 ffff888096612400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888096612480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
usb 4-1: config 0 descriptor??

Crashes (33):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/04/15 15:41 https://github.com/google/kasan.git usb-fuzzer 9a33b36996cb 505ab413 .config console log report syz C ci2-upstream-usb
2019/04/13 07:32 https://github.com/google/kasan.git usb-fuzzer 9a33b36996cb c402d8f1 .config console log report syz C ci2-upstream-usb
2019/04/29 18:18 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce b617407b .config console log report syz ci2-upstream-usb
2019/07/04 03:20 https://github.com/google/kasan.git usb-fuzzer 7829a896a587 55565fa0 .config console log report ci2-upstream-usb
2019/06/27 23:00 https://github.com/google/kasan.git usb-fuzzer 7829a896a587 7509bf36 .config console log report ci2-upstream-usb
2019/06/17 13:21 https://github.com/google/kasan.git usb-fuzzer 69bbe8c72e6f 442206d7 .config console log report ci2-upstream-usb
2019/06/02 12:26 https://github.com/google/kasan.git usb-fuzzer 69bbe8c72e6f 53c81ea5 .config console log report ci2-upstream-usb
2019/05/29 16:58 https://github.com/google/kasan.git usb-fuzzer 69bbe8c72e6f f5a25d38 .config console log report ci2-upstream-usb
2019/05/25 00:17 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 85c57315 .config console log report ci2-upstream-usb
2019/05/22 23:53 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 84b9d384 .config console log report ci2-upstream-usb
2019/05/13 16:43 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 16ab1e89 .config console log report ci2-upstream-usb
2019/05/13 05:23 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/13 03:31 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/13 02:57 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/13 02:51 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/12 23:43 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/12 19:15 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 5f302c04 .config console log report ci2-upstream-usb
2019/05/12 12:18 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce c017728b .config console log report ci2-upstream-usb
2019/05/12 12:02 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce c017728b .config console log report ci2-upstream-usb
2019/05/12 09:21 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce c017728b .config console log report ci2-upstream-usb
2019/05/11 08:32 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 46caad94 .config console log report ci2-upstream-usb
2019/05/11 08:06 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 46caad94 .config console log report ci2-upstream-usb
2019/05/10 23:34 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 46caad94 .config console log report ci2-upstream-usb
2019/05/10 10:05 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 018207ef .config console log report ci2-upstream-usb
2019/05/07 21:47 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce a7383bfa .config console log report ci2-upstream-usb
2019/05/06 16:54 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 148296f4 .config console log report ci2-upstream-usb
2019/05/04 20:35 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce d28f4ce5 .config console log report ci2-upstream-usb
2019/05/04 12:26 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce d28f4ce5 .config console log report ci2-upstream-usb
2019/05/04 11:58 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce d28f4ce5 .config console log report ci2-upstream-usb
2019/05/03 13:44 https://github.com/google/kasan.git usb-fuzzer 43151d6c3fce 1bfa09b9 .config console log report ci2-upstream-usb
2019/04/24 01:51 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa 2398edea .config console log report ci2-upstream-usb
2019/04/21 23:59 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa b0e8efcb .config console log report ci2-upstream-usb
2019/04/20 11:03 https://github.com/google/kasan.git usb-fuzzer d34f9519daaa b0e8efcb .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.