memory leak in dlfb_usb_probe

Status: fixed on 2021/04/09 19:46
Subsystems: usb fbdev
[Documentation on labels]
Reported-by: syzbot+c9e365d7f450e8aa615d@syzkaller.appspotmail.com
Fix commit: 5c0e4110f751 udlfb: Fix memory leak in dlfb_usb_probe
First crash: 2061d, last: 2055d
▶ ▼ Discussions (10)
Title Replies (including bot) Last reply
[PATCH 5.10 000/102] 5.10.21-rc1 review 119 (119) 2021/03/08 13:21
[PATCH 4.19 00/52] 4.19.179-rc1 review 57 (57) 2021/03/07 22:57
[PATCH 5.11 000/104] 5.11.4-rc1 review 119 (119) 2021/03/07 11:37
[PATCH AUTOSEL 5.11 01/67] ath10k: prevent deinitializing NAPI twice 80 (80) 2021/03/06 17:52
[PATCH 5.4 00/72] 5.4.103-rc1 review 80 (80) 2021/03/06 16:33
[PATCH AUTOSEL 5.10 01/56] EDAC/amd64: Do not load on family 0x15, model 0x13 59 (59) 2021/03/05 12:40
[PATCH AUTOSEL 4.19 01/26] staging: fwserial: Fix error handling in fwserial_create 27 (27) 2021/02/24 13:21
[PATCH AUTOSEL 5.4 01/40] staging: fwserial: Fix error handling in fwserial_create 41 (41) 2021/02/24 13:20
[PATCH] udlfb: Fix memory leak in dlfb_usb_probe 2 (2) 2020/12/15 09:55
memory leak in dlfb_usb_probe 0 (1) 2020/12/14 09:13

Sample crash report:
BUG: memory leak
unreferenced object 0xffff8881131012a0 (size 32):
  comm "kworker/1:2", pid 3178, jiffies 4294949042 (age 13.100s)
  hex dump (first 32 bytes):
    10 d8 8f 05 81 88 ff ff e0 1b 10 13 81 88 ff ff  ................
    00 d8 8f 05 81 88 ff ff 00 29 ef 0f 81 88 ff ff  .........)......
  backtrace:
    [<000000008b49e0cc>] kmalloc include/linux/slab.h:552 [inline]
    [<000000008b49e0cc>] kzalloc include/linux/slab.h:682 [inline]
    [<000000008b49e0cc>] dlfb_alloc_urb_list drivers/video/fbdev/udlfb.c:1892 [inline]
    [<000000008b49e0cc>] dlfb_usb_probe.cold+0x289/0x988 drivers/video/fbdev/udlfb.c:1704
    [<0000000073d0cc0e>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<000000001a64718f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<0000000029ee1ac6>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<0000000042a34d64>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<0000000026d9b115>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000e877d23c>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<00000000790edff4>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000ad939a90>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<000000001a64718f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431

BUG: memory leak
unreferenced object 0xffff88810fef2900 (size 192):
  comm "kworker/1:2", pid 3178, jiffies 4294949042 (age 13.100s)
  hex dump (first 32 bytes):
    01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 18 29 ef 0f 81 88 ff ff  .........)......
  backtrace:
    [<0000000092cd5614>] kmalloc include/linux/slab.h:557 [inline]
    [<0000000092cd5614>] usb_alloc_urb+0x66/0xe0 drivers/usb/core/urb.c:74
    [<00000000c61867f2>] dlfb_alloc_urb_list drivers/video/fbdev/udlfb.c:1897 [inline]
    [<00000000c61867f2>] dlfb_usb_probe.cold+0x2aa/0x988 drivers/video/fbdev/udlfb.c:1704
    [<0000000073d0cc0e>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<000000001a64718f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<0000000029ee1ac6>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<0000000042a34d64>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<0000000026d9b115>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000e877d23c>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<00000000790edff4>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000ad939a90>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851

BUG: memory leak
unreferenced object 0xffff888113101ee0 (size 32):
  comm "kworker/1:2", pid 3178, jiffies 4294949042 (age 13.100s)
  hex dump (first 32 bytes):
    a0 11 10 13 81 88 ff ff 10 d8 8f 05 81 88 ff ff  ................
    00 d8 8f 05 81 88 ff ff 40 28 ef 0f 81 88 ff ff  ........@(......
  backtrace:
    [<000000008b49e0cc>] kmalloc include/linux/slab.h:552 [inline]
    [<000000008b49e0cc>] kzalloc include/linux/slab.h:682 [inline]
    [<000000008b49e0cc>] dlfb_alloc_urb_list drivers/video/fbdev/udlfb.c:1892 [inline]
    [<000000008b49e0cc>] dlfb_usb_probe.cold+0x289/0x988 drivers/video/fbdev/udlfb.c:1704
    [<0000000073d0cc0e>] usb_probe_interface+0x177/0x370 drivers/usb/core/driver.c:396
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<000000001a64718f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431
    [<0000000029ee1ac6>] __device_attach+0x122/0x250 drivers/base/dd.c:919
    [<0000000042a34d64>] bus_probe_device+0xc6/0xe0 drivers/base/bus.c:491
    [<0000000026d9b115>] device_add+0x5be/0xc30 drivers/base/core.c:3091
    [<00000000e877d23c>] usb_set_configuration+0x9d9/0xb90 drivers/usb/core/message.c:2164
    [<00000000790edff4>] usb_generic_driver_probe+0x8c/0xc0 drivers/usb/core/generic.c:238
    [<00000000ad939a90>] usb_probe_device+0x5c/0x140 drivers/usb/core/driver.c:293
    [<00000000e756ecc8>] really_probe+0x159/0x480 drivers/base/dd.c:561
    [<000000007463a64d>] driver_probe_device+0x84/0x100 drivers/base/dd.c:745
    [<00000000dc763398>] __device_attach_driver+0xee/0x110 drivers/base/dd.c:851
    [<000000001a64718f>] bus_for_each_drv+0xb7/0x100 drivers/base/bus.c:431

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/12/17 00:54 upstream 5e60366d56c6 04201c06 .config console log report syz C ci-upstream-gce-leak
2020/12/16 12:17 upstream d635a69dd498 f213e07e .config console log report syz C ci-upstream-gce-leak
2020/12/10 09:07 upstream a68a0262abda c090b4da .config console log report syz C ci-upstream-gce-leak
* Struck through repros no longer work on HEAD.