syzbot


possible deadlock in ocfs2_read_folio

Status: upstream: reported on 2025/02/13 14:33
Subsystems: ocfs2
[Documentation on labels]
Reported-by: syzbot+bd316bb736c7dc2f318e@syzkaller.appspotmail.com
First crash: 96d, last: 22d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ocfs2?] possible deadlock in ocfs2_read_folio 0 (1) 2025/02/13 14:33

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc3-syzkaller-00076-ge72e9e693307 #0 Not tainted
------------------------------------------------------
syz.8.554/12554 is trying to acquire lock:
ffff88806d6dea20 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_read_folio+0x36c/0x990 fs/ocfs2/aops.c:287

but task is already holding lock:
ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:922 [inline]
ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_create_folio mm/filemap.c:2527 [inline]
ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_get_pages+0xdcb/0x1fc0 mm/filemap.c:2597

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (mapping.invalidate_lock#13){.+.+}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524
       filemap_invalidate_lock_shared include/linux/fs.h:922 [inline]
       filemap_fault+0x66b/0x13d0 mm/filemap.c:3391
       ocfs2_fault+0xbd/0x3e0 fs/ocfs2/mmap.c:38
       __do_fault+0x135/0x390 mm/memory.c:5098
       do_read_fault mm/memory.c:5518 [inline]
       do_fault mm/memory.c:5652 [inline]
       do_pte_missing mm/memory.c:4160 [inline]
       handle_pte_fault+0x3f0c/0x61c0 mm/memory.c:5997
       __handle_mm_fault mm/memory.c:6140 [inline]
       handle_mm_fault+0x1030/0x1aa0 mm/memory.c:6309
       do_user_addr_fault arch/x86/mm/fault.c:1388 [inline]
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x2bb/0x920 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
       rep_movs_alternative+0x30/0x90 arch/x86/lib/copy_user_64.S:53
       copy_user_generic arch/x86/include/asm/uaccess_64.h:126 [inline]
       raw_copy_from_user arch/x86/include/asm/uaccess_64.h:141 [inline]
       _inline_copy_from_user include/linux/uaccess.h:178 [inline]
       _copy_from_user+0x7b/0xb0 lib/usercopy.c:18
       copy_from_user include/linux/uaccess.h:212 [inline]
       ioctl_fiemap fs/ioctl.c:210 [inline]
       do_vfs_ioctl+0x9bf/0x2750 fs/ioctl.c:840
       __do_sys_ioctl fs/ioctl.c:904 [inline]
       __se_sys_ioctl+0x80/0x160 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       __might_fault+0xc6/0x120 mm/memory.c:7151
       _inline_copy_to_user include/linux/uaccess.h:192 [inline]
       _copy_to_user+0x2c/0xb0 lib/usercopy.c:26
       copy_to_user include/linux/uaccess.h:225 [inline]
       fiemap_fill_next_extent+0x237/0x420 fs/ioctl.c:145
       ocfs2_fiemap+0xa07/0x1020 fs/ocfs2/extent_map.c:806
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x1975/0x2750 fs/ioctl.c:840
       __do_sys_ioctl fs/ioctl.c:904 [inline]
       __se_sys_ioctl+0x80/0x160 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
       __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524
       ocfs2_read_folio+0x36c/0x990 fs/ocfs2/aops.c:287
       filemap_read_folio+0x14a/0x3b0 mm/filemap.c:2401
       filemap_create_folio mm/filemap.c:2536 [inline]
       filemap_get_pages+0x104f/0x1fc0 mm/filemap.c:2597
       filemap_read+0x466/0x1260 mm/filemap.c:2702
       ocfs2_file_read_iter+0x42d/0xb80 fs/ocfs2/file.c:2589
       __kernel_read+0x532/0xa10 fs/read_write.c:528
       integrity_kernel_read+0xb2/0x100 security/integrity/iint.c:28
       ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
       ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
       ima_calc_file_hash+0xb22/0x1c10 security/integrity/ima/ima_crypto.c:568
       ima_collect_measurement+0x52b/0xb20 security/integrity/ima/ima_api.c:293
       process_measurement+0x1428/0x2190 security/integrity/ima/ima_main.c:385
       ima_file_check+0xdb/0x130 security/integrity/ima/ima_main.c:613
       security_file_post_open+0xb9/0x280 security/security.c:3130
       do_open fs/namei.c:3882 [inline]
       path_openat+0x2cf7/0x35d0 fs/namei.c:4039
       do_filp_open+0x284/0x4e0 fs/namei.c:4066
       do_sys_openat2+0x12b/0x1d0 fs/open.c:1429
       do_sys_open fs/open.c:1444 [inline]
       __do_sys_openat fs/open.c:1460 [inline]
       __se_sys_openat fs/open.c:1455 [inline]
       __x64_sys_openat+0x249/0x2a0 fs/open.c:1455
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> &mm->mmap_lock --> mapping.invalidate_lock#13

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(mapping.invalidate_lock#13);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#13);
  rlock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

2 locks held by syz.8.554/12554:
 #0: ffff888056857b08 (&ima_iint_mutex_key[depth]){+.+.}-{4:4}, at: process_measurement+0x88c/0x2190 security/integrity/ima/ima_main.c:279
 #1: ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:922 [inline]
 #1: ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_create_folio mm/filemap.c:2527 [inline]
 #1: ffff88806d6def20 (mapping.invalidate_lock#13){.+.+}-{4:4}, at: filemap_get_pages+0xdcb/0x1fc0 mm/filemap.c:2597

stack backtrace:
CPU: 1 UID: 0 PID: 12554 Comm: syz.8.554 Not tainted 6.15.0-rc3-syzkaller-00076-ge72e9e693307 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079
 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
 down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524
 ocfs2_read_folio+0x36c/0x990 fs/ocfs2/aops.c:287
 filemap_read_folio+0x14a/0x3b0 mm/filemap.c:2401
 filemap_create_folio mm/filemap.c:2536 [inline]
 filemap_get_pages+0x104f/0x1fc0 mm/filemap.c:2597
 filemap_read+0x466/0x1260 mm/filemap.c:2702
 ocfs2_file_read_iter+0x42d/0xb80 fs/ocfs2/file.c:2589
 __kernel_read+0x532/0xa10 fs/read_write.c:528
 integrity_kernel_read+0xb2/0x100 security/integrity/iint.c:28
 ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:480 [inline]
 ima_calc_file_shash security/integrity/ima/ima_crypto.c:511 [inline]
 ima_calc_file_hash+0xb22/0x1c10 security/integrity/ima/ima_crypto.c:568
 ima_collect_measurement+0x52b/0xb20 security/integrity/ima/ima_api.c:293
 process_measurement+0x1428/0x2190 security/integrity/ima/ima_main.c:385
 ima_file_check+0xdb/0x130 security/integrity/ima/ima_main.c:613
 security_file_post_open+0xb9/0x280 security/security.c:3130
 do_open fs/namei.c:3882 [inline]
 path_openat+0x2cf7/0x35d0 fs/namei.c:4039
 do_filp_open+0x284/0x4e0 fs/namei.c:4066
 do_sys_openat2+0x12b/0x1d0 fs/open.c:1429
 do_sys_open fs/open.c:1444 [inline]
 __do_sys_openat fs/open.c:1460 [inline]
 __se_sys_openat fs/open.c:1455 [inline]
 __x64_sys_openat+0x249/0x2a0 fs/open.c:1455
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf3/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f70f6d8e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f70f7b40038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f70f6fb6080 RCX: 00007f70f6d8e969
RDX: 0000000000000042 RSI: 00002000000002c0 RDI: ffffffffffffff9c
RBP: 00007f70f6e10ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000001 R14: 00007f70f6fb6080 R15: 00007ffc51655138
 </TASK>

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/04/24 19:07 upstream e72e9e693307 9882047a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/04/15 18:15 upstream 1a1d569a75f3 23b969b7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
2025/02/09 14:24 upstream 9946eaf552b1 ef44b750 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ocfs2_read_folio
* Struck through repros no longer work on HEAD.