syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.56/4632 is trying to acquire lock:
ffff888074681488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x1a4/0x7f0 fs/ocfs2/sysfile.c:101

but task is already holding lock:
ffff88805f776a20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: __ocfs2_change_file_space+0x719/0xf60 fs/ocfs2/file.c:2018

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x240/0x8e0 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x39d/0x1f90 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0xdb/0x2f0 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x33f/0x7f0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x315/0x6e0 fs/ocfs2/super.c:458
       ocfs2_initialize_super fs/ocfs2/super.c:2279 [inline]
       ocfs2_fill_super+0x4032/0x50c0 fs/ocfs2/super.c:995
       mount_bdev+0x28a/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x247/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&osb->system_file_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1e5/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       ocfs2_get_system_file_inode+0x1a4/0x7f0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x12e/0x44b0 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:978
       ocfs2_reserve_new_metadata fs/ocfs2/suballoc.c:1021 [inline]
       ocfs2_lock_allocators+0x28f/0x5f0 fs/ocfs2/suballoc.c:2668
       ocfs2_extend_allocation+0x3fe/0x1830 fs/ocfs2/file.c:588
       ocfs2_allocate_unwritten_extents+0x311/0x830 fs/ocfs2/file.c:1499
       __ocfs2_change_file_space+0x7dc/0xf60 fs/ocfs2/file.c:2026
       ocfs2_fallocate+0x1ee/0x240 fs/ocfs2/file.c:2141
       vfs_fallocate+0x57e/0x6f0 fs/open.c:308
       ksys_fallocate fs/open.c:331 [inline]
       __do_sys_fallocate fs/open.c:339 [inline]
       __se_sys_fallocate fs/open.c:337 [inline]
       __x64_sys_fallocate+0xbd/0x100 fs/open.c:337
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&osb->system_file_mutex);

 *** DEADLOCK ***

3 locks held by syz.0.56/4632:
 #0: ffff88801fbf2460 (sb_writers#13){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3043 [inline]
 #0: ffff88801fbf2460 (sb_writers#13){.+.+}-{0:0}, at: vfs_fallocate+0x4f1/0x6f0 fs/open.c:307
 #1: ffff88805f776d88 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805f776d88 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: __ocfs2_change_file_space+0x1d8/0xf60 fs/ocfs2/file.c:1952
 #2: ffff88805f776a20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: __ocfs2_change_file_space+0x719/0xf60 fs/ocfs2/file.c:2018

stack backtrace:
CPU: 0 PID: 4632 Comm: syz.0.56 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1e5/0x2400 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 ocfs2_get_system_file_inode+0x1a4/0x7f0 fs/ocfs2/sysfile.c:101
 ocfs2_reserve_suballoc_bits+0x12e/0x44b0 fs/ocfs2/suballoc.c:776
 ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:978
 ocfs2_reserve_new_metadata fs/ocfs2/suballoc.c:1021 [inline]
 ocfs2_lock_allocators+0x28f/0x5f0 fs/ocfs2/suballoc.c:2668
 ocfs2_extend_allocation+0x3fe/0x1830 fs/ocfs2/file.c:588
 ocfs2_allocate_unwritten_extents+0x311/0x830 fs/ocfs2/file.c:1499
 __ocfs2_change_file_space+0x7dc/0xf60 fs/ocfs2/file.c:2026
 ocfs2_fallocate+0x1ee/0x240 fs/ocfs2/file.c:2141
 vfs_fallocate+0x57e/0x6f0 fs/open.c:308
 ksys_fallocate fs/open.c:331 [inline]
 __do_sys_fallocate fs/open.c:339 [inline]
 __se_sys_fallocate fs/open.c:337 [inline]
 __x64_sys_fallocate+0xbd/0x100 fs/open.c:337
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f955ef33e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffa3cd3e18 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007f955f1acfa0 RCX: 00007f955ef33e59
RDX: 0000000000000001 RSI: 0000000000000000 RDI: 0000000000000004
RBP: 00007f955efc9e6f R08: 0000000000000000 R09: 0000000000000000
R10: 000000000008ffff R11: 0000000000000246 R12: 0000000000000000
R13: 00007f955f1acfac R14: 00007f955f1acfa0 R15: 00007f955f1acfa0
 </TASK>