KASAN: use-after-free Write in ld_usb_interrupt_in_callback

Status: closed as dup on 2019/08/12 12:22
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+a4b088ebfbadf5f82150@syzkaller.appspotmail.com
First crash: 2553d, last: 2544d
▶ ▼ Duplicate of
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported
KASAN: use-after-free Read in ld_usb_release usb 19 syz, C 14 2544d 2554d
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
KASAN: use-after-free Write in ld_usb_interrupt_in_callback 1 (2) 2019/08/12 12:22

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in ld_usb_interrupt_in_callback+0x40c/0x4c0 drivers/usb/misc/ldusb.c:276
Write of size 4 at addr ffff8881cbea215c by task udevd/338

CPU: 0 PID: 338 Comm: udevd Not tainted 5.3.0-rc4+ #26
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 print_address_description+0x6a/0x32c mm/kasan/report.c:351
 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482
 kasan_report+0xe/0x12 mm/kasan/common.c:612
 ld_usb_interrupt_in_callback+0x40c/0x4c0 drivers/usb/misc/ldusb.c:276
 __usb_hcd_giveback_urb+0x1f2/0x470 drivers/usb/core/hcd.c:1657
 usb_hcd_giveback_urb+0x368/0x420 drivers/usb/core/hcd.c:1722
 dummy_timer+0x120f/0x2fa2 drivers/usb/gadget/udc/dummy_hcd.c:1965
 call_timer_fn+0x179/0x650 kernel/time/timer.c:1322
 expire_timers kernel/time/timer.c:1366 [inline]
 __run_timers kernel/time/timer.c:1685 [inline]
 __run_timers kernel/time/timer.c:1653 [inline]
 run_timer_softirq+0x5cc/0x14b0 kernel/time/timer.c:1698
 __do_softirq+0x221/0x912 kernel/softirq.c:292
 invoke_softirq kernel/softirq.c:373 [inline]
 irq_exit+0x178/0x1a0 kernel/softirq.c:413
 exiting_irq arch/x86/include/asm/apic.h:537 [inline]
 smp_apic_timer_interrupt+0x12f/0x500 arch/x86/kernel/apic/apic.c:1095
 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:830
 </IRQ>
RIP: 0010:lock_acquire+0x16a/0x320 kernel/locking/lockdep.c:4416
Code: c1 ea 03 0f b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 95 01 00 00 c7 83 44 08 00 00 00 00 00 00 ff 34 24 9d <48> 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 65 8b 15 40 19 dc 7e
RSP: 0018:ffff8881d123f608 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13
RAX: 0000000000000007 RBX: ffff8881d110e000 RCX: 0000000000006588
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff8881d110e844
RBP: ffff8881d8677508 R08: ffffffff88d50820 R09: fffffbfff11ad39d
R10: fffffbfff11ad39c R11: ffffffff88d69ce7 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
 _raw_spin_lock+0x27/0x40 kernel/locking/spinlock.c:151
 spin_lock include/linux/spinlock.h:338 [inline]
 _atomic_dec_and_lock lib/dec_and_lock.c:28 [inline]
 _atomic_dec_and_lock+0x186/0x1e0 lib/dec_and_lock.c:21
 iput+0xbd/0x800 fs/inode.c:1578
 dentry_unlink_inode+0x2c0/0x3e0 fs/dcache.c:374
 __dentry_kill+0x378/0x5e0 fs/dcache.c:579
 shrink_dentry_list+0x14c/0x490 fs/dcache.c:1120
 shrink_dcache_parent+0x229/0x3d0 fs/dcache.c:1547
 d_invalidate fs/dcache.c:1656 [inline]
 d_invalidate+0xef/0x220 fs/dcache.c:1641
 lookup_fast+0xc29/0x1100 fs/namei.c:1622
 walk_component+0xe3/0x1bc0 fs/namei.c:1804
 lookup_last fs/namei.c:2271 [inline]
 path_lookupat.isra.0+0x1f5/0x8d0 fs/namei.c:2316
 filename_lookup+0x1b0/0x410 fs/namei.c:2346
 do_readlinkat+0xcd/0x300 fs/stat.c:399
 __do_sys_readlink fs/stat.c:432 [inline]
 __se_sys_readlink fs/stat.c:429 [inline]
 __x64_sys_readlink+0x74/0xb0 fs/stat.c:429
 do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f767af27577
Code: f0 ff ff 77 02 f3 c3 48 8b 15 bd 38 2b 00 f7 d8 64 89 02 83 c8 ff c3 90 90 90 90 90 90 90 90 90 90 90 90 b8 59 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 91 38 2b 00 31 d2 48 29 c2 64
RSP: 002b:00007ffe106fca28 EFLAGS: 00000246 ORIG_RAX: 0000000000000059
RAX: ffffffffffffffda RBX: 0000000000c00250 RCX: 00007f767af27577
RDX: 0000000000000400 RSI: 00007ffe106fca30 RDI: 00007ffe106fcf10
RBP: 0000000000c00130 R08: 7665642f7379732f R09: 616c702f73656369
R10: 75642f6d726f6674 R11: 0000000000000246 R12: 00007ffe106fcf10
R13: 0000000000000400 R14: 0000000000c00250 R15: 000000000000000b

Allocated by task 1742:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:487 [inline]
 __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460
 kmalloc include/linux/slab.h:552 [inline]
 kzalloc include/linux/slab.h:748 [inline]
 ld_usb_probe+0x6e/0xa65 drivers/usb/misc/ldusb.c:661
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

Freed by task 1742:
 save_stack+0x1b/0x80 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_slab_free+0x130/0x180 mm/kasan/common.c:449
 slab_free_hook mm/slub.c:1423 [inline]
 slab_free_freelist_hook mm/slub.c:1474 [inline]
 slab_free mm/slub.c:3016 [inline]
 kfree+0xe4/0x2f0 mm/slub.c:3957
 ld_usb_probe+0x728/0xa65 drivers/usb/misc/ldusb.c:744
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff8881cbea2000
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 348 bytes inside of
 512-byte region [ffff8881cbea2000, ffff8881cbea2200)
The buggy address belongs to the page:
page:ffffea00072fa880 refcount:1 mapcount:0 mapping:ffff8881da002500 index:0x0 compound_mapcount: 0
flags: 0x200000000010200(slab|head)
raw: 0200000000010200 ffffea00072a4780 0000000600000006 ffff8881da002500
raw: 0000000000000000 00000000000c000c 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881cbea2000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881cbea2080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8881cbea2100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                    ^
 ffff8881cbea2180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8881cbea2200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (48):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/19 11:53 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 10:19 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 08:26 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 07:16 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 04:33 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 02:38 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/19 00:41 https://github.com/google/kasan.git usb-fuzzer d0847550e22d b8ceabfc .config console log report syz C ci2-upstream-usb
2019/08/18 20:47 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 17:45 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 15:09 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 12:15 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 10:45 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 09:11 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 06:03 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 04:24 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 02:53 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/18 01:22 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/17 22:11 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/17 20:38 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/17 18:54 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/17 15:23 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 55bf8926 .config console log report syz C ci2-upstream-usb
2019/08/17 12:29 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/17 10:12 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/17 07:53 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/17 04:36 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/17 03:31 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/17 00:37 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 23:30 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 21:06 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 19:52 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 18:14 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 12:18 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 09:05 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 07:01 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 8fd428a1 .config console log report syz C ci2-upstream-usb
2019/08/16 00:58 https://github.com/google/kasan.git usb-fuzzer d0847550e22d faeffb00 .config console log report syz C ci2-upstream-usb
2019/08/15 21:56 https://github.com/google/kasan.git usb-fuzzer d0847550e22d faeffb00 .config console log report syz C ci2-upstream-usb
2019/08/15 20:35 https://github.com/google/kasan.git usb-fuzzer d0847550e22d faeffb00 .config console log report syz C ci2-upstream-usb
2019/08/15 11:15 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 0d298d6b .config console log report syz C ci2-upstream-usb
2019/08/15 09:46 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 0d298d6b .config console log report syz C ci2-upstream-usb
2019/08/15 07:55 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 0d298d6b .config console log report syz C ci2-upstream-usb
2019/08/15 04:34 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 0d298d6b .config console log report syz C ci2-upstream-usb
2019/08/13 22:50 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 74d61399 .config console log report syz C ci2-upstream-usb
2019/08/13 18:14 https://github.com/google/kasan.git usb-fuzzer d0847550e22d 74d61399 .config console log report syz C ci2-upstream-usb
2019/08/12 03:25 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report syz C ci2-upstream-usb
2019/08/11 22:38 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report syz C ci2-upstream-usb
2019/08/11 18:36 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report syz C ci2-upstream-usb
2019/08/11 07:17 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report syz C ci2-upstream-usb
2019/08/10 17:10 https://github.com/google/kasan.git usb-fuzzer e96407b49762 acb51638 .config console log report syz C ci2-upstream-usb
* Struck through repros no longer work on HEAD.