WARNING in cgroup_finalize_control

Status: fixed on 2022/03/08 16:11
Reported-by: syzbot+9c08aaa363ca5784c9e9@syzkaller.appspotmail.com
Fix commit: 7ee285395b21 cgroup: Make rebind_subsystems() disable v2 controllers all at once
First crash: 2298d, last: 1765d
Cause bisection: introduced by (bisect log) :
commit eab59075d3cd7f3535aa2dbbc19a198dfee58892
Author: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Wed Dec 28 11:26:31 2016 +0000

  sctp: reduce indent level at sctp_sf_tabort_8_4_8

Crash: WARNING in nf_unregister_net_hook (log)
Repro: syz .config
  
Fix bisection: fixed by (bisect log) :
commit 7ee285395b211cad474b2b989db52666e0430daf
Author: Waiman Long <longman@redhat.com>
Date: Sat Sep 18 22:53:08 2021 +0000

  cgroup: Make rebind_subsystems() disable v2 controllers all at once

  
▶ ▼ Duplicate bugs (1)
Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
WARNING in cgroup_apply_control_disable -1 syz done 22 2040d 2314d 0/29 closed as dup on 2021/01/21 09:28
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
WARNING in cgroup_finalize_control 2 (4) 2021/11/21 16:22
▶ ▼ Fix bisection attempts (14)
Created Duration User Patch Repo Result
2021/11/20 21:29 4h54m bisect fix upstream OK (1) job log
2021/10/21 21:09 20m bisect fix upstream OK (0) job log log
2021/09/21 20:44 24m bisect fix upstream OK (0) job log log
2021/08/21 04:52 23m bisect fix upstream OK (0) job log log
2021/07/12 07:15 19m bisect fix upstream OK (0) job log log
2021/06/12 06:51 24m bisect fix upstream OK (0) job log log
2021/05/13 06:10 30m bisect fix upstream OK (0) job log log
2021/04/12 16:54 25m bisect fix upstream OK (0) job log log
2021/03/12 05:43 24m bisect fix upstream OK (0) job log log
2021/01/20 04:40 21m bisect fix upstream OK (0) job log log
2020/12/21 04:11 22m bisect fix upstream OK (0) job log log
2020/11/13 04:44 28m bisect fix upstream OK (0) job log log
2020/10/14 01:30 29m bisect fix upstream OK (0) job log log
2020/09/04 22:01 29m bisect fix upstream OK (0) job log log

Sample crash report:
------------[ cut here ]------------
WARNING: CPU: 1 PID: 8165 at kernel/cgroup/cgroup.c:3104 cgroup_apply_control_disable kernel/cgroup/cgroup.c:3104 [inline]
WARNING: CPU: 1 PID: 8165 at kernel/cgroup/cgroup.c:3104 cgroup_finalize_control+0xb6c/0xd60 kernel/cgroup/cgroup.c:3171
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 8165 Comm: syz-executor.4 Not tainted 5.8.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1f0/0x31e lib/dump_stack.c:118
 panic+0x264/0x7a0 kernel/panic.c:231
 __warn+0x227/0x250 kernel/panic.c:600
 report_bug+0x1b1/0x2e0 lib/bug.c:198
 handle_bug+0x42/0x80 arch/x86/kernel/traps.c:235
 exc_invalid_op+0x16/0x40 arch/x86/kernel/traps.c:255
 asm_exc_invalid_op+0x12/0x20 arch/x86/include/asm/idtentry.h:547
RIP: 0010:cgroup_apply_control_disable kernel/cgroup/cgroup.c:3104 [inline]
RIP: 0010:cgroup_finalize_control+0xb6c/0xd60 kernel/cgroup/cgroup.c:3171
Code: 89 f7 ff d3 eb 08 e8 33 10 08 00 0f 1f 00 49 ff c4 49 83 fc 0d 0f 84 63 01 00 00 e8 1e 10 08 00 e9 a9 f8 ff ff e8 14 10 08 00 <0f> 0b e9 88 f9 ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c cd f8 ff
RSP: 0018:ffffc90006037bb0 EFLAGS: 00010293
RAX: ffffffff816cbdec RBX: 0000000000000002 RCX: ffff8880a6026400
RDX: 0000000000000000 RSI: 0000000000000002 RDI: 0000000000000000
RBP: ffffffff89309f30 R08: ffffffff816cb76c R09: fffffbfff16354a1
R10: fffffbfff16354a1 R11: 0000000000000000 R12: 0000000000000008
R13: ffff88808bc18000 R14: ffff88809a312400 R15: dffffc0000000000
 rebind_subsystems+0x744/0xe50 kernel/cgroup/cgroup.c:1743
 cgroup_setup_root+0x723/0xe90 kernel/cgroup/cgroup.c:1977
 cgroup1_root_to_use kernel/cgroup/cgroup-v1.c:1190 [inline]
 cgroup1_get_tree+0x7a2/0xae0 kernel/cgroup/cgroup-v1.c:1207
 vfs_get_tree+0x88/0x270 fs/super.c:1547
 do_new_mount fs/namespace.c:2875 [inline]
 do_mount+0x17e8/0x2950 fs/namespace.c:3200
 __do_sys_mount fs/namespace.c:3410 [inline]
 __se_sys_mount+0xd3/0x100 fs/namespace.c:3387
 do_syscall_64+0x73/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45f72a
Code: b8 a6 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 cd 8b fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 aa 8b fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007ffe97b23908 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffe97b23960 RCX: 000000000045f72a
RDX: 00000000004cbd9e RSI: 00000000004c18a5 RDI: 00000000004c1868
RBP: 0000000000000000 R08: 00000000004d0bb8 R09: 000000000000001c
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000418760
R13: 00007ffe97b23b88 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/08/05 18:00 upstream 442489c21923 b7129355 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/08/04 00:11 upstream bcf876870b95 196277c4 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/08/01 04:15 upstream d8b9faec54ae d895b3be .config console log report syz ci-upstream-kasan-gce-smack-root
2020/07/27 07:23 upstream 92ed30191993 51265195 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/07/05 09:08 upstream 7cc2a8ea1048 51095195 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/06/17 18:52 upstream 7ae77150d94d b9f3810b .config console log report syz ci-upstream-kasan-gce-smack-root
2020/06/01 15:55 upstream 3d77e6a8804a a0331e89 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/05/23 00:56 upstream 051143e1602d 9682898d .config console log report syz ci-upstream-kasan-gce-smack-root
2020/05/07 17:10 upstream a811c1fa0a02 98cbd87b .config console log report syz ci-upstream-kasan-gce-smack-root
* Struck through repros no longer work on HEAD.