syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.417/9076 is trying to acquire lock:
ffff88802aa762b0 (&mm->mmap_lock){++++}-{4:4}, at: mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:601

but task is already holding lock:
ffff88813ff65238 (&root->kernfs_rwsem){++++}-{4:4}, at: kernfs_fop_readdir+0x270/0x960 fs/kernfs/dir.c:1982

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       kernfs_add_one+0x41/0x5e0 fs/kernfs/dir.c:825
       kernfs_create_dir_ns+0x1a1/0x230 fs/kernfs/dir.c:1130
       sysfs_create_dir_ns+0x12f/0x2a0 fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x62c/0xce0 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x12b/0x1a0 lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x118/0x2f0 fs/btrfs/sysfs.c:2604
       btrfs_quota_enable+0x274/0x1e20 fs/btrfs/qgroup.c:1032
       btrfs_ioctl_quota_ctl+0x189/0x1f0 fs/btrfs/ioctl.c:3561
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       btrfs_quota_enable+0x2b1/0x1e20 fs/btrfs/qgroup.c:1061
       btrfs_ioctl_quota_ctl+0x189/0x1f0 fs/btrfs/ioctl.c:3561
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (btrfs_trans_num_extwriters){++++}-{0:0}:
       join_transaction+0x18a/0xc60 fs/btrfs/transaction.c:324
       start_transaction+0x73f/0x1880 fs/btrfs/transaction.c:720
       btrfs_dirty_inode+0x9f/0x190 fs/btrfs/inode.c:6259
       touch_atime+0x2f8/0x670 fs/inode.c:2330
       file_accessed include/linux/fs.h:2272 [inline]
       iterate_dir+0x37d/0x4e0 fs/readdir.c:113
       __do_sys_getdents fs/readdir.c:319 [inline]
       __se_sys_getdents+0xf1/0x270 fs/readdir.c:304
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (btrfs_trans_num_writers){++++}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5574 [inline]
       lock_release+0x199/0x3c0 kernel/locking/lockdep.c:5889
       percpu_up_read include/linux/percpu-rwsem.h:114 [inline]
       __sb_end_write include/linux/fs/super.h:14 [inline]
       sb_end_intwrite+0x26/0x190 include/linux/fs/super.h:101
       __btrfs_end_transaction+0x23f/0x640 fs/btrfs/transaction.c:1097
       btrfs_dirty_inode+0x14c/0x190 fs/btrfs/inode.c:6273
       file_update_time_flags+0x2d5/0x4b0 fs/inode.c:2485
       btrfs_page_mkwrite+0x608/0x1a50 fs/btrfs/file.c:1904
       do_page_mkwrite+0x14a/0x310 mm/memory.c:3684
       wp_page_shared mm/memory.c:4085 [inline]
       do_wp_page+0x1f32/0x3d90 mm/memory.c:4304
       handle_pte_fault mm/memory.c:6395 [inline]
       __handle_mm_fault mm/memory.c:6517 [inline]
       handle_mm_fault+0xa03/0x13f0 mm/memory.c:6686
       do_user_addr_fault+0xa4d/0x1340 arch/x86/mm/fault.c:1343
       handle_page_fault arch/x86/mm/fault.c:1483 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1536
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:595

-> #2 (sb_pagefaults#3){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_pagefault include/linux/fs/super.h:159 [inline]
       btrfs_page_mkwrite+0x32b/0x1a50 fs/btrfs/file.c:1863
       do_page_mkwrite+0x14a/0x310 mm/memory.c:3684
       wp_page_shared mm/memory.c:4085 [inline]
       do_wp_page+0x1f32/0x3d90 mm/memory.c:4304
       handle_pte_fault mm/memory.c:6395 [inline]
       __handle_mm_fault mm/memory.c:6517 [inline]
       handle_mm_fault+0xa03/0x13f0 mm/memory.c:6686
       do_user_addr_fault+0xa4d/0x1340 arch/x86/mm/fault.c:1343
       handle_page_fault arch/x86/mm/fault.c:1483 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1536
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:595

-> #1 (vm_lock){++++}-{0:0}:
       __vma_start_exclude_readers+0x283/0x930 mm/mmap_lock.c:125
       __vma_start_write+0xdc/0x290 mm/mmap_lock.c:148
       vma_start_write include/linux/mmap_lock.h:303 [inline]
       mprotect_fixup+0x761/0xb10 mm/mprotect.c:801
       setup_arg_pages+0x658/0xbd0 fs/exec.c:674
       load_elf_binary+0xc85/0x2970 fs/binfmt_elf.c:1028
       search_binary_handler fs/exec.c:1694 [inline]
       exec_binprm fs/exec.c:1726 [inline]
       bprm_execve+0x926/0x14b0 fs/exec.c:1778
       kernel_execve+0x8c3/0x9c0 fs/exec.c:1922
       try_to_run_init_process+0x13/0x60 init/main.c:1476
       kernel_init+0xad/0x1d0 init/main.c:1604
       ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #0 (&mm->mmap_lock){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_read_killable+0xa4/0x220 kernel/locking/rwsem.c:1599
       mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:601
       get_mmap_lock_carefully mm/mmap_lock.c:450 [inline]
       lock_mm_and_find_vma+0x2d6/0x340 mm/mmap_lock.c:501
       do_user_addr_fault+0x341/0x1340 arch/x86/mm/fault.c:1366
       handle_page_fault arch/x86/mm/fault.c:1483 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1536
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:595
       filldir+0x2bd/0x630 fs/readdir.c:-1
       dir_emit include/linux/fs.h:3582 [inline]
       kernfs_fop_readdir+0x583/0x960 fs/kernfs/dir.c:1999
       iterate_dir+0x2f1/0x4e0 fs/readdir.c:110
       __do_sys_getdents fs/readdir.c:319 [inline]
       __se_sys_getdents+0xf1/0x270 fs/readdir.c:304
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &mm->mmap_lock --> &fs_info->qgroup_ioctl_lock --> &root->kernfs_rwsem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(&root->kernfs_rwsem);
                               lock(&fs_info->qgroup_ioctl_lock);
                               lock(&root->kernfs_rwsem);
  rlock(&mm->mmap_lock);

 *** DEADLOCK ***

3 locks held by syz.6.417/9076:
 #0: ffff888036b52d28 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x252/0x320 fs/file.c:1259
 #1: ffff88803ddadd60 (&type->i_mutex_dir_key#6){++++}-{4:4}, at: iterate_dir+0x215/0x4e0 fs/readdir.c:103
 #2: ffff88813ff65238 (&root->kernfs_rwsem){++++}-{4:4}, at: kernfs_fop_readdir+0x270/0x960 fs/kernfs/dir.c:1982

stack backtrace:
CPU: 1 UID: 0 PID: 9076 Comm: syz.6.417 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_read_killable+0xa4/0x220 kernel/locking/rwsem.c:1599
 mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:601
 get_mmap_lock_carefully mm/mmap_lock.c:450 [inline]
 lock_mm_and_find_vma+0x2d6/0x340 mm/mmap_lock.c:501
 do_user_addr_fault+0x341/0x1340 arch/x86/mm/fault.c:1366
 handle_page_fault arch/x86/mm/fault.c:1483 [inline]
 exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1536
 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:595
RIP: 0010:filldir+0x2bd/0x630 fs/readdir.c:290
Code: 89 a6 82 ff 0f 01 cb 48 8b 44 24 20 49 89 47 08 48 bd 00 00 00 00 00 fc ff df 48 8b 44 24 40 48 89 03 8b 4c 24 04 48 8d 43 10 <66> 89 08 8b 54 24 14 80 e2 0f 89 c9 48 8d 04 0b 48 ff c8 88 10 48
RSP: 0018:ffffc90003f8fc50 EFLAGS: 00050297
RAX: 0000200000002000 RBX: 0000200000001ff0 RCX: 0000000000000028
RDX: 0000000000000002 RSI: 000000000000000d RDI: 0000000000000007
RBP: dffffc0000000000 R08: 0000000000000000 R09: 0000000000000000
R10: dffffc0000000000 R11: ffffed100232cba1 R12: ffff8880283aa0c0
R13: 000000000000000d R14: 000000000000000d R15: 0000200000001fd8
 dir_emit include/linux/fs.h:3582 [inline]
 kernfs_fop_readdir+0x583/0x960 fs/kernfs/dir.c:1999
 iterate_dir+0x2f1/0x4e0 fs/readdir.c:110
 __do_sys_getdents fs/readdir.c:319 [inline]
 __se_sys_getdents+0xf1/0x270 fs/readdir.c:304
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7f102cde59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7f0e526028 EFLAGS: 00000246 ORIG_RAX: 000000000000004e
RAX: ffffffffffffffda RBX: 00007f7f10555fa0 RCX: 00007f7f102cde59
RDX: 00000000000000b8 RSI: 0000200000001fc0 RDI: 0000000000000003
RBP: 00007f7f10363e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f7f10556038 R14: 00007f7f10555fa0 R15: 00007ffc360fb3f8
 </TASK>
----------------
Code disassembly (best guess):
   0:	89 a6 82 ff 0f 01    	mov    %esp,0x10fff82(%rsi)
   6:	cb                   	lret
   7:	48 8b 44 24 20       	mov    0x20(%rsp),%rax
   c:	49 89 47 08          	mov    %rax,0x8(%r15)
  10:	48 bd 00 00 00 00 00 	movabs $0xdffffc0000000000,%rbp
  17:	fc ff df
  1a:	48 8b 44 24 40       	mov    0x40(%rsp),%rax
  1f:	48 89 03             	mov    %rax,(%rbx)
  22:	8b 4c 24 04          	mov    0x4(%rsp),%ecx
  26:	48 8d 43 10          	lea    0x10(%rbx),%rax
* 2a:	66 89 08             	mov    %cx,(%rax) <-- trapping instruction
  2d:	8b 54 24 14          	mov    0x14(%rsp),%edx
  31:	80 e2 0f             	and    $0xf,%dl
  34:	89 c9                	mov    %ecx,%ecx
  36:	48 8d 04 0b          	lea    (%rbx,%rcx,1),%rax
  3a:	48 ff c8             	dec    %rax
  3d:	88 10                	mov    %dl,(%rax)
  3f:	48                   	rex.W