syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc4-syzkaller-00049-gb4911fb0b060 #0 Not tainted
------------------------------------------------------
syz-executor740/5826 is trying to acquire lock:
ffff88807daaa640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff88807daaa640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24e0 fs/ocfs2/localalloc.c:636

but task is already holding lock:
ffff88807da72378 (&oi->ip_xattr_sem){+.+.}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       ocfs2_xattr_set_handle+0x3b0/0x7a0 fs/ocfs2/xattr.c:3501
       ocfs2_init_security_set+0xbd/0xe0 fs/ocfs2/xattr.c:7307
       ocfs2_mknod+0x137f/0x2050 fs/ocfs2/namei.c:419
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x306/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdir fs/namei.c:4430 [inline]
       __se_sys_mkdir fs/namei.c:4428 [inline]
       __x64_sys_mkdir+0x6c/0x80 fs/namei.c:4428
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:374
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984
       ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x306/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdir fs/namei.c:4430 [inline]
       __se_sys_mkdir fs/namei.c:4428 [inline]
       __x64_sys_mkdir+0x6c/0x80 fs/namei.c:4428
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:372
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984
       ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x306/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdir fs/namei.c:4430 [inline]
       __se_sys_mkdir fs/namei.c:4428 [inline]
       __x64_sys_mkdir+0x6c/0x80 fs/namei.c:4428
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1795 [inline]
       sb_start_intwrite include/linux/fs.h:1978 [inline]
       ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370
       ocfs2_mknod+0xe93/0x2050 fs/ocfs2/namei.c:361
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x306/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdir fs/namei.c:4430 [inline]
       __se_sys_mkdir fs/namei.c:4428 [inline]
       __x64_sys_mkdir+0x6c/0x80 fs/namei.c:4428
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ocfs2_reserve_local_alloc_bits+0x125/0x24e0 fs/ocfs2/localalloc.c:636
       ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168
       ocfs2_init_xattr_set_ctxt+0x376/0x700 fs/ocfs2/xattr.c:3286
       ocfs2_xattr_set+0xb70/0x11f0 fs/ocfs2/xattr.c:3634
       __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
       vfs_setxattr+0x16b/0x2f0 fs/xattr.c:321
       ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
       ovl_make_workdir fs/overlayfs/super.c:715 [inline]
       ovl_get_workdir+0xbb7/0x1730 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1325 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1344
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1804
       do_new_mount+0x24a/0xa40 fs/namespace.c:3902
       do_mount fs/namespace.c:4239 [inline]
       __do_sys_mount fs/namespace.c:4450 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4427
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

4 locks held by syz-executor740/5826:
 #0: ffff88803559c0e0 (&type->s_umount_key#43/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970 fs/super.c:345
 #1: ffff888028202428 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:557
 #2: ffff88807da72640 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #2: ffff88807da72640 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: vfs_setxattr+0x144/0x2f0 fs/xattr.c:320
 #3: ffff88807da72378 (&oi->ip_xattr_sem){+.+.}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 1 UID: 0 PID: 5826 Comm: syz-executor740 Not tainted 6.16.0-rc4-syzkaller-00049-gb4911fb0b060 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:869 [inline]
 ocfs2_reserve_local_alloc_bits+0x125/0x24e0 fs/ocfs2/localalloc.c:636
 ocfs2_reserve_clusters_with_limit+0x1be/0xba0 fs/ocfs2/suballoc.c:1168
 ocfs2_init_xattr_set_ctxt+0x376/0x700 fs/ocfs2/xattr.c:3286
 ocfs2_xattr_set+0xb70/0x11f0 fs/ocfs2/xattr.c:3634
 __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
 vfs_setxattr+0x16b/0x2f0 fs/xattr.c:321
 ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
 ovl_make_workdir fs/overlayfs/super.c:715 [inline]
 ovl_get_workdir+0xbb7/0x1730 fs/overlayfs/super.c:827
 ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
 vfs_get_super fs/super.c:1325 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1344
 vfs_get_tree+0x8f/0x2b0 fs/super.c:1804
 do_new_mount+0x24a/0xa40 fs/namespace.c:3902
 do_mount fs/namespace.c:4239 [inline]
 __do_sys_mount fs/namespace.c:4450 [inline]
 __se_sys_mount+0x317/0x410 fs/namespace.c:4427
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f5b93343139
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd1291aef8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffd1291af00 RCX: 00007f5b93343139
RDX: 0000200000000000 RSI: 0000200000000040 RDI: 0000000000000000
RBP: 00007ffd1291af08 R08: 0000200000000200 R09: 00007f5b9330f0c0
R10: 0000000000010000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd1291b168 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
overlayfs: upper fs missing required fea