syzbot

loop0: detected capacity change from 0 to 512
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/6041 is trying to acquire lock:
ffff88803353ab98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: do_writepages+0x27a/0x600 mm/page-writeback.c:2604

but task is already holding lock:
ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:164 [inline]
ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6396 [inline]
ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: __ext4_mark_inode_dirty+0x4ba/0x870 fs/ext4/inode.c:6477

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ei->xattr_sem){++++}-{4:4}:
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
       ext4_setattr+0x875/0x2ae0 fs/ext4/inode.c:5872
       notify_change+0x6d2/0x12a0 fs/attr.c:546
       chown_common+0x54e/0x680 fs/open.c:791
       do_fchownat+0x1a7/0x200 fs/open.c:822
       __do_sys_chown fs/open.c:842 [inline]
       __se_sys_chown fs/open.c:840 [inline]
       __x64_sys_chown+0x7b/0xc0 fs/open.c:840
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x5ea/0x1410 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x394/0x6a0 fs/jbd2/transaction.c:501
       __ext4_journal_start_sb+0x195/0x690 fs/ext4/ext4_jbd2.c:115
       __ext4_journal_start fs/ext4/ext4_jbd2.h:242 [inline]
       ext4_do_writepages+0xc23/0x3cf0 fs/ext4/inode.c:2913
       ext4_writepages+0x37a/0x7d0 fs/ext4/inode.c:3025
       do_writepages+0x27a/0x600 mm/page-writeback.c:2604
       __writeback_single_inode+0x160/0xfb0 fs/fs-writeback.c:1719
       writeback_sb_inodes+0x60d/0xfa0 fs/fs-writeback.c:2015
       __writeback_inodes_wb+0xf8/0x2d0 fs/fs-writeback.c:2086
       wb_writeback+0x7f3/0xb70 fs/fs-writeback.c:2197
       wb_check_old_data_flush fs/fs-writeback.c:2301 [inline]
       wb_do_writeback fs/fs-writeback.c:2354 [inline]
       wb_workfn+0x8ca/0xbe0 fs/fs-writeback.c:2382
       process_one_work+0x9cf/0x1b70 kernel/workqueue.c:3263
       process_scheduled_works kernel/workqueue.c:3346 [inline]
       worker_thread+0x6c8/0xf10 kernel/workqueue.c:3427
       kthread+0x3c5/0x780 kernel/kthread.c:463
       ret_from_fork+0x675/0x7d0 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #0 (&sbi->s_writepages_rwsem){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:77 [inline]
       ext4_writepages_down_read fs/ext4/ext4.h:1796 [inline]
       ext4_writepages+0x224/0x7d0 fs/ext4/inode.c:3024
       do_writepages+0x27a/0x600 mm/page-writeback.c:2604
       __writeback_single_inode+0x160/0xfb0 fs/fs-writeback.c:1719
       writeback_single_inode+0x2bc/0x550 fs/fs-writeback.c:1840
       write_inode_now+0x170/0x1e0 fs/fs-writeback.c:2903
       iput_final fs/inode.c:1901 [inline]
       iput.part.0+0x487/0xb00 fs/inode.c:1966
       iput+0x35/0x40 fs/inode.c:1929
       ext4_xattr_block_set+0x67c/0x3650 fs/ext4/xattr.c:2199
       ext4_xattr_move_to_block fs/ext4/xattr.c:2664 [inline]
       ext4_xattr_make_inode_space fs/ext4/xattr.c:2739 [inline]
       ext4_expand_extra_isize_ea+0x1442/0x1ab0 fs/ext4/xattr.c:2827
       __ext4_expand_extra_isize+0x346/0x480 fs/ext4/inode.c:6356
       ext4_try_to_expand_extra_isize fs/ext4/inode.c:6399 [inline]
       __ext4_mark_inode_dirty+0x544/0x870 fs/ext4/inode.c:6477
       ext4_evict_inode+0x74e/0x18e0 fs/ext4/inode.c:254
       evict+0x3e6/0x920 fs/inode.c:810
       iput_final fs/inode.c:1914 [inline]
       iput.part.0+0x6a9/0xb00 fs/inode.c:1966
       iput+0x35/0x40 fs/inode.c:1929
       ext4_orphan_cleanup+0x731/0x11e0 fs/ext4/orphan.c:470
       __ext4_fill_super fs/ext4/super.c:5617 [inline]
       ext4_fill_super+0x8db7/0xaf70 fs/ext4/super.c:5736
       get_tree_bdev_flags+0x38c/0x620 fs/super.c:1691
       vfs_get_tree+0x8e/0x340 fs/super.c:1751
       fc_mount fs/namespace.c:1208 [inline]
       do_new_mount_fc fs/namespace.c:3651 [inline]
       do_new_mount fs/namespace.c:3727 [inline]
       path_mount+0x7b9/0x23a0 fs/namespace.c:4037
       do_mount fs/namespace.c:4050 [inline]
       __do_sys_mount fs/namespace.c:4238 [inline]
       __se_sys_mount fs/namespace.c:4215 [inline]
       __x64_sys_mount+0x293/0x310 fs/namespace.c:4215
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &sbi->s_writepages_rwsem --> jbd2_handle --> &ei->xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->xattr_sem);
                               lock(jbd2_handle);
                               lock(&ei->xattr_sem);
  rlock(&sbi->s_writepages_rwsem);

 *** DEADLOCK ***

3 locks held by syz.0.17/6041:
 #0: ffff8880335380e0 (&type->s_umount_key#27/1){+.+.}-{4:4}, at: alloc_super+0x1e3/0xb60 fs/super.c:344
 #1: ffff888033538610 (sb_internal){.+.+}-{0:0}, at: evict+0x3e6/0x920 fs/inode.c:810
 #2: ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:164 [inline]
 #2: ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:6396 [inline]
 #2: ffff88805a46ba28 (&ei->xattr_sem){++++}-{4:4}, at: __ext4_mark_inode_dirty+0x4ba/0x870 fs/ext4/inode.c:6477

stack backtrace:
CPU: 1 UID: 0 PID: 6041 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read include/linux/percpu-rwsem.h:77 [inline]
 ext4_writepages_down_read fs/ext4/ext4.h:1796 [inline]
 ext4_writepages+0x224/0x7d0 fs/ext4/inode.c:3024
 do_writepages+0x27a/0x600 mm/page-writeback.c:2604
 __writeback_single_inode+0x160/0xfb0 fs/fs-writeback.c:1719
 writeback_single_inode+0x2bc/0x550 fs/fs-writeback.c:1840
 write_inode_now+0x170/0x1e0 fs/fs-writeback.c:2903
 iput_final fs/inode.c:1901 [inline]
 iput.part.0+0x487/0xb00 fs/inode.c:1966
 iput+0x35/0x40 fs/inode.c:1929
 ext4_xattr_block_set+0x67c/0x3650 fs/ext4/xattr.c:2199
 ext4_xattr_move_to_block fs/ext4/xattr.c:2664 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2739 [inline]
 ext4_expand_extra_isize_ea+0x1442/0x1ab0 fs/ext4/xattr.c:2827
 __ext4_expand_extra_isize+0x346/0x480 fs/ext4/inode.c:6356
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6399 [inline]
 __ext4_mark_inode_dirty+0x544/0x870 fs/ext4/inode.c:6477
 ext4_evict_inode+0x74e/0x18e0 fs/ext4/inode.c:254
 evict+0x3e6/0x920 fs/inode.c:810
 iput_final fs/inode.c:1914 [inline]
 iput.part.0+0x6a9/0xb00 fs/inode.c:1966
 iput+0x35/0x40 fs/inode.c:1929
 ext4_orphan_cleanup+0x731/0x11e0 fs/ext4/orphan.c:470
 __ext4_fill_super fs/ext4/super.c:5617 [inline]
 ext4_fill_super+0x8db7/0xaf70 fs/ext4/super.c:5736
 get_tree_bdev_flags+0x38c/0x620 fs/super.c:1691
 vfs_get_tree+0x8e/0x340 fs/super.c:1751
 fc_mount fs/namespace.c:1208 [inline]
 do_new_mount_fc fs/namespace.c:3651 [inline]
 do_new_mount fs/namespace.c:3727 [inline]
 path_mount+0x7b9/0x23a0 fs/namespace.c:4037
 do_mount fs/namespace.c:4050 [inline]
 __do_sys_mount fs/namespace.c:4238 [inline]
 __se_sys_mount fs/namespace.c:4215 [inline]
 __x64_sys_mount+0x293/0x310 fs/namespace.c:4215
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2f2339066a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcd5101218 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffcd51012a0 RCX: 00007f2f2339066a
RDX: 0000200000000180 RSI: 00002000000001c0 RDI: 00007ffcd5101260
RBP: 0000200000000180 R08: 00007ffcd51012a0 R09: 0000000000800718
R10: 0000000000800718 R11: 0000000000000246 R12: 00002000000001c0
R13: 00007ffcd5101260 R14: 0000000000000473 R15: 0000200000000680
 </TASK>
------------[ cut here ]------------
EA inode 11 i_nlink=2
WARNING: CPU: 0 PID: 6041 at fs/ext4/xattr.c:1056 ext4_xattr_inode_update_ref+0x4ec/0x610 fs/ext4/xattr.c:1056
Modules linked in:
CPU: 0 UID: 0 PID: 6041 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
RIP: 0010:ext4_xattr_inode_update_ref+0x4ec/0x610 fs/ext4/xattr.c:1056
Code: df 48 8d 7b 40 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 23 01 00 00 48 8b 73 40 44 89 e2 48 c7 c7 c0 5d a8 8b e8 35 00 ed fe 90 <0f> 0b 90 90 e9 d9 fe ff ff e8 36 cb 2e ff 44 0f b6 2d 22 8b dd 0d
RSP: 0018:ffffc90003b8f178 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffff8880773cb268 RCX: ffffffff817b5ee8
RDX: ffff8880253d9e40 RSI: ffffffff817b5ef5 RDI: 0000000000000001
RBP: ffffc90003b8f240 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 000000002d2d2d2d R12: 0000000000000002
R13: 0000000000000000 R14: 1ffff92000771e32 R15: ffff8880773cb458
FS:  000055555865f500(0000) GS:ffff8881249da000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3c3d9c0440 CR3: 0000000076cc4000 CR4: 0000000000350ef0
Call Trace:
 <TASK>
 ext4_xattr_inode_dec_ref fs/ext4/xattr.c:1081 [inline]
 ext4_xattr_set_entry+0x158f/0x1f00 fs/ext4/xattr.c:1719
 ext4_xattr_ibody_set+0x3d6/0x5d0 fs/ext4/xattr.c:2268
 ext4_xattr_move_to_block fs/ext4/xattr.c:2671 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2739 [inline]
 ext4_expand_extra_isize_ea+0x148c/0x1ab0 fs/ext4/xattr.c:2827
 __ext4_expand_extra_isize+0x346/0x480 fs/ext4/inode.c:6356
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:6399 [inline]
 __ext4_mark_inode_dirty+0x544/0x870 fs/ext4/inode.c:6477
 ext4_evict_inode+0x74e/0x18e0 fs/ext4/inode.c:254
 evict+0x3e6/0x920 fs/inode.c:810
 iput_final fs/inode.c:1914 [inline]
 iput.part.0+0x6a9/0xb00 fs/inode.c:1966
 iput+0x35/0x40 fs/inode.c:1929
 ext4_orphan_cleanup+0x731/0x11e0 fs/ext4/orphan.c:470
 __ext4_fill_super fs/ext4/super.c:5617 [inline]
 ext4_fill_super+0x8db7/0xaf70 fs/ext4/super.c:5736
 get_tree_bdev_flags+0x38c/0x620 fs/super.c:1691
 vfs_get_tree+0x8e/0x340 fs/super.c:1751
 fc_mount fs/namespace.c:1208 [inline]
 do_new_mount_fc fs/namespace.c:3651 [inline]
 do_new_mount fs/namespace.c:3727 [inline]
 path_mount+0x7b9/0x23a0 fs/namespace.c:4037
 do_mount fs/namespace.c:4050 [inline]
 __do_sys_mount fs/namespace.c:4238 [inline]
 __se_sys_mount fs/namespace.c:4215 [inline]
 __x64_sys_mount+0x293/0x310 fs/namespace.c:4215
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2f2339066a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcd5101218 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffcd51012a0 RCX: 00007f2f2339066a
RDX: 0000200000000180 RSI: 00002000000001c0 RDI: 00007ffcd5101260
RBP: 0000200000000180 R08: 00007ffcd51012a0 R09: 0000000000800718
R10: 0000000000800718 R11: 0000000000000246 R12: 00002000000001c0
R13: 00007ffcd5101260 R14: 0000000000000473 R15: 0000200000000680
 </TASK>