KMSAN: uninit-value in mts_usb_probe

Status: fixed on 2019/10/27 22:28
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com
Fix commit: 177238c3d47d USB: microtek: fix info-leak at probe
First crash: 2581d, last: 2490d
▶ ▼ Discussions (9)
Title Replies (including bot) Last reply
[PATCH 4.19 00/81] 4.19.80-stable review 104 (104) 2020/09/24 13:54
[PATCH 3.16 000/136] 3.16.80-rc1 review 140 (140) 2019/12/23 14:00
[PATCH 5.3 000/112] 5.3.7-stable review 130 (130) 2019/10/18 10:12
[PATCH 4.14 00/65] 4.14.150-stable review 73 (73) 2019/10/18 09:59
[PATCH 4.9 00/92] 4.9.197-stable review 98 (98) 2019/10/18 07:56
[PATCH 4.4 00/79] 4.4.197-stable review 86 (86) 2019/10/18 07:55
Reminder: 67 active syzbot reports in usb subsystem 1 (1) 2019/10/04 03:38
[PATCH] USB: microtek: fix info-leak at probe 2 (2) 2019/10/03 08:10
KMSAN: uninit-value in mts_usb_probe 0 (1) 2019/10/02 21:50

Sample crash report:
usb 1-1: config 0 interface 235 altsetting 0 bulk endpoint 0x5 has invalid maxpacket 0
usb 1-1: New USB device found, idVendor=05da, idProduct=009a, bcdDevice=46.6b
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
microtek usb (rev 0.4.3): can only deal with bulk endpoints; endpoint 15 is not bulk.
microtek usb (rev 0.4.3): can only deal with bulk endpoints; endpoint 10 is not bulk.
microtek usb (rev 0.4.3): will this work? Command EP is not usually 5
==================================================================
BUG: KMSAN: uninit-value in mts_usb_probe+0xd1d/0xfb0 drivers/usb/image/microtek.c:754
CPU: 1 PID: 3922 Comm: kworker/1:2 Not tainted 5.2.0+ #15
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x162/0x2d0 mm/kmsan/kmsan_report.c:109
 __msan_warning+0x75/0xe0 mm/kmsan/kmsan_instr.c:294
 mts_usb_probe+0xd1d/0xfb0 drivers/usb/image/microtek.c:754
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x5853/0x7320 drivers/usb/core/hub.c:5432
 process_one_work+0x1572/0x1f00 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Uninit was stored to memory at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:187 [inline]
 kmsan_internal_chain_origin+0xcc/0x150 mm/kmsan/kmsan.c:345
 __msan_chain_origin+0x6b/0xe0 mm/kmsan/kmsan_instr.c:190
 mts_usb_probe+0xcf7/0xfb0 drivers/usb/image/microtek.c:748
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x5853/0x7320 drivers/usb/core/hub.c:5432
 process_one_work+0x1572/0x1f00 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Local variable description: ----ep_in_set@mts_usb_probe
Variable was created at:
 mts_usb_probe+0x53/0xfb0 drivers/usb/image/microtek.c:666
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
==================================================================

Crashes (29):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/02 17:53 https://github.com/google/kmsan.git master beaab8a31e0d 835dffe7 .config console log report syz C ci-upstream-kmsan-gce
2019/07/09 22:30 https://github.com/google/kmsan.git master fe36eb20e4a4 f62e1e85 .config console log report syz C ci-upstream-kmsan-gce
2019/10/08 18:01 https://github.com/google/kmsan.git master cebb918b7474 b1ebbfef .config console log report ci-upstream-kmsan-gce
2019/10/08 17:53 https://github.com/google/kmsan.git master cebb918b7474 b1ebbfef .config console log report ci-upstream-kmsan-gce
2019/10/08 12:01 https://github.com/google/kmsan.git master cebb918b7474 28ac6e64 .config console log report ci-upstream-kmsan-gce
2019/10/08 11:20 https://github.com/google/kmsan.git master cebb918b7474 28ac6e64 .config console log report ci-upstream-kmsan-gce
2019/10/04 23:00 https://github.com/google/kmsan.git master 1e76a3e537c3 f3f7d9c8 .config console log report ci-upstream-kmsan-gce
2019/10/04 21:22 https://github.com/google/kmsan.git master 1e76a3e537c3 f3f7d9c8 .config console log report ci-upstream-kmsan-gce
2019/10/04 21:22 https://github.com/google/kmsan.git master 1e76a3e537c3 f3f7d9c8 .config console log report ci-upstream-kmsan-gce
2019/10/04 14:22 https://github.com/google/kmsan.git master 1e76a3e537c3 b2f369e5 .config console log report ci-upstream-kmsan-gce
2019/10/04 14:19 https://github.com/google/kmsan.git master 1e76a3e537c3 b2f369e5 .config console log report ci-upstream-kmsan-gce
2019/10/02 23:35 https://github.com/google/kmsan.git master 1e76a3e537c3 2e29b534 .config console log report ci-upstream-kmsan-gce
2019/10/02 20:03 https://github.com/google/kmsan.git master 1e76a3e537c3 2e29b534 .config console log report ci-upstream-kmsan-gce
2019/10/02 19:23 https://github.com/google/kmsan.git master 1e76a3e537c3 2e29b534 .config console log report ci-upstream-kmsan-gce
2019/10/02 18:47 https://github.com/google/kmsan.git master 1e76a3e537c3 2e29b534 .config console log report ci-upstream-kmsan-gce
2019/10/02 12:36 https://github.com/google/kmsan.git master 1e76a3e537c3 2e29b534 .config console log report ci-upstream-kmsan-gce
2019/10/02 06:03 https://github.com/google/kmsan.git master f5f9d3ce4686 b7a87a83 .config console log report ci-upstream-kmsan-gce
2019/10/01 17:53 https://github.com/google/kmsan.git master f5f9d3ce4686 b7a87a83 .config console log report ci-upstream-kmsan-gce
2019/09/27 21:22 https://github.com/google/kmsan.git master 9baf75aa4188 d8074e0b .config console log report ci-upstream-kmsan-gce
2019/09/19 18:36 https://github.com/google/kmsan.git master cebbfdbcf2b7 eb940044 .config console log report ci-upstream-kmsan-gce
2019/09/18 17:07 https://github.com/google/kmsan.git master cebbfdbcf2b7 c2dcd700 .config console log report ci-upstream-kmsan-gce
2019/09/18 16:52 https://github.com/google/kmsan.git master cebbfdbcf2b7 c2dcd700 .config console log report ci-upstream-kmsan-gce
2019/09/18 16:51 https://github.com/google/kmsan.git master cebbfdbcf2b7 c2dcd700 .config console log report ci-upstream-kmsan-gce
2019/09/18 04:29 https://github.com/google/kmsan.git master cebbfdbcf2b7 03e0d245 .config console log report ci-upstream-kmsan-gce
2019/09/11 18:40 https://github.com/google/kmsan.git master 014077b5cd62 a60cb4cd .config console log report ci-upstream-kmsan-gce
2019/09/07 12:30 https://github.com/google/kmsan.git master 014077b5cd62 a60cb4cd .config console log report ci-upstream-kmsan-gce
2019/08/02 00:49 https://github.com/google/kmsan.git master beaab8a31e0d 835dffe7 .config console log report ci-upstream-kmsan-gce
2019/07/09 22:13 https://github.com/google/kmsan.git master fe36eb20e4a4 f62e1e85 .config console log report ci-upstream-kmsan-gce
2019/07/09 17:41 https://github.com/google/kmsan.git master fe36eb20e4a4 f62e1e85 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.