KMSAN: kernel-usb-infoleak in pcan_usb_pro_send_req

Status: fixed on 2019/08/27 17:15
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+513e4d0985298538bf9b@syzkaller.appspotmail.com
Fix commit: 30a8beeb3042 can: peak_usb: pcan_usb_fd: Fix info-leaks to USB devices
First crash: 2590d, last: 2536d
▶ ▼ Discussions (9)
Title Replies (including bot) Last reply
[PATCH 4.4 00/78] 4.4.190-stable review 91 (91) 2019/08/24 18:14
[PATCH 4.9 000/103] 4.9.190-stable review 109 (109) 2019/08/24 17:59
[PATCH 5.2 000/144] 5.2.9-stable review 153 (153) 2019/08/16 07:15
[PATCH 4.14 00/69] 4.14.139-stable review 76 (76) 2019/08/16 07:15
[PATCH 4.19 00/91] 4.19.67-stable review 106 (106) 2019/08/16 06:53
[PATCH] pcan_usb_fd: zero out the common command buffer 3 (3) 2019/08/08 19:52
KMSAN: kernel-usb-infoleak in pcan_usb_pro_send_req 9 (12) 2019/08/06 14:44
[PATCH 3/4] can: peak_usb: pcan_usb_fd: uix info-leaks to USB devices 1 (1) 2019/08/02 12:00
[PATCH] peak_usb: Fix info-leaks to USB devices 2 (2) 2019/08/02 11:45
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/08/06 13:05 20m oneukum@suse.com patch https://github.com/google/kmsan.git 41550654 OK

Sample crash report:
usb 1-1: config 0 has no interface number 0
usb 1-1: New USB device found, idVendor=0c72, idProduct=0014, bcdDevice=8b.53
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
peak_usb 1-1:0.146: PEAK-System PCAN-USB X6 v0 fw v0.0.0 (2 channels)
==================================================================
BUG: KMSAN: kernel-usb-infoleak in usb_submit_urb+0x7ef/0x1f50 drivers/usb/core/urb.c:405
CPU: 1 PID: 4948 Comm: kworker/1:2 Not tainted 5.2.0+ #15
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x162/0x2d0 mm/kmsan/kmsan_report.c:109
 kmsan_internal_check_memory+0x974/0xa80 mm/kmsan/kmsan.c:551
 kmsan_handle_urb+0x28/0x40 mm/kmsan/kmsan_hooks.c:621
 usb_submit_urb+0x7ef/0x1f50 drivers/usb/core/urb.c:405
 usb_start_wait_urb+0x143/0x410 drivers/usb/core/message.c:58
 usb_internal_control_msg drivers/usb/core/message.c:102 [inline]
 usb_control_msg+0x49f/0x7f0 drivers/usb/core/message.c:156
 pcan_usb_pro_send_req+0x26b/0x3e0 drivers/net/can/usb/peak_usb/pcan_usb_pro.c:336
 pcan_usb_fd_drv_loaded drivers/net/can/usb/peak_usb/pcan_usb_fd.c:460 [inline]
 pcan_usb_fd_init+0x16ee/0x1900 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:885
 peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:809 [inline]
 peak_usb_probe+0x1416/0x1b20 drivers/net/can/usb/peak_usb/pcan_usb_core.c:907
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x5853/0x7320 drivers/usb/core/hub.c:5432
 process_one_work+0x1572/0x1f00 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Uninit was created at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:187 [inline]
 kmsan_internal_poison_shadow+0x53/0xa0 mm/kmsan/kmsan.c:146
 kmsan_slab_alloc+0xaa/0x120 mm/kmsan/kmsan_hooks.c:175
 slab_alloc_node mm/slub.c:2771 [inline]
 slab_alloc mm/slub.c:2780 [inline]
 kmem_cache_alloc_trace+0x873/0xa50 mm/slub.c:2797
 kmalloc include/linux/slab.h:547 [inline]
 pcan_usb_fd_init+0x446/0x1900 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:844
 peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:809 [inline]
 peak_usb_probe+0x1416/0x1b20 drivers/net/can/usb/peak_usb/pcan_usb_core.c:907
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0x1344/0x1d90 drivers/base/dd.c:513
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:670
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:777
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:454
 __device_attach+0x489/0x750 drivers/base/dd.c:843
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:890
 bus_probe_device+0x131/0x390 drivers/base/bus.c:514
 device_add+0x25b5/0x2df0 drivers/base/core.c:2111
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2534
 hub_port_connect drivers/usb/core/hub.c:5089 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5204 [inline]
 port_event drivers/usb/core/hub.c:5350 [inline]
 hub_event+0x5853/0x7320 drivers/usb/core/hub.c:5432
 process_one_work+0x1572/0x1f00 kernel/workqueue.c:2269
 worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Bytes 2-15 of 16 are uninitialized
Memory access of size 16 starts at ffff888105c67800
==================================================================

Crashes (16):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/07/28 03:57 https://github.com/google/kmsan.git master beaab8a31e0d c85e1c5b .config console log report syz C ci-upstream-kmsan-gce
2019/07/02 10:02 https://github.com/google/kmsan.git master 41550654dedf cccc4302 .config console log report syz C ci-upstream-kmsan-gce
2019/08/24 23:57 https://github.com/google/kmsan.git master 61ccdad1fcdf d21c5d9d .config console log report ci-upstream-kmsan-gce
2019/08/20 17:49 https://github.com/google/kmsan.git master 61ccdad1fcdf cfc9868f .config console log report ci-upstream-kmsan-gce
2019/08/19 18:45 https://github.com/google/kmsan.git master 61ccdad1fcdf ee12860b .config console log report ci-upstream-kmsan-gce
2019/08/16 03:00 https://github.com/google/kmsan.git master 61ccdad1fcdf 8fd428a1 .config console log report ci-upstream-kmsan-gce
2019/07/31 11:53 https://github.com/google/kmsan.git master beaab8a31e0d 7c7ded69 .config console log report ci-upstream-kmsan-gce
2019/07/29 18:49 https://github.com/google/kmsan.git master beaab8a31e0d f67095ee .config console log report ci-upstream-kmsan-gce
2019/07/29 18:49 https://github.com/google/kmsan.git master beaab8a31e0d f67095ee .config console log report ci-upstream-kmsan-gce
2019/07/26 10:43 https://github.com/google/kmsan.git master beaab8a31e0d 3e5d1beb .config console log report ci-upstream-kmsan-gce
2019/07/22 07:41 https://github.com/google/kmsan.git master beaab8a31e0d b3c615f5 .config console log report ci-upstream-kmsan-gce
2019/07/17 18:06 https://github.com/google/kmsan.git master beaab8a31e0d f613a7c4 .config console log report ci-upstream-kmsan-gce
2019/07/17 04:11 https://github.com/google/kmsan.git master 7280182c67ba 0d10349c .config console log report ci-upstream-kmsan-gce
2019/07/17 04:00 https://github.com/google/kmsan.git master 7280182c67ba 0d10349c .config console log report ci-upstream-kmsan-gce
2019/07/09 19:39 https://github.com/google/kmsan.git master fe36eb20e4a4 f62e1e85 .config console log report ci-upstream-kmsan-gce
2019/07/02 03:33 https://github.com/google/kmsan.git master 41550654dedf cccc4302 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.