syzbot


possible deadlock in btrfs_dirty_inode (2)

Status: upstream: reported on 2024/12/16 02:12
Subsystems: btrfs
[Documentation on labels]
Reported-by: syzbot+415a049af48761105c01@syzkaller.appspotmail.com
First crash: 156d, last: 1d13h
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [btrfs?] possible deadlock in btrfs_dirty_inode (2) 0 (1) 2024/12/16 02:12
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in btrfs_dirty_inode (2) 2 336d 398d 0/3 auto-obsoleted due to no activity on 2024/09/22 15:54
linux-5.15 possible deadlock in btrfs_dirty_inode (3) origin:lts-only C inconclusive 4 46d 158d 0/3 upstream: reported C repro on 2024/12/09 11:33
linux-5.15 possible deadlock in btrfs_dirty_inode 3 696d 715d 0/3 auto-obsoleted due to no activity on 2023/09/28 23:24
upstream possible deadlock in btrfs_dirty_inode btrfs C error done 48 902d 914d 0/28 auto-obsoleted due to no activity on 2023/05/16 05:18

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc6-syzkaller-00105-g088d13246a46 #0 Not tainted
------------------------------------------------------
syz.2.1006/14351 is trying to acquire lock:
ffff8880685b0610 (sb_internal#2){.+.+}-{0:0}, at: btrfs_dirty_inode+0x9f/0x190 fs/btrfs/inode.c:6136

but task is already holding lock:
ffff8880685b0518 (sb_pagefaults#8){.+.+}-{0:0}, at: do_page_mkwrite+0x14a/0x310 mm/memory.c:3287

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (sb_pagefaults#8){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1783 [inline]
       sb_start_pagefault include/linux/fs.h:1948 [inline]
       btrfs_page_mkwrite+0x3b2/0x16a0 fs/btrfs/file.c:1798
       do_page_mkwrite+0x14a/0x310 mm/memory.c:3287
       wp_page_shared mm/memory.c:3688 [inline]
       do_wp_page+0x2626/0x5760 mm/memory.c:3907
       handle_pte_fault mm/memory.c:6013 [inline]
       __handle_mm_fault+0x1028/0x5380 mm/memory.c:6140
       handle_mm_fault+0x2d5/0x7f0 mm/memory.c:6309
       do_user_addr_fault+0xa81/0x1390 arch/x86/mm/fault.c:1337
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x68/0x110 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #6 (vm_lock){++++}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       __vma_enter_locked+0x182/0x380 mm/memory.c:6473
       __vma_start_write+0x1e/0x120 mm/memory.c:6497
       vma_start_write include/linux/mm.h:829 [inline]
       mprotect_fixup+0x571/0x9b0 mm/mprotect.c:670
       setup_arg_pages+0x53a/0xaa0 fs/exec.c:780
       load_elf_binary+0xb71/0x27a0 fs/binfmt_elf.c:1020
       search_binary_handler fs/exec.c:1778 [inline]
       exec_binprm fs/exec.c:1810 [inline]
       bprm_execve+0x999/0x1440 fs/exec.c:1862
       kernel_execve+0x8f0/0x9f0 fs/exec.c:2028
       try_to_run_init_process+0x13/0x60 init/main.c:1385
       kernel_init+0xad/0x1d0 init/main.c:1513
       ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #5 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read_killable+0x50/0x350 kernel/locking/rwsem.c:1547
       mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:193
       get_mmap_lock_carefully mm/memory.c:6355 [inline]
       lock_mm_and_find_vma+0x2a8/0x300 mm/memory.c:6406
       do_user_addr_fault+0x331/0x1390 arch/x86/mm/fault.c:1360
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x68/0x110 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
       user_access_begin arch/x86/include/asm/uaccess.h:-1 [inline]
       filldir+0x299/0x690 fs/readdir.c:286
       dir_emit include/linux/fs.h:3861 [inline]
       kernfs_fop_readdir+0x534/0x870 fs/kernfs/dir.c:1907
       iterate_dir+0x5ac/0x770 fs/readdir.c:108
       __do_sys_getdents fs/readdir.c:322 [inline]
       __se_sys_getdents+0xe4/0x250 fs/readdir.c:308
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (&root->kernfs_rwsem){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       kernfs_add_one+0x41/0x520 fs/kernfs/dir.c:791
       kernfs_create_dir_ns+0xde/0x130 fs/kernfs/dir.c:1091
       sysfs_create_dir_ns+0x123/0x280 fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x59f/0xb40 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x125/0x190 lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x111/0x2b0 fs/btrfs/sysfs.c:2616
       btrfs_quota_enable+0x278/0x1d50 fs/btrfs/qgroup.c:1030
       btrfs_ioctl_quota_ctl+0x183/0x1c0 fs/btrfs/ioctl.c:3676
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:746
       btrfs_quota_enable+0x2be/0x1d50 fs/btrfs/qgroup.c:1059
       btrfs_ioctl_quota_ctl+0x183/0x1c0 fs/btrfs/ioctl.c:3676
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (btrfs_trans_num_extwriters){++++}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       join_transaction+0x1a4/0xd70 fs/btrfs/transaction.c:321
       start_transaction+0x6ae/0x1620 fs/btrfs/transaction.c:705
       _btrfs_ioctl_set_received_subvol+0x153/0xae0 fs/btrfs/ioctl.c:4018
       btrfs_ioctl_set_received_subvol+0x8d/0x100 fs/btrfs/ioctl.c:4134
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (btrfs_trans_num_writers){++++}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       join_transaction+0x182/0xd70 fs/btrfs/transaction.c:320
       start_transaction+0x6ae/0x1620 fs/btrfs/transaction.c:705
       _btrfs_ioctl_set_received_subvol+0x153/0xae0 fs/btrfs/ioctl.c:4018
       btrfs_ioctl_set_received_subvol+0x8d/0x100 fs/btrfs/ioctl.c:4134
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1783 [inline]
       sb_start_intwrite include/linux/fs.h:1966 [inline]
       start_transaction+0x566/0x1620 fs/btrfs/transaction.c:699
       btrfs_dirty_inode+0x9f/0x190 fs/btrfs/inode.c:6136
       inode_update_time fs/inode.c:2076 [inline]
       __file_update_time fs/inode.c:2305 [inline]
       file_update_time+0x344/0x490 fs/inode.c:2335
       btrfs_page_mkwrite+0x634/0x16a0 fs/btrfs/file.c:1814
       do_page_mkwrite+0x14a/0x310 mm/memory.c:3287
       wp_page_shared mm/memory.c:3688 [inline]
       do_wp_page+0x2626/0x5760 mm/memory.c:3907
       handle_pte_fault mm/memory.c:6013 [inline]
       __handle_mm_fault+0x1028/0x5380 mm/memory.c:6140
       handle_mm_fault+0x2d5/0x7f0 mm/memory.c:6309
       do_user_addr_fault+0xa81/0x1390 arch/x86/mm/fault.c:1337
       handle_page_fault arch/x86/mm/fault.c:1480 [inline]
       exc_page_fault+0x68/0x110 arch/x86/mm/fault.c:1538
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> vm_lock --> sb_pagefaults#8

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(sb_pagefaults#8);
                               lock(vm_lock);
                               lock(sb_pagefaults#8);
  rlock(sb_internal#2);

 *** DEADLOCK ***

2 locks held by syz.2.1006/14351:
 #0: ffff8880280d9a88 (vm_lock){++++}-{0:0}, at: do_user_addr_fault+0x2d9/0x1390 arch/x86/mm/fault.c:1328
 #1: ffff8880685b0518 (sb_pagefaults#8){.+.+}-{0:0}, at: do_page_mkwrite+0x14a/0x310 mm/memory.c:3287

stack backtrace:
CPU: 0 UID: 0 PID: 14351 Comm: syz.2.1006 Not tainted 6.15.0-rc6-syzkaller-00105-g088d13246a46 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
 __sb_start_write include/linux/fs.h:1783 [inline]
 sb_start_intwrite include/linux/fs.h:1966 [inline]
 start_transaction+0x566/0x1620 fs/btrfs/transaction.c:699
 btrfs_dirty_inode+0x9f/0x190 fs/btrfs/inode.c:6136
 inode_update_time fs/inode.c:2076 [inline]
 __file_update_time fs/inode.c:2305 [inline]
 file_update_time+0x344/0x490 fs/inode.c:2335
 btrfs_page_mkwrite+0x634/0x16a0 fs/btrfs/file.c:1814
 do_page_mkwrite+0x14a/0x310 mm/memory.c:3287
 wp_page_shared mm/memory.c:3688 [inline]
 do_wp_page+0x2626/0x5760 mm/memory.c:3907
 handle_pte_fault mm/memory.c:6013 [inline]
 __handle_mm_fault+0x1028/0x5380 mm/memory.c:6140
 handle_mm_fault+0x2d5/0x7f0 mm/memory.c:6309
 do_user_addr_fault+0xa81/0x1390 arch/x86/mm/fault.c:1337
 handle_page_fault arch/x86/mm/fault.c:1480 [inline]
 exc_page_fault+0x68/0x110 arch/x86/mm/fault.c:1538
 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
RIP: 0033:0x7f53ab5566d8
Code: fc 89 37 c3 c5 fa 6f 06 c5 fa 6f 4c 16 f0 c5 fa 7f 07 c5 fa 7f 4c 17 f0 c3 66 0f 1f 84 00 00 00 00 00 48 8b 4c 16 f8 48 8b 36 <48> 89 37 48 89 4c 17 f8 c3 c5 fe 6f 54 16 e0 c5 fe 6f 5c 16 c0 c5
RSP: 002b:00007ffef29d89f8 EFLAGS: 00010246
RAX: 0000200000000040 RBX: 0000000000000004 RCX: 0030656c69662f2e
RDX: 0000000000000008 RSI: 0030656c69662f2e RDI: 0000200000000040
RBP: 00007f53ab7b7ba0 R08: 00007f53ab400000 R09: 0000000000000001
R10: 0000000000000001 R11: 0000000000000009 R12: 00007f53ab7b5fac
R13: 00007f53ab7b5fa0 R14: fffffffffffffffe R15: 00007ffef29d8b10
 </TASK>

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/05/15 17:49 upstream 088d13246a46 cfde8269 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in btrfs_dirty_inode
2025/05/06 10:47 upstream 01f95500a162 ae98e6b9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in btrfs_dirty_inode
2025/04/10 05:55 upstream 3b07108ada81 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in btrfs_dirty_inode
2025/01/09 05:00 upstream 0b7958fa05d5 f3558dbf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in btrfs_dirty_inode
2024/12/26 22:14 upstream d6ef8b40d075 d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in btrfs_dirty_inode
2024/12/12 02:06 upstream 231825b2e1ff ff949d25 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in btrfs_dirty_inode
* Struck through repros no longer work on HEAD.