syzbot

8021q: adding VLAN 0 to HW filter on device team0
A link change request failed with some changes committed already. Interface caif0 may have been left with an inconsistent configuration, please check.
============================================
WARNING: possible recursive locking detected
6.4.0-rc5-syzkaller-00002-gf8dba31b0a82 #0 Not tainted
--------------------------------------------
syz-executor365/5115 is trying to acquire lock:
ffff88807da44218 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline]
ffff88807da44218 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_xmit_skb net/core/dev.c:3835 [inline]
ffff88807da44218 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_queue_xmit+0x20bb/0x38b0 net/core/dev.c:4210

but task is already holding lock:
ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: spin_trylock include/linux/spinlock.h:360 [inline]
ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: qdisc_run_begin include/net/sch_generic.h:187 [inline]
ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_xmit_skb net/core/dev.c:3792 [inline]
ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_queue_xmit+0x1163/0x38b0 net/core/dev.c:4210

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(dev->qdisc_tx_busylock ?: &qdisc_tx_busylock);
  lock(dev->qdisc_tx_busylock ?: &qdisc_tx_busylock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

8 locks held by syz-executor365/5115:
 #0: ffffffff8cf27520 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x40 include/linux/rcupdate.h:326
 #1: ffffffff8cf27580 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire+0x9/0x40 include/linux/rcupdate.h:327
 #2: ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: spin_trylock include/linux/spinlock.h:360 [inline]
 #2: ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: qdisc_run_begin include/net/sch_generic.h:187 [inline]
 #2: ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_xmit_skb net/core/dev.c:3792 [inline]
 #2: ffff88807d631258 (dev->qdisc_tx_busylock ?: &qdisc_tx_busylock){+...}-{2:2}, at: __dev_queue_xmit+0x1163/0x38b0 net/core/dev.c:4210
 #3: ffff88807d7c78d8 (_xmit_ETHER#2){+.-.}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline]
 #3: ffff88807d7c78d8 (_xmit_ETHER#2){+.-.}-{2:2}, at: __netif_tx_lock include/linux/netdevice.h:4366 [inline]
 #3: ffff88807d7c78d8 (_xmit_ETHER#2){+.-.}-{2:2}, at: sch_direct_xmit+0x1c4/0x5f0 net/sched/sch_generic.c:340
 #4: ffff88814b0287f0 (k-slock-AF_INET6){+...}-{2:2}, at: spin_trylock include/linux/spinlock.h:360 [inline]
 #4: ffff88814b0287f0 (k-slock-AF_INET6){+...}-{2:2}, at: icmpv6_xmit_lock net/ipv6/icmp.c:108 [inline]
 #4: ffff88814b0287f0 (k-slock-AF_INET6){+...}-{2:2}, at: icmp6_send+0xbcf/0x20e0 net/ipv6/icmp.c:542
 #5: ffffffff8cf27520 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x40 include/linux/rcupdate.h:326
 #6: ffffffff8cf27520 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x40 include/linux/rcupdate.h:326
 #7: ffffffff8cf27580 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire+0x9/0x40 include/linux/rcupdate.h:327

stack backtrace:
CPU: 1 PID: 5115 Comm: syz-executor365 Not tainted 6.4.0-rc5-syzkaller-00002-gf8dba31b0a82 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:3006 [inline]
 check_deadlock kernel/locking/lockdep.c:3049 [inline]
 validate_chain+0x473a/0x58f0 kernel/locking/lockdep.c:3834
 __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
 _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154
 spin_lock include/linux/spinlock.h:350 [inline]
 __dev_xmit_skb net/core/dev.c:3835 [inline]
 __dev_queue_xmit+0x20bb/0x38b0 net/core/dev.c:4210
 dev_queue_xmit include/linux/netdevice.h:3085 [inline]
 neigh_hh_output include/net/neighbour.h:528 [inline]
 neigh_output include/net/neighbour.h:542 [inline]
 ip6_finish_output2+0xf42/0x1560 net/ipv6/ip6_output.c:134
 __ip6_finish_output net/ipv6/ip6_output.c:195 [inline]
 ip6_finish_output+0x6b0/0xa80 net/ipv6/ip6_output.c:206
 ip6_send_skb+0x12f/0x250 net/ipv6/ip6_output.c:1989
 icmp6_send+0x15fd/0x20e0 net/ipv6/icmp.c:621
 __icmpv6_send include/linux/icmpv6.h:28 [inline]
 icmpv6_send include/linux/icmpv6.h:49 [inline]
 ip6_link_failure+0x3b/0x4a0 net/ipv6/route.c:2785
 ip_tunnel_xmit+0x160a/0x2920 net/ipv4/ip_tunnel.c:837
 __gre_xmit net/ipv4/ip_gre.c:469 [inline]
 erspan_xmit+0xad8/0x1540 net/ipv4/ip_gre.c:715
 __netdev_start_xmit include/linux/netdevice.h:4915 [inline]
 netdev_start_xmit include/linux/netdevice.h:4929 [inline]
 xmit_one net/core/dev.c:3578 [inline]
 dev_hard_start_xmit+0x241/0x750 net/core/dev.c:3594
 sch_direct_xmit+0x2b6/0x5f0 net/sched/sch_generic.c:342
 __dev_xmit_skb net/core/dev.c:3805 [inline]
 __dev_queue_xmit+0x18d2/0x38b0 net/core/dev.c:4210
 dev_queue_xmit include/linux/netdevice.h:3085 [inline]
 neigh_hh_output include/net/neighbour.h:528 [inline]
 neigh_output include/net/neighbour.h:542 [inline]
 ip6_finish_output2+0xf42/0x1560 net/ipv6/ip6_output.c:134
 __ip6_finish_output net/ipv6/ip6_output.c:195 [inline]
 ip6_finish_output+0x6b0/0xa80 net/ipv6/ip6_output.c:206
 ip6_send_skb+0x12f/0x250 net/ipv6/ip6_output.c:1989
 udp_v6_send_skb+0xba2/0x1840 net/ipv6/udp.c:1296
 udpv6_sendmsg+0x220d/0x3060 net/ipv6/udp.c:1590
 sock_sendmsg_nosec net/socket.c:724 [inline]
 sock_sendmsg net/socket.c:747 [inline]
 ____sys_sendmsg+0x58f/0x890 net/socket.c:2503
 ___sys_sendmsg net/socket.c:2557 [inline]
 __sys_sendmmsg+0x3af/0x730 net/socket.c:2643
 __do_sys_sendmmsg net/socket.c:2672 [inline]
 __se_sys_sendmmsg net/socket.c:2669 [inline]
 __x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2669
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f00d9e89fe9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe3f225968 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f00d9e89fe9
RDX: 00000000040000e2 RSI: 0000000020002240 RDI: 0000000000000009
RBP: 0000000000000000 R08: 000000000000000d R09: 000000000000000d
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffe3f225980
R13: 00000000000f4240 R14: 000000000001ba14 R15: 00007ffe3f225974
 </TASK>