syzbot

BTRFS info (device loop6): using sha256 checksum algorithm
BTRFS info (device loop6): enabling ssd optimizations
BTRFS info (device loop6): turning on async discard
BTRFS info (device loop6): enabling free space tree
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.1118/15734 is trying to acquire lock:
ffff888032942360 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}, at: btrfs_quota_enable+0x2b1/0x1e20 fs/btrfs/qgroup.c:1061

but task is already holding lock:
ffff8880329431b8 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x14c/0xc60 fs/btrfs/transaction.c:323

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (btrfs_trans_num_extwriters){++++}-{0:0}:
       join_transaction+0x18a/0xc60 fs/btrfs/transaction.c:324
       start_transaction+0x73f/0x1880 fs/btrfs/transaction.c:720
       btrfs_dirty_inode+0x9f/0x190 fs/btrfs/inode.c:6259
       touch_atime+0x2f8/0x670 fs/inode.c:2330
       file_accessed include/linux/fs.h:2272 [inline]
       filemap_read+0x1005/0x11e0 mm/filemap.c:2886
       __kernel_read+0x4d3/0x970 fs/read_write.c:532
       integrity_kernel_read+0x89/0xd0 security/integrity/iint.c:28
       ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:222 [inline]
       ima_calc_file_hash+0x45d/0x8a0 security/integrity/ima/ima_crypto.c:280
       ima_collect_measurement+0x521/0xa10 security/integrity/ima/ima_api.c:300
       process_measurement+0x1282/0x1c20 security/integrity/ima/ima_main.c:425
       ima_file_check+0xe1/0x130 security/integrity/ima/ima_main.c:685
       security_file_post_open+0xb3/0x260 security/security.c:2755
       do_open fs/namei.c:4702 [inline]
       path_openat+0x2eac/0x3850 fs/namei.c:4859
       do_file_open+0x23e/0x4a0 fs/namei.c:4888
       do_sys_openat2+0x115/0x200 fs/open.c:1368
       do_sys_open fs/open.c:1374 [inline]
       __do_sys_openat fs/open.c:1390 [inline]
       __se_sys_openat fs/open.c:1385 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1385
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (btrfs_trans_num_writers){++++}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5574 [inline]
       lock_release+0x199/0x3c0 kernel/locking/lockdep.c:5889
       percpu_up_read include/linux/percpu-rwsem.h:114 [inline]
       __sb_end_write include/linux/fs/super.h:14 [inline]
       sb_end_intwrite+0x26/0x190 include/linux/fs/super.h:101
       __btrfs_end_transaction+0x23f/0x640 fs/btrfs/transaction.c:1097
       btrfs_dirty_inode+0x14c/0x190 fs/btrfs/inode.c:6273
       touch_atime+0x2f8/0x670 fs/inode.c:2330
       file_accessed include/linux/fs.h:2272 [inline]
       btrfs_file_mmap_prepare+0x189/0x200 fs/btrfs/file.c:2029
       vfs_mmap_prepare include/linux/fs.h:2071 [inline]
       call_mmap_prepare mm/vma.c:2672 [inline]
       __mmap_region mm/vma.c:2758 [inline]
       mmap_region+0xe78/0x2310 mm/vma.c:2860
       do_mmap+0xc1e/0x10b0 mm/mmap.c:560
       vm_mmap_pgoff+0x275/0x4e0 mm/util.c:581
       ksys_mmap_pgoff+0x4a6/0x720 mm/mmap.c:606
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&mm->mmap_lock){++++}-{4:4}:
       down_read_killable+0xa4/0x220 kernel/locking/rwsem.c:1599
       mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:601
       get_mmap_lock_carefully mm/mmap_lock.c:450 [inline]
       lock_mm_and_find_vma+0x2d6/0x340 mm/mmap_lock.c:501
       do_user_addr_fault+0x341/0x1340 arch/x86/mm/fault.c:1366
       handle_page_fault arch/x86/mm/fault.c:1483 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1536
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:595
       filldir+0x2bd/0x630 fs/readdir.c:-1
       dir_emit include/linux/fs.h:3582 [inline]
       kernfs_fop_readdir+0x583/0x960 fs/kernfs/dir.c:1999
       iterate_dir+0x2f1/0x4e0 fs/readdir.c:110
       __do_sys_getdents fs/readdir.c:319 [inline]
       __se_sys_getdents+0xf1/0x270 fs/readdir.c:304
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       kernfs_add_one+0x41/0x5e0 fs/kernfs/dir.c:825
       kernfs_create_dir_ns+0x1a1/0x230 fs/kernfs/dir.c:1130
       sysfs_create_dir_ns+0x12f/0x2a0 fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x62c/0xce0 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x12b/0x1a0 lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x118/0x2f0 fs/btrfs/sysfs.c:2604
       btrfs_quota_enable+0x274/0x1e20 fs/btrfs/qgroup.c:1032
       btrfs_ioctl_quota_ctl+0x189/0x1f0 fs/btrfs/ioctl.c:3561
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
       btrfs_quota_enable+0x2b1/0x1e20 fs/btrfs/qgroup.c:1061
       btrfs_ioctl_quota_ctl+0x189/0x1f0 fs/btrfs/ioctl.c:3561
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &fs_info->qgroup_ioctl_lock --> btrfs_trans_num_writers --> btrfs_trans_num_extwriters

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(btrfs_trans_num_extwriters);
                               lock(btrfs_trans_num_writers);
                               lock(btrfs_trans_num_extwriters);
  lock(&fs_info->qgroup_ioctl_lock);

 *** DEADLOCK ***

5 locks held by syz.6.1118/15734:
 #0: ffff88802af60500 (sb_writers#22){.+.+}-{0:0}, at: mnt_want_write_file+0x63/0x210 fs/namespace.c:538
 #1: ffff8880329411b8 (&fs_info->subvol_sem){+.+.}-{4:4}, at: btrfs_ioctl_quota_ctl+0x17e/0x1f0 fs/btrfs/ioctl.c:3560
 #2: ffff88802af607f0 (sb_internal#3){.+.+}-{0:0}, at: btrfs_quota_enable+0x2a4/0x1e20 fs/btrfs/qgroup.c:1059
 #3: ffff888032943190 (btrfs_trans_num_writers){++++}-{0:0}, at: join_transaction+0x14c/0xc60 fs/btrfs/transaction.c:323
 #4: ffff8880329431b8 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x14c/0xc60 fs/btrfs/transaction.c:323

stack backtrace:
CPU: 0 UID: 0 PID: 15734 Comm: syz.6.1118 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 __mutex_lock_common kernel/locking/rtmutex_api.c:559 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:578
 btrfs_quota_enable+0x2b1/0x1e20 fs/btrfs/qgroup.c:1061
 btrfs_ioctl_quota_ctl+0x189/0x1f0 fs/btrfs/ioctl.c:3561
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:597 [inline]
 __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe1fe02ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe1fc286028 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fe1fe2a5fa0 RCX: 00007fe1fe02ce59
RDX: 0000200000000580 RSI: 00000000c0109428 RDI: 0000000000000003
RBP: 00007fe1fe0c2e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe1fe2a6038 R14: 00007fe1fe2a5fa0 R15: 00007ffc8a997328
 </TASK>