possible deadlock in shrinker_free

Status: upstream: reported on 2026/11/20 16:12
Subsystems: ocfs2
Labels: prio:low
[Documentation on labels]
Reported-by: syzbot+38fdbb551940270021f1@syzkaller.appspotmail.com
First crash: 1d00h, last: 8h28m
✨ AI cause bisection: introduced by (AI job) :
commit f277230d002d03ed98b814b735f9d3d01b42020a
Author: Cen Zhang <zzzccc427@gmail.com>
Date: Fri Oct 30 04:48:56 2026 +0000

  ocfs2: serialize inode journal access with shutdown

✨ AI-generated root cause summary:

ocfs2_journal_shutdown() holds down_write(&osb->journal_shutdown_sem) across jbd2_journal_destroy(), which invokes shrinker_free() and acquires shrinker_mutex, establishing &osb->journal_shutdown_sem -> shrinker_mutex. Meanwhile, shrinker_mutex is held across GFP_KERNEL allocations (e.g., alloc_shrinker_info()), establishing shrinker_mutex -> fs_reclaim, and memory reclaim can reach ocfs2_evict_inode() / ocfs2_clear_inode() via super_cache_scan() and acquire down_read(&osb->journal_shutdown_sem), establishing fs_reclaim -> &osb->journal_shutdown_sem. Lockdep reports this 3-lock cycle as a circular locking dependency because it does not track the mutual exclusion provided by sb->s_umount via super_trylock_shared().

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 4405c18c95d2:

Root Cause Analysis

Lockdep reports a 3-lock circular dependency cycle:

shrinker_mutex -> fs_reclaim -> &osb->journal_shutdown_sem -> shrinker_mutex

1. &osb->journal_shutdown_sem -> shrinker_mutex

During unmount (cleanup_mnt() -> deactivate_locked_super() -> kill_block_super() -> generic_shutdown_super() -> ocfs2_put_super() -> ocfs2_dismount_volume()), or during mount error cleanup in ocfs2_fill_super() / ocfs2_mount_volume(), OCFS2 calls ocfs2_journal_shutdown() (fs/ocfs2/journal.c:1064).

In ocfs2_journal_shutdown():

  • down_write(&osb->journal_shutdown_sem) is acquired at fs/ocfs2/journal.c:1122 to exclude concurrent jbd2_journal_release_jbd_inode() calls in ocfs2_clear_inode() while osb->journal and its underlying journal_t (journal->j_journal) are being torn down.
  • While still holding osb->journal_shutdown_sem in write mode, it calls jbd2_journal_destroy(journal->j_journal) (fs/ocfs2/journal.c:1125).
  • jbd2_journal_destroy() (fs/jbd2/journal.c:2178) calls shrinker_free(journal->j_shrinker).
  • shrinker_free() (mm/shrinker.c:809) acquires mutex_lock(&shrinker_mutex).

2. shrinker_mutex -> fs_reclaim

mm/shrinker.c acquires shrinker_mutex around GFP_KERNEL allocations (which acquire the fs_reclaim pseudo-lock), for example in alloc_shrinker_info() (mm/shrinker.c:98-102) during mem_cgroup_css_online(), as well as in shrinker_memcg_alloc() (mm/shrinker.c:244-245) and shrinker_register() (mm/shrinker.c:765-768). This is the standard ordering in mm/shrinker.c (shrink_slab() avoids taking shrinker_mutex and instead uses RCU + shrinker_try_get()).

3. fs_reclaim -> &osb->journal_shutdown_sem

During memory reclaim (fs_reclaim), do_shrink_slab() invokes super_cache_scan() (fs/super.c:181), which calls prune_dcache_sb() / prune_icache_sb(), leading to dentry_kill() -> ocfs2_dentry_iput() -> evict() -> ocfs2_evict_inode() -> ocfs2_clear_inode() (fs/ocfs2/inode.c:1227).

At fs/ocfs2/inode.c:1326, ocfs2_clear_inode() acquires down_read(&osb->journal_shutdown_sem) to check osb->journal and call jbd2_journal_release_jbd_inode(osb->journal->j_journal, &oi->ip_jinode).

Why Lockdep Triggers (and Role of sb->s_umount)

  • In super_cache_scan() (fs/super.c:200), super_trylock_shared(sb) (fs/super.c:640) attempts down_read_trylock(&sb->s_umount) and checks !(sb->s_flags & SB_DYING) && sb->s_root && (sb->s_flags & SB_BORN) before pruning dentries or inodes.
  • Both callers of ocfs2_journal_shutdown() (ocfs2_dismount_volume() and ocfs2_mount_volume()) execute with sb->s_umount held exclusively (down_write), preventing super_cache_scan() from entering ocfs2_clear_inode() for that same osb while osb->journal_shutdown_sem is write-locked.
  • Because down_read_trylock(&sb->s_umount) is a trylock, lockdep does not record fs_reclaim -> s_umount as a dependency edge and does not model that sb->s_umount mutually excludes ocfs2_journal_shutdown() from running concurrently with super_cache_scan() on the same superblock; additionally, lockdep tracks &osb->journal_shutdown_sem by class rather than per-osb instance.

Fix Considerations

To eliminate the lockdep inversion in fs/ocfs2/journal.c / fs/ocfs2/inode.c:

  • ocfs2_journal_shutdown() only needs &osb->journal_shutdown_sem to synchronize osb->journal = NULL / freeing journal->j_journal against ocfs2_clear_inode(), or jbd2_journal_destroy() (or shrinker_free(journal->j_shrinker)) should not be invoked while holding osb->journal_shutdown_sem if journal_shutdown_sem is also taken in inode eviction (ocfs2_clear_inode()). Note that generic_shutdown_super() already runs shrink_dcache_for_umount() and evict_inodes() before ocfs2_put_super() -> ocfs2_dismount_volume(), and ocfs2_journal_shutdown() already holds an extra igrab(inode) reference on journal->j_inode until after up_write(&osb->journal_shutdown_sem) (fs/ocfs2/journal.c:1153-1156).
▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
32453606 assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ❌ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ possible deadlock in shrinker_free 2026/11/19 17:21 2026/11/19 17:21 2026/11/19 17:57 229865fb
0e68af1a bisect-cause IsRelease: ❌ ❓ possible deadlock in shrinker_free 2026/11/19 17:18 2026/11/19 17:18 2026/11/19 17:56 229865fb
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ocfs2?] possible deadlock in shrinker_free 0 (1) 2026/11/20 16:12

Sample crash report:
loop0: detected capacity change from 0 to 32768
(syz.0.0,5351,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
(syz.0.0,5351,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
(syz.0.0,5351,0):ocfs2_read_blocks_sync:112 ERROR: status = -12
(syz.0.0,5351,0):update_backups:196 ERROR: status = -12
ocfs2: Failed to update super blocks on 7,0 during fs resize. This condition is not fatal, but fsck.ocfs2 should be run to fix it

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.0/5351 is trying to acquire lock:
ffffffff90261520 (shrinker_mutex){+.+.}-{4:4}, at: shrinker_free+0xdb/0x3b0 mm/shrinker.c:809

but task is already holding lock:
ffff88804228c2f8 (&osb->journal_shutdown_sem){++++}-{4:4}, at: ocfs2_journal_shutdown+0x4ec/0xb40 fs/ocfs2/journal.c:1122

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&osb->journal_shutdown_sem){++++}-{4:4}:
       down_read+0x45/0x320 kernel/locking/rwsem.c:1574
       ocfs2_clear_inode fs/ocfs2/inode.c:1326 [inline]
       ocfs2_evict_inode+0x2dd8/0x43c0 fs/ocfs2/inode.c:1343
       evict+0x6bf/0xc20 fs/inode.c:829
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       dentry_kill+0x1b9/0x910 fs/dcache.c:857
       shrink_kill fs/dcache.c:1317 [inline]
       shrink_dentry_list+0x209/0x310 fs/dcache.c:1334
       prune_dcache_sb+0x119/0x180 fs/dcache.c:1416
       super_cache_scan+0x362/0x4a0 fs/super.c:225
       do_shrink_slab+0x6d0/0x10d0 mm/shrinker.c:452
       shrink_slab_memcg mm/shrinker.c:569 [inline]
       shrink_slab+0x838/0x1210 mm/shrinker.c:647
       shrink_one+0x396/0x10f0 mm/vmscan.c:5320
       shrink_many mm/vmscan.c:5381 [inline]
       lru_gen_shrink_node mm/vmscan.c:5459 [inline]
       shrink_node+0x631e/0x6c50 mm/vmscan.c:6465
       kswapd_shrink_node mm/vmscan.c:7258 [inline]
       balance_pgdat mm/vmscan.c:7429 [inline]
       kswapd+0x1ff4/0x3a20 mm/vmscan.c:7705
       kthread+0x38b/0x480 kernel/kthread.c:436
       ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #1 (fs_reclaim){+.+.}-{0:0}:
       __fs_reclaim_acquire mm/page_alloc.c:4388 [inline]
       fs_reclaim_acquire+0x71/0x100 mm/page_alloc.c:4402
       might_alloc include/linux/sched/mm.h:316 [inline]
       slab_pre_alloc_hook mm/slub.c:4673 [inline]
       slab_alloc_node mm/slub.c:5011 [inline]
       __do_kmalloc_node mm/slub.c:5530 [inline]
       __kvmalloc_node_noprof+0x134/0x820 mm/slub.c:7143
       alloc_shrinker_info+0xe9/0x400 mm/shrinker.c:101
       mem_cgroup_css_online+0x84/0x7b0 mm/memcontrol.c:4396
       online_css+0xbf/0x310 kernel/cgroup/cgroup.c:5903
       css_create kernel/cgroup/cgroup.c:5983 [inline]
       cgroup_apply_control_enable+0x9ed/0xda0 kernel/cgroup/cgroup.c:3474
       cgroup_mkdir+0x1220/0x14b0 kernel/cgroup/cgroup.c:6188
       kernfs_iop_mkdir+0x213/0x360 fs/kernfs/dir.c:1304
       vfs_mkdir+0x411/0x660 fs/namei.c:5428
       filename_mkdirat+0x284/0x550 fs/namei.c:5461
       __do_sys_mkdirat fs/namei.c:5482 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5479
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x171/0x540 arch/x86/entry/syscall_64.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (shrinker_mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3209 [inline]
       check_prevs_add kernel/locking/lockdep.c:3328 [inline]
       validate_chain kernel/locking/lockdep.c:3952 [inline]
       __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
       __mutex_lock_common kernel/locking/mutex.c:646 [inline]
       __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
       shrinker_free+0xdb/0x3b0 mm/shrinker.c:809
       jbd2_journal_destroy+0x606/0x7e0 fs/jbd2/journal.c:2178
       ocfs2_journal_shutdown+0x517/0xb40 fs/ocfs2/journal.c:1125
       ocfs2_dismount_volume+0x3c9/0x860 fs/ocfs2/super.c:1874
       generic_shutdown_super+0x140/0x2d0 fs/super.c:723
       kill_block_super+0x44/0xa0 fs/super.c:1852
       deactivate_locked_super+0xbe/0x110 fs/super.c:558
       cleanup_mnt+0x204/0x2a0 fs/namespace.c:1396
       task_work_run+0x1d9/0x260 kernel/task_work.c:233
       exit_task_work include/linux/task_work.h:40 [inline]
       do_exit+0x705/0x2360 kernel/exit.c:980
       do_group_exit+0x22d/0x2f0 kernel/exit.c:1123
       get_signal+0x136a/0x1430 kernel/signal.c:3113
       arch_do_signal_or_restart+0xbb/0x860 arch/x86/kernel/signal.c:337
       __exit_to_user_mode_loop kernel/entry/common.c:66 [inline]
       exit_to_user_mode_loop+0x10e/0x770 kernel/entry/common.c:101
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:343 [inline]
       do_syscall_64+0x336/0x540 arch/x86/entry/syscall_64.c:107
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  shrinker_mutex --> fs_reclaim --> &osb->journal_shutdown_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&osb->journal_shutdown_sem);
                               lock(fs_reclaim);
                               lock(&osb->journal_shutdown_sem);
  lock(shrinker_mutex);

 *** DEADLOCK ***

locks held by syz.0.0/5351: 2, on CPU#0:
 #0: ffff88801342e100 (&type->s_umount_key#53){++++}-{4:4}, at: __super_lock fs/super.c:60 [inline]
 #0: ffff88801342e100 (&type->s_umount_key#53){++++}-{4:4}, at: __super_lock_excl fs/super.c:75 [inline]
 #0: ffff88801342e100 (&type->s_umount_key#53){++++}-{4:4}, at: deactivate_super+0xac/0xe0 fs/super.c:585
 #1: ffff88804228c2f8 (&osb->journal_shutdown_sem){++++}-{4:4}, at: ocfs2_journal_shutdown+0x4ec/0xb40 fs/ocfs2/journal.c:1122

stack backtrace:
CPU: 0 UID: 0 PID: 5351 Comm: syz.0.0 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2087
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2219
 check_prev_add kernel/locking/lockdep.c:3209 [inline]
 check_prevs_add kernel/locking/lockdep.c:3328 [inline]
 validate_chain kernel/locking/lockdep.c:3952 [inline]
 __lock_acquire+0x164c/0x2de0 kernel/locking/lockdep.c:5288
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5942
 __mutex_lock_common kernel/locking/mutex.c:646 [inline]
 __mutex_lock+0x197/0x15a0 kernel/locking/mutex.c:821
 shrinker_free+0xdb/0x3b0 mm/shrinker.c:809
 jbd2_journal_destroy+0x606/0x7e0 fs/jbd2/journal.c:2178
 ocfs2_journal_shutdown+0x517/0xb40 fs/ocfs2/journal.c:1125
 ocfs2_dismount_volume+0x3c9/0x860 fs/ocfs2/super.c:1874
 generic_shutdown_super+0x140/0x2d0 fs/super.c:723
 kill_block_super+0x44/0xa0 fs/super.c:1852
 deactivate_locked_super+0xbe/0x110 fs/super.c:558
 cleanup_mnt+0x204/0x2a0 fs/namespace.c:1396
 task_work_run+0x1d9/0x260 kernel/task_work.c:233
 exit_task_work include/linux/task_work.h:40 [inline]
 do_exit+0x705/0x2360 kernel/exit.c:980
 do_group_exit+0x22d/0x2f0 kernel/exit.c:1123
 get_signal+0x136a/0x1430 kernel/signal.c:3113
 arch_do_signal_or_restart+0xbb/0x860 arch/x86/kernel/signal.c:337
 __exit_to_user_mode_loop kernel/entry/common.c:66 [inline]
 exit_to_user_mode_loop+0x10e/0x770 kernel/entry/common.c:101
 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
 syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
 syscall_exit_to_user_mode include/linux/entry-common.h:343 [inline]
 do_syscall_64+0x336/0x540 arch/x86/entry/syscall_64.c:107
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f27f09a9559
Code: Unable to access opcode bytes at 0x7f27f09a952f.
RSP: 002b:00007f27f182a0a8 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: fffffffffffffe00 RBX: 00007f27f0c25fa8 RCX: 00007f27f09a9559
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00007f27f0c25fa8
RBP: 00007f27f0c25fa0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f27f0c26038 R14: 00007ffd3e516330 R15: 00007ffd3e516418
 </TASK>
ocfs2: Unmounting device (7,0) on (node local)

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/20 08:14 upstream f1715c0c0460 69566a15 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in shrinker_free
2026/11/19 16:41 upstream 4405c18c95d2 05b5d0a5 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in shrinker_free
2026/11/19 16:12 upstream 4405c18c95d2 05b5d0a5 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in shrinker_free
* Struck through repros no longer work on HEAD.