KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit

Status: moderation: reported on 2026/11/20 00:03
Subsystems: trace
Labels: race:benign prio:low
[Documentation on labels]
Reported-by: syzbot+321e4dd9c8425252f4d3@syzkaller.appspotmail.com
First crash: 2d22h, last: 2h28m
✨ AI-generated root cause summary:

A KCSAN data race occurs on struct trace_event_file::flags between event_enable_trigger() on one CPU atomically toggling EVENT_FILE_FL_SOFT_DISABLED_BIT via set_bit()/clear_bit() and __event_trigger_test_discard() (inlined into trace_event_buffer_commit()) on another CPU performing plain, unmarked reads of file->flags. As documented on struct trace_event_file::flags, flag readers execute locklessly and tolerate stale flag visibility, but __event_trigger_test_discard() lacks READ_ONCE() (and re-reads file->flags multiple times instead of reusing a single READ_ONCE() snapshot). This causes KCSAN to flag the concurrent unmarked read against the marked atomic bit operation.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 4405c18c95d2:

Root Cause Analysis

The KCSAN data race is on the unsigned long flags field of struct trace_event_file (include/linux/trace_events.h:680).

  1. Write side (kernel/trace/trace_events_trigger.c): When an enable_event / disable_event trigger attached to an event (here sched:sched_switch on CPU 0) fires, __trace_trigger_soft_disabled() -> event_triggers_call() -> data_ops_trigger() invokes event_enable_trigger() (kernel/trace/trace_events_trigger.c:1670-1680). event_enable_trigger() updates the target struct trace_event_file (enable_data->file) via atomic bit operations:

    if (enable_data->enable)
        clear_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags);
    else
        set_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &enable_data->file->flags);
    
  2. Read side (kernel/trace/trace.h / kernel/trace/trace.c): Concurrently on CPU 1, the target trace event (sched:sched_process_fork) executes trace_event_buffer_commit() (kernel/trace/trace.c:2020-2042), which calls the inline helper __event_trigger_test_discard() (kernel/trace/trace.h:1726-1757). At line 1732, __event_trigger_test_discard() performs a plain, unmarked read of file->flags:

    unsigned long eflags = file->flags;
    

    It then re-reads file->flags plainly at lines 1737, 1742, 1745, and 1749 (checking EVENT_FILE_FL_SOFT_DISABLED, EVENT_FILE_FL_FILTERED, and EVENT_FILE_FL_PID_FILTER) rather than reusing a single READ_ONCE(file->flags) snapshot.

  3. Invariant and Trigger Mechanism: As documented in include/linux/trace_events.h:672-678, trace_event_file::flags is intentionally read locklessly in tracepoint fast paths while writers update individual bits atomically (set_bit() / clear_bit()). Because __event_trigger_test_discard() (as well as other lockless readers such as trace_trigger_soft_disabled(), __trace_trigger_soft_disabled(), and trace_event_buffer_lock_reserve()) accesses file->flags using plain C reads instead of READ_ONCE(), KCSAN reports a data race against the marked atomic write in event_enable_trigger().

    Additionally, if EVENT_FILE_FL_SOFT_DISABLED changes between trace_event_buffer_lock_reserve() (kernel/trace/trace.c:1882) and trace_event_buffer_commit(), both commit (__buffer_unlock_commit() at kernel/trace/trace.h:1687) and discard (__trace_event_discard_commit() at kernel/trace/trace.h:1702) distinguish temporary per-CPU trace_buffered_event buffers from regular ring-buffer entries via this_cpu_read(trace_buffered_event) == event, keeping ring-buffer state and preemption counts balanced.

Fix Direction

Use READ_ONCE(file->flags) when sampling file->flags in __event_trigger_test_discard() (and reuse the sampled eflags variable for the subsequent flag checks in kernel/trace/trace.h:1732-1750, as well as in other lockless readers of trace_event_file::flags such as trace_trigger_soft_disabled(), __trace_trigger_soft_disabled(), and trace_event_buffer_lock_reserve()).

▶ ▼ ✨ AI Jobs (2)
ID Workflow Result Correct Bug Created Started Finished Revision
8abf0498 assessment-security DenialOfService: ❌ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ❌ NetworkTrigger: ❌ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ❌ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit 2026/11/19 20:13 2026/11/19 20:13 2026/11/19 20:17 229865fb
562ce00f assessment-kcsan Benign: ✅ ❓ KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit 2026/11/19 20:13 2026/11/19 20:13 2026/11/19 20:15 229865fb

Sample crash report:
==================================================================
BUG: KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit

write (marked) to 0xffff888100172ac8 of 8 bytes by task 3330 on cpu 0:
 event_enable_trigger+0x49/0x70 kernel/trace/trace_events_trigger.c:-1
 data_ops_trigger kernel/trace/trace_events_trigger.c:154 [inline]
 event_triggers_call kernel/trace/trace_events_trigger.c:199 [inline]
 __trace_trigger_soft_disabled+0x10f/0x1a0 kernel/trace/trace_events_trigger.c:220
 trace_trigger_soft_disabled include/linux/trace_events.h:777 [inline]
 do_trace_event_raw_event_sched_switch include/trace/events/sched.h:220 [inline]
 trace_event_raw_event_sched_switch+0x186/0x1a0 include/trace/events/sched.h:220
 __traceiter_sched_switch+0x3f/0x60 include/trace/events/sched.h:220
 __do_trace_sched_switch include/trace/events/sched.h:220 [inline]
 trace_sched_switch include/trace/events/sched.h:220 [inline]
 __schedule+0xc3d/0xd30 kernel/sched/core.c:7383
 __schedule_loop kernel/sched/core.c:7463 [inline]
 schedule+0x5b/0xa0 kernel/sched/core.c:7478
 do_nanosleep+0xd6/0x3d0 kernel/time/hrtimer.c:2441
 hrtimer_nanosleep+0xd5/0x1e0 kernel/time/hrtimer.c:2487
 common_nsleep+0x62/0x80 kernel/time/posix-timers.c:1373
 __do_sys_clock_nanosleep kernel/time/posix-timers.c:1419 [inline]
 __se_sys_clock_nanosleep+0x223/0x260 kernel/time/posix-timers.c:1396
 __x64_sys_clock_nanosleep+0x55/0x70 kernel/time/posix-timers.c:1396
 x64_sys_call+0x244d/0x2550 arch/x86/include/generated/asm/syscalls_64.h:231
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

read to 0xffff888100172ac8 of 8 bytes by task 4765 on cpu 1:
 __event_trigger_test_discard kernel/trace/trace.h:1732 [inline]
 trace_event_buffer_commit+0x5c/0x5b0 kernel/trace/trace.c:2025
 do_trace_event_raw_event_sched_process_fork include/trace/events/sched.h:396 [inline]
 trace_event_raw_event_sched_process_fork+0x153/0x1b0 include/trace/events/sched.h:396
 __do_trace_sched_process_fork include/trace/events/sched.h:396 [inline]
 trace_sched_process_fork include/trace/events/sched.h:396 [inline]
 kernel_clone+0x621/0x640 kernel/fork.c:2808
 __do_sys_clone kernel/fork.c:2940 [inline]
 __se_sys_clone kernel/fork.c:2924 [inline]
 __x64_sys_clone+0x143/0x180 kernel/fork.c:2924
 x64_sys_call+0x2479/0x2550 arch/x86/include/generated/asm/syscalls_64.h:57
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x11e/0x3a0 arch/x86/entry/syscall_64.c:89
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 UID: 0 PID: 4765 Comm: dhcpcd-run-hook Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
==================================================================

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/19 22:18 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
2026/11/19 08:07 upstream 4405c18c95d2 f138241c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
2026/11/19 02:47 upstream 4405c18c95d2 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
2026/11/18 20:07 upstream 20eef29b7c84 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
2026/11/18 20:06 upstream 20eef29b7c84 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
2026/11/17 02:43 upstream 666539eecdf4 a3e64cfc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in event_enable_trigger / trace_event_buffer_commit
* Struck through repros no longer work on HEAD.