UBSAN: array-index-out-of-bounds in taprio_change

Status: fixed on 2021/11/10 00:50
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+2b3e5fb6c7ef285a94f6@syzkaller.appspotmail.com
Fix commit: efe487fce306 fix array-index-out-of-bounds in taprio_change
First crash: 1821d, last: 1813d
▶ ▼ Discussions (12)
Title Replies (including bot) Last reply
[PATCH 5.13 000/380] 5.13.19-rc1 review 391 (391) 2021/10/01 17:10
[PATCH 5.4 000/260] 5.4.148-rc1 review 268 (268) 2021/09/22 05:31
[PATCH 5.10 000/306] 5.10.67-rc1 review 323 (323) 2021/09/20 05:00
[PATCH 5.14 000/432] 5.14.6-rc1 review 439 (439) 2021/09/17 17:59
[PATCH AUTOSEL 5.14 001/252] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC 278 (278) 2021/09/14 13:44
[PATCH AUTOSEL 5.13 001/219] drm/vmwgfx: Fix subresource updates with new contexts 226 (226) 2021/09/11 14:38
[PATCH AUTOSEL 5.4 001/109] drm/amdgpu: Fix amdgpu_ras_eeprom_init() 112 (112) 2021/09/09 13:00
[PATCH AUTOSEL 5.10 001/176] drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET 180 (180) 2021/09/09 13:00
[PATCH V2] fix array-index-out-of-bounds in taprio_change 4 (4) 2021/08/31 05:56
[PATCH] net:sched fix array-index-out-of-bounds in taprio_change 8 (8) 2021/08/30 16:10
[PATCH] net:sched fix array-index-out-of-bounds in taprio_change 1 (1) 2021/08/11 04:09
[syzbot] UBSAN: array-index-out-of-bounds in taprio_change 0 (1) 2021/08/10 10:14

Sample crash report:
UBSAN: array-index-out-of-bounds in net/sched/sch_taprio.c:1519:10
index 16 is out of range for type '__u16 [16]'
CPU: 0 PID: 13032 Comm: syz-executor.2 Not tainted 5.14.0-rc5-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1d3/0x29f lib/dump_stack.c:105
 ubsan_epilogue lib/ubsan.c:148 [inline]
 __ubsan_handle_out_of_bounds+0xdb/0x130 lib/ubsan.c:288
 taprio_change+0x33d0/0x5c90 net/sched/sch_taprio.c:1519
 qdisc_create+0x7c2/0x1480 net/sched/sch_api.c:1247
 tc_modify_qdisc+0xa88/0x1ea0 net/sched/sch_api.c:1646
 rtnetlink_rcv_msg+0x91c/0xe50 net/core/rtnetlink.c:5574
 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2504
 netlink_unicast_kernel net/netlink/af_netlink.c:1314 [inline]
 netlink_unicast+0x7de/0x9b0 net/netlink/af_netlink.c:1340
 netlink_sendmsg+0x9e7/0xe00 net/netlink/af_netlink.c:1929
 sock_sendmsg_nosec net/socket.c:703 [inline]
 sock_sendmsg net/socket.c:723 [inline]
 ____sys_sendmsg+0x5a2/0x900 net/socket.c:2392
 ___sys_sendmsg net/socket.c:2446 [inline]
 __sys_sendmsg+0x319/0x400 net/socket.c:2475
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x4665e9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f399085a188 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665e9
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000007
RBP: 00000000004bfcc4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf80
R13: 00007ffe9b94383f R14: 00007f399085a300 R15: 0000000000022000
================================================================================

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/08/10 08:26 upstream 36a21d51725a 6972b106 .config console log report info ci-upstream-kasan-gce-smack-root UBSAN: array-index-out-of-bounds in taprio_change
2021/08/18 10:35 net-old 276e189f8e4e a2fe1cb5 .config console log report info ci-upstream-net-this-kasan-gce UBSAN: array-index-out-of-bounds in taprio_change
* Struck through repros no longer work on HEAD.