syzbot


possible deadlock in ntfs_file_write_iter

Status: upstream: reported on 2025/06/26 14:52
Reported-by: syzbot+2a58b3031895d04feb3a@syzkaller.appspotmail.com
First crash: 11d, last: 5d03h
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ntfs_file_write_iter origin:lts-only C inconclusive 294 2d01h 322d 0/3 upstream: reported C repro on 2024/08/19 12:03
upstream possible deadlock in ntfs_file_write_iter ntfs3 C done 126 1d07h 388d 0/29 upstream: reported C repro on 2024/06/15 08:45
linux-6.1 possible deadlock in ntfs_file_write_iter origin:lts-only C error 254 11d 338d 0/3 upstream: reported C repro on 2024/08/03 11:07

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.6.95-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.2009/11343 is trying to acquire lock:
ffff888017869e20 (&mm->mmap_lock){++++}-{3:3}, at: internal_get_user_pages_fast+0x204/0x2730 mm/gup.c:3195

but task is already holding lock:
ffff88805f0e83b0 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:824 [inline]
ffff88805f0e83b0 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ntfs_file_write_iter+0x23e/0x700 fs/ntfs3/file.c:1093

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ntfs_file_mmap+0x54c/0x730 fs/ntfs3/file.c:302
       call_mmap include/linux/fs.h:2023 [inline]
       mmap_file mm/internal.h:98 [inline]
       __mmap_region mm/mmap.c:2786 [inline]
       mmap_region+0xe57/0x1f80 mm/mmap.c:2937
       do_mmap+0x8d1/0xfd0 mm/mmap.c:1381
       vm_mmap_pgoff+0x1c0/0x400 mm/util.c:556
       ksys_mmap_pgoff+0x520/0x700 mm/mmap.c:1427
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       internal_get_user_pages_fast+0x21d/0x2730 mm/gup.c:3195
       iov_iter_extract_user_pages lib/iov_iter.c:1785 [inline]
       iov_iter_extract_pages+0x393/0x790 lib/iov_iter.c:1848
       dio_refill_pages fs/direct-io.c:173 [inline]
       dio_get_page fs/direct-io.c:214 [inline]
       do_direct_IO fs/direct-io.c:914 [inline]
       __blockdev_direct_IO+0x10d6/0x3420 fs/direct-io.c:1248
       blockdev_direct_IO include/linux/fs.h:3047 [inline]
       ntfs_direct_IO+0x196/0x3a0 fs/ntfs3/inode.c:801
       generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
       ntfs_file_write_iter+0x61c/0x700 fs/ntfs3/file.c:1120
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x79a/0xc70 fs/read_write.c:860
       vfs_writev fs/read_write.c:933 [inline]
       do_pwritev+0x205/0x340 fs/read_write.c:1030
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sb->s_type->i_mutex_key#20);
                               lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#20);
  rlock(&mm->mmap_lock);

 *** DEADLOCK ***

2 locks held by syz.2.2009/11343:
 #0: ffff88802c8f8418 (sb_writers#13){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:932 [inline]
 #0: ffff88802c8f8418 (sb_writers#13){.+.+}-{0:0}, at: do_pwritev+0x1f3/0x340 fs/read_write.c:1030
 #1: ffff88805f0e83b0 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:824 [inline]
 #1: ffff88805f0e83b0 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ntfs_file_write_iter+0x23e/0x700 fs/ntfs3/file.c:1093

stack backtrace:
CPU: 1 PID: 11343 Comm: syz.2.2009 Not tainted 6.6.95-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 internal_get_user_pages_fast+0x21d/0x2730 mm/gup.c:3195
 iov_iter_extract_user_pages lib/iov_iter.c:1785 [inline]
 iov_iter_extract_pages+0x393/0x790 lib/iov_iter.c:1848
 dio_refill_pages fs/direct-io.c:173 [inline]
 dio_get_page fs/direct-io.c:214 [inline]
 do_direct_IO fs/direct-io.c:914 [inline]
 __blockdev_direct_IO+0x10d6/0x3420 fs/direct-io.c:1248
 blockdev_direct_IO include/linux/fs.h:3047 [inline]
 ntfs_direct_IO+0x196/0x3a0 fs/ntfs3/inode.c:801
 generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3941
 __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4097
 ntfs_file_write_iter+0x61c/0x700 fs/ntfs3/file.c:1120
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x79a/0xc70 fs/read_write.c:860
 vfs_writev fs/read_write.c:933 [inline]
 do_pwritev+0x205/0x340 fs/read_write.c:1030
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fc7bed8e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fc7bfc66038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007fc7befb5fa0 RCX: 00007fc7bed8e929
RDX: 0000000000000014 RSI: 0000200000000240 RDI: 0000000000000004
RBP: 00007fc7bee10b39 R08: 0000000000000000 R09: 0000000000000003
R10: 0000000000007800 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fc7befb5fa0 R15: 00007ffdd6b833d8
 </TASK>

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/07/03 05:28 linux-6.6.y 3f5b4c104b7d 115ceea7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
2025/06/30 23:43 linux-6.6.y 3f5b4c104b7d 6e83b42d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
2025/06/30 23:41 linux-6.6.y 3f5b4c104b7d 6e83b42d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
2025/06/28 03:51 linux-6.6.y 3f5b4c104b7d fc9d8ee5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
2025/06/26 14:51 linux-6.6.y 6282921b6825 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
2025/06/26 14:51 linux-6.6.y 6282921b6825 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-6-kasan possible deadlock in ntfs_file_write_iter
* Struck through repros no longer work on HEAD.