general protection fault in pk_probe

Status: fixed on 2019/10/15 23:40
Subsystems: input usb
[Documentation on labels]
Reported-by: syzbot+1088533649dafa1c9004@syzkaller.appspotmail.com
Fix commit: 98375b86c791 HID: prodikeys: Fix general protection fault during probe
First crash: 2532d, last: 2532d
▶ ▼ Discussions (9)
Title Replies (including bot) Last reply
[PATCH 3.16 00/72] 3.16.79-rc1 review 87 (87) 2019/12/14 18:44
[PATCH 4.14 000/185] 4.14.147-stable review 191 (191) 2019/10/05 00:10
[PATCH 4.9 000/129] 4.9.195-stable review 135 (135) 2019/10/04 22:56
[PATCH 4.4 00/99] 4.4.195-stable review 105 (105) 2019/10/04 22:55
[PATCH 4.19 00/63] 4.19.76-stable review 83 (83) 2019/10/02 13:16
[PATCH 5.2 00/45] 5.2.18-stable review 54 (54) 2019/10/01 22:58
[PATCH 5.3 00/25] 5.3.2-stable review 34 (34) 2019/10/01 16:59
[PATCH] HID: hid-prodikeys: Fix general protection fault during probe 2 (2) 2019/09/05 13:03
general protection fault in pk_probe 1 (3) 2019/09/03 19:46
▶ ▼ Last patch testing requests (1)
Created Duration User Patch Repo Result
2019/09/03 19:27 17m stern@rowland.harvard.edu patch https://github.com/google/kasan.git eea39f24 OK

Sample crash report:
prodikeys 0003:041E:2801.0001: unknown main item tag 0x0
prodikeys 0003:041E:2801.0001: unknown main item tag 0x0
prodikeys 0003:041E:2801.0001: hidraw0: USB HID v0.00 Device [HID 041e:2801] on usb-dummy_hcd.0-1/input1
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN
CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc5+ #28
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:pcmidi_submit_output_report drivers/hid/hid-prodikeys.c:300 [inline]
RIP: 0010:pcmidi_set_operational drivers/hid/hid-prodikeys.c:558 [inline]
RIP: 0010:pcmidi_snd_initialise drivers/hid/hid-prodikeys.c:686 [inline]
RIP: 0010:pk_probe+0xb51/0xfd0 drivers/hid/hid-prodikeys.c:836
Code: 0f 85 50 04 00 00 48 8b 04 24 4c 89 7d 10 48 8b 58 08 e8 b2 53 e4 fc 48 8b 54 24 20 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 13 04 00 00 48 ba 00 00 00 00 00 fc ff df 49 8b
RSP: 0018:ffff8881da20ee10 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff8881d2d40000 RCX: ffffffff8459833e
RDX: 0000000000000006 RSI: ffffffff8459862e RDI: ffff8881d2aee610
RBP: ffff8881d2aee600 R08: ffff8881da1f9800 R09: ffffed103b64677c
R10: ffffed103b64677b R11: ffff8881db233bdb R12: ffff8881d2d40000
R13: 0000000000000000 R14: ffff8881d4ec4ab0 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8881db200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2fc6afa518 CR3: 00000001d099d000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 hid_device_probe+0x2be/0x3f0 drivers/hid/hid-core.c:2209
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 hid_add_device+0x33c/0x990 drivers/hid/hid-core.c:2365
 usbhid_probe+0xa81/0xfa0 drivers/hid/usbhid/hid-core.c:1386
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x101/0x1b0 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:454
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
 device_add+0xae6/0x16f0 drivers/base/core.c:2165
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2269
 worker_thread+0x96/0xe20 kernel/workqueue.c:2415
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace 57a1aecde3464295 ]---
RIP: 0010:pcmidi_submit_output_report drivers/hid/hid-prodikeys.c:300 [inline]
RIP: 0010:pcmidi_set_operational drivers/hid/hid-prodikeys.c:558 [inline]
RIP: 0010:pcmidi_snd_initialise drivers/hid/hid-prodikeys.c:686 [inline]
RIP: 0010:pk_probe+0xb51/0xfd0 drivers/hid/hid-prodikeys.c:836
Code: 0f 85 50 04 00 00 48 8b 04 24 4c 89 7d 10 48 8b 58 08 e8 b2 53 e4 fc 48 8b 54 24 20 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 13 04 00 00 48 ba 00 00 00 00 00 fc ff df 49 8b
RSP: 0018:ffff8881da20ee10 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff8881d2d40000 RCX: ffffffff8459833e
RDX: 0000000000000006 RSI: ffffffff8459862e RDI: ffff8881d2aee610
RBP: ffff8881d2aee600 R08: ffff8881da1f9800 R09: ffffed103b64677c
R10: ffffed103b64677b R11: ffff8881db233bdb R12: ffff8881d2d40000
R13: 0000000000000000 R14: ffff8881d4ec4ab0 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8881db200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2fc6afa518 CR3: 00000001d099d000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/30 18:02 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 9adfa876 .config console log report syz C ci2-upstream-usb
2019/08/30 17:37 https://github.com/google/kasan.git usb-fuzzer eea39f24f4a5 9adfa876 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.