syzbot

loop2: detected capacity change from 0 to 262144
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.612/10251 is trying to acquire lock:
ffff88805df85b90 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_xattr_ibody_find+0x14b/0x7c0 fs/ocfs2/xattr.c:2689

but task is already holding lock:
ffff88805df85c18 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set_handle+0x3b0/0x7a0 fs/ocfs2/xattr.c:3501

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x1a5/0x7b0 fs/ocfs2/acl.c:367
       ocfs2_mknod+0x12ff/0x2030 fs/ocfs2/namei.c:413
       vfs_mknod+0x534/0x590 fs/namei.c:4988
       do_mknodat+0x3d0/0x620 fs/namei.c:-1
       __do_sys_mknod fs/namei.c:5076 [inline]
       __se_sys_mknod fs/namei.c:5074 [inline]
       __x64_sys_mknod+0x8c/0xa0 fs/namei.c:5074
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x377/0x6d0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:767
       dquot_load_quota_sb+0x791/0xbd0 fs/quota/dquot.c:2462
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2499
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5155/0x65b0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40e/0x4d0 fs/super.c:1699
       vfs_get_tree+0x92/0x2a0 fs/super.c:1759
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount+0x302/0xa10 fs/namespace.c:3712
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount+0x313/0x410 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x36b/0x6d0 fs/ocfs2/journal.c:372
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:767
       dquot_load_quota_sb+0x791/0xbd0 fs/quota/dquot.c:2462
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2499
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5155/0x65b0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40e/0x4d0 fs/super.c:1699
       vfs_get_tree+0x92/0x2a0 fs/super.c:1759
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount+0x302/0xa10 fs/namespace.c:3712
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount+0x313/0x410 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#6){.+.+}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5574 [inline]
       lock_release+0x1ab/0x3b0 kernel/locking/lockdep.c:5889
       up_write+0x1a/0x60 kernel/locking/rwsem.c:1642
       inode_unlock include/linux/fs.h:1037 [inline]
       ocfs2_free_ac_resource fs/ocfs2/suballoc.c:130 [inline]
       ocfs2_free_alloc_context+0x97/0x1a0 fs/ocfs2/suballoc.c:144
       ocfs2_write_begin_nolock+0x4256/0x4300 fs/ocfs2/aops.c:1804
       ocfs2_write_begin+0x1bb/0x310 fs/ocfs2/aops.c:1884
       generic_perform_write+0x29d/0x8c0 mm/filemap.c:4300
       ocfs2_file_write_iter+0x1585/0x1d00 fs/ocfs2/file.c:2469
       new_sync_write fs/read_write.c:593 [inline]
       vfs_write+0x5d5/0xb40 fs/read_write.c:686
       ksys_write+0x14b/0x260 fs/read_write.c:738
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a6/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x117/0x340 kernel/locking/lockdep.c:5868
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
       ocfs2_xattr_ibody_find+0x14b/0x7c0 fs/ocfs2/xattr.c:2689
       ocfs2_xattr_set_handle+0x3c6/0x7a0 fs/ocfs2/xattr.c:3503
       ocfs2_init_security_set+0xbd/0xe0 fs/ocfs2/xattr.c:7307
       ocfs2_mknod+0x135d/0x2030 fs/ocfs2/namei.c:422
       ocfs2_mkdir+0x181/0x420 fs/ocfs2/namei.c:659
       vfs_mkdir+0x52d/0x5d0 fs/namei.c:5130
       do_mkdirat+0x27a/0x4b0 fs/namei.c:5164
       __do_sys_mkdirat fs/namei.c:5186 [inline]
       __se_sys_mkdirat fs/namei.c:5184 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:5184
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  rlock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

9 locks held by syz.2.612/10251:
 #0: ffff88803179e480 (sb_writers#25){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499
 #1: ffff88805bf51c40 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline]
 #1: ffff88805bf51c40 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2864 [inline]
 #1: ffff88805bf51c40 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2875 [inline]
 #1: ffff88805bf51c40 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: filename_create+0x1fb/0x360 fs/namei.c:4879
 #2: ffff88805bf08b80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff88805bf08b80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x45b0 fs/ocfs2/suballoc.c:788
 #3: ffff88805bf0ce80 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #3: ffff88805bf0ce80 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x45b0 fs/ocfs2/suballoc.c:788
 #4: ffff88805bf0f000 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #4: ffff88805bf0f000 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24b0 fs/ocfs2/localalloc.c:636
 #5: ffff88803179e770 (sb_internal#6){.+.+}-{0:0}, at: ocfs2_mknod+0xe71/0x2030 fs/ocfs2/namei.c:364
 #6: ffff8880356f3118 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x36b/0x6d0 fs/ocfs2/journal.c:372
 #7: ffff888053580bb0 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f87/0x21c0 fs/jbd2/transaction.c:444
 #8: ffff88805df85c18 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set_handle+0x3b0/0x7a0 fs/ocfs2/xattr.c:3501

stack backtrace:
CPU: 1 UID: 0 PID: 10251 Comm: syz.2.612 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a6/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x117/0x340 kernel/locking/lockdep.c:5868
 down_read+0x97/0x1f0 kernel/locking/rwsem.c:1537
 ocfs2_xattr_ibody_find+0x14b/0x7c0 fs/ocfs2/xattr.c:2689
 ocfs2_xattr_set_handle+0x3c6/0x7a0 fs/ocfs2/xattr.c:3503
 ocfs2_init_security_set+0xbd/0xe0 fs/ocfs2/xattr.c:7307
 ocfs2_mknod+0x135d/0x2030 fs/ocfs2/namei.c:422
 ocfs2_mkdir+0x181/0x420 fs/ocfs2/namei.c:659
 vfs_mkdir+0x52d/0x5d0 fs/namei.c:5130
 do_mkdirat+0x27a/0x4b0 fs/namei.c:5164
 __do_sys_mkdirat fs/namei.c:5186 [inline]
 __se_sys_mkdirat fs/namei.c:5184 [inline]
 __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:5184
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe39bacde97
Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe399d2de68 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fe399d2def0 RCX: 00007fe39bacde97
RDX: 00000000000001ff RSI: 00002000000000c0 RDI: 00000000ffffff9c
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00002000000000c0
R13: 00007fe399d2deb0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>