general protection fault in tls_trim_both_msgs

Status: fixed on 2019/08/27 17:15
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+0e0fedcad708d12d3032@syzkaller.appspotmail.com
Fix commit: 5d92e631b8be net/tls: partially revert fix transition through disconnect with close
First crash: 2569d, last: 2557d
Cause bisection: introduced by (bisect log) :
commit 32857cf57f920cdc03b5095f08febec94cf9c36b
Author: John Fastabend <john.fastabend@gmail.com>
Date: Fri Jul 19 17:29:18 2019 +0000

  net/tls: fix transition through disconnect with close

Crash: INFO: rcu detected stall in ipv6_rcv (log)
Repro: C syz .config
  
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
general protection fault in tls_trim_both_msgs 1 (4) 2019/07/28 03:46

Sample crash report:
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 10325 Comm: syz-executor477 Not tainted 5.3.0-rc2-next-20190802 #58
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:tls_trim_both_msgs+0x54/0x130 net/tls/tls_sw.c:268
Code: 48 c1 ea 03 80 3c 02 00 0f 85 e3 00 00 00 4d 8b b5 b0 06 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7e 28 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 b3 00 00 00 48 b8 00 00 00 00 00 fc ff df 49 8b
RSP: 0018:ffff88808f307ac0 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff8880a8c6c040 RCX: ffffffff862ee8af
RDX: 0000000000000005 RSI: ffffffff862e29d6 RDI: 0000000000000028
RBP: ffff88808f307ae0 R08: ffff8880a89ca440 R09: ffffed1012599b59
R10: ffffed1012599b58 R11: ffff888092ccdac3 R12: 0000000000000000
R13: ffff88808e244c80 R14: 0000000000000000 R15: 00000000ffffffe0
FS:  00007f081ec67700(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffdffad3e6c CR3: 00000000a27ac000 CR4: 00000000001406e0
Call Trace:
 tls_sw_sendmsg+0xe38/0x17b0 net/tls/tls_sw.c:1057
 inet6_sendmsg+0x9e/0xe0 net/ipv6/af_inet6.c:576
 sock_sendmsg_nosec net/socket.c:637 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:657
 __sys_sendto+0x262/0x380 net/socket.c:1952
 __do_sys_sendto net/socket.c:1964 [inline]
 __se_sys_sendto net/socket.c:1960 [inline]
 __x64_sys_sendto+0xe1/0x1a0 net/socket.c:1960
 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4488b9
Code: e8 7c 1a 03 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 3b 0c fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f081ec66cd8 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 00000000006dec48 RCX: 00000000004488b9
RDX: ffffffffffffffc1 RSI: 00000000200005c0 RDI: 0000000000000004
RBP: 00000000006dec40 R08: 0000000000000000 R09: 1201000000003618
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006dec4c
R13: 00007ffc3bc6524f R14: 00007f081ec679c0 R15: 000000000000002d
Modules linked in:
---[ end trace 39a1eecb1865f82a ]---
RIP: 0010:tls_trim_both_msgs+0x54/0x130 net/tls/tls_sw.c:268
Code: 48 c1 ea 03 80 3c 02 00 0f 85 e3 00 00 00 4d 8b b5 b0 06 00 00 48 b8 00 00 00 00 00 fc ff df 49 8d 7e 28 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 b3 00 00 00 48 b8 00 00 00 00 00 fc ff df 49 8b
RSP: 0018:ffff88808f307ac0 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff8880a8c6c040 RCX: ffffffff862ee8af
RDX: 0000000000000005 RSI: ffffffff862e29d6 RDI: 0000000000000028
RBP: ffff88808f307ae0 R08: ffff8880a89ca440 R09: ffffed1012599b59
R10: ffffed1012599b58 R11: ffff888092ccdac3 R12: 0000000000000000
R13: ffff88808e244c80 R14: 0000000000000000 R15: 00000000ffffffe0
FS:  00007f081ec67700(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffdffad3e6c CR3: 00000000a27ac000 CR4: 00000000001406e0

Crashes (36):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/05 01:40 linux-next 7b4980e0bcf4 6affd8e8 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/08/02 13:50 linux-next 7b4980e0bcf4 835dffe7 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/07/28 15:09 linux-next fde50b96be82 c85e1c5b .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/07/27 11:40 linux-next fde50b96be82 c85e1c5b .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/08/05 00:55 linux-next 7b4980e0bcf4 6affd8e8 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/08/03 11:18 linux-next 7b4980e0bcf4 6affd8e8 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/08/02 09:06 linux-next 7b4980e0bcf4 835dffe7 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/08/05 15:16 linux-next b1645c0cbd48 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/05 15:14 linux-next b1645c0cbd48 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/05 11:00 linux-next b1645c0cbd48 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/05 10:58 linux-next b1645c0cbd48 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/05 00:16 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/05 00:16 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/04 11:12 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/04 04:02 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 14:00 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 11:26 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:58 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:38 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:34 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:21 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:18 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/03 08:13 linux-next 7b4980e0bcf4 6affd8e8 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/02 09:00 linux-next 7b4980e0bcf4 835dffe7 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/01 22:40 linux-next 882e8691130b 835dffe7 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/08/01 22:21 linux-next 882e8691130b 835dffe7 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/31 11:08 linux-next ce96e791d6a7 7c7ded69 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/30 03:38 linux-next 0d8b3265d9a6 f67095ee .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/28 03:12 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/27 11:11 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/27 03:30 linux-next fde50b96be82 c85e1c5b .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/26 05:07 linux-next 13bf6d6a51df 732bc5a0 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/25 20:23 linux-next 13bf6d6a51df 732bc5a0 .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 15:41 linux-next 9e6dfe8045f8 32329ceb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 10:49 linux-next 9e6dfe8045f8 32329ceb .config console log report ci-upstream-linux-next-kasan-gce-root
2019/07/24 09:58 linux-next 9e6dfe8045f8 32329ceb .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.